Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v5 01/70] binfmt_elf: Take the mmap lock when walking the VMA
 list
Thread-Topic: [PATCH v5 01/70] binfmt_elf: Take the mmap lock when walking the
 VMA list
Thread-Index: AQHYF95v8rQXPYT4EkqXvxYFLhjgiA==
Date:   Wed, 2 Feb 2022 02:41:53 +0000
Message-ID: <20220202024137.2516438-2-Liam.Howlett@oracle.com>
References: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?FCIUsQbwO+rI+VM2eQKPEQzZjfh0r/IUkezxvG7xj81AImAeSC/jv8tm34?=
 =?iso-8859-1?Q?+HIO94cuJ/5v3A8QyZjp+qvQjpmsXnmYQKhKZRQS+2JI7Lq3bBCTt8Yzcm?=
 =?iso-8859-1?Q?r9ZqD22zYwWXBwv9OMnKIRdxXFmFqsP7fmqd+dAUr3BN58C+vsoB0We20+?=
 =?iso-8859-1?Q?PM4PRx7udTggK3gMLaseF6yoX7v0SQUwRhiosWdkPEjCp6mqsbxV9Jaw6J?=
 =?iso-8859-1?Q?TWsBGIQ2stFYV7Fh3V8HgXP3Qk5KJ2lg7mqogyXHIgGKfK8c0bfMHqVoSd?=
 =?iso-8859-1?Q?YGc+Wc1Yf8dWPNBRwLb1Q6ecFyTdX/BrNd75ms2N155puALl1YWKHi+/z0?=
 =?iso-8859-1?Q?wFb1dA2v9UMsloQPu5rvkoQ1NfVznnI5letxPAqtkNf39SOpKAR1RzurrL?=
 =?iso-8859-1?Q?4Tu1DBJ2VEmLZz0Pz4WptQTpHCgGF+XC1vlCxjcv5Cgg8LbYECY2sZdtaG?=
 =?iso-8859-1?Q?8WtMPZC26tUKUh6Hb/+c62eBtm+cDiPLoAAnIifR+yPvOYEksvlqF6CMFn?=
 =?iso-8859-1?Q?atA14vfNuURAnITKxxyzicuX51tQOnNPKCw1MpFuPCDBcCz66orb7/IzBS?=
 =?iso-8859-1?Q?HaUVG9r59X/kVurIm7Cpfm/YKt4qDvt3ENVYUy/jrPkwH04L9M6ggLnEr4?=
 =?iso-8859-1?Q?+fL3JoyY14luVReQkYb/m1LYPRB8sFww3Wa9/O1TqiBDfrGuKOyOZ607gV?=
 =?iso-8859-1?Q?naeBuNZObLrXveEKOi32bdTyeqpxMrR11nRkg0yjoUjzrE2EnExovSwCnG?=
 =?iso-8859-1?Q?plmDTsfgyQdtCBqe31YZ4+HLR1IMapWaz3qnORY+GgFd7pHfbbo76mo5Wh?=
 =?iso-8859-1?Q?PJgXYvk3vzE1UPAfBtvJ7ST+qVvh8yTY6IphUArggEXDT4Dbo6CIDIlMyz?=
 =?iso-8859-1?Q?p9I77jSMjHStYnnl3QZr65tm45/sEyKqQ4zepgqp2UU7Nbxru5YFePDEAy?=
 =?iso-8859-1?Q?V65qGQcxqu5chY2ZqJwTs1bRbvIWuqy/0o0pQJTEhpcbDHLp9ZVZIIt2tm?=
 =?iso-8859-1?Q?t1Vldk28ONmtfkMSMcUn74DLqjtF6uZ6TJ/fqgn2/I0Mu3BxNj4t5Orvsg?=
 =?iso-8859-1?Q?Mb0vtnHVIkTR83kP+UaKoVQu7E71YF1jtYnJALaZ6dC1EVXq+wFoeJ6kdc?=
 =?iso-8859-1?Q?eMA6S7zlmZKNaLvgD3lFnjzMdEfZnuZSt67UPaaejWitYs+rQ/VHI5ZwHG?=
 =?iso-8859-1?Q?UPM5cRlh1z0HF0n8Q+Mpug0aaXm3GRzvEqNfmVPXkZ2hUET20oz7GiD441?=
 =?iso-8859-1?Q?067msHBFjuqEDHt5TdGO1QCeLiWY2ZEnKqWy1B+WsB3+y08pROd6s4OKZP?=
 =?iso-8859-1?Q?qn5m2nzxECohi8Rv/K5btwqjF1Y3o6FfcWO8uioC+OEzU+nQfK3TzWZ6Qu?=
 =?iso-8859-1?Q?NMWw24k/EomguKXMMy7izttq+3P6c7D7Tcq5A4QaPEDnI+XYzx+n/OzQ5e?=
 =?iso-8859-1?Q?J5vhFbgUuhzti0qBX4xVOdc/6dv9Dt5hE3HzHcY2JdhHrOCEQSUCPl1LTs?=
 =?iso-8859-1?Q?gKi58lPaKi2wNMEMcpapKtRdezbc4IcBy0WJMAFN3DUyhVeymZ3udeCjs5?=
 =?iso-8859-1?Q?S75p27640iXcFc/urcCMZNmSagCOw8e9qkpil1nDKSU/Hawx4chRe8m8yR?=
 =?iso-8859-1?Q?WPvPMJ/fSvYXraeEIbVAklrOQgMKFcB1zL8DbQtJBDtzPP/WaU0Xt60ank?=
 =?iso-8859-1?Q?QvMzrvYy6xKrqHuX3d4=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9e6c10e-9b05-44eb-47da-08d9e5f59284
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 02:41:53.3152
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nwKe9c6t6szWme/2uGx+FX5jCzPkSM2qT0ssZO6h/S+dmDfnoAm1NteArHNgDJE6A8SfQPRXvqpdat+LamBR0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1325
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020010
X-Proofpoint-GUID: Sk8oIF88f0UftVOrqKl8tRmhUufHHK-s
X-Proofpoint-ORIG-GUID: Sk8oIF88f0UftVOrqKl8tRmhUufHHK-s
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

I'm not sure if the VMA list can change under us, but dump_vma_snapshot()
is very careful to take the mmap_lock in write mode.  We only need to
take it in read mode here as we do not care if the size of the stack
VMA changes underneath us.

If it can be changed underneath us, this is a potential use-after-free
for a multithreaded process which is dumping core.

Fixes: 2aa362c49c31 ("coredump: extend core dump note section to contain fi=
le names of mapped files")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
---
 fs/binfmt_elf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 605017eb9349..dc2318355762 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1651,6 +1651,7 @@ static int fill_files_note(struct memelfnote *note)
 	name_base =3D name_curpos =3D ((char *)data) + names_ofs;
 	remaining =3D size - names_ofs;
 	count =3D 0;
+	mmap_read_lock(mm);
 	for (vma =3D mm->mmap; vma !=3D NULL; vma =3D vma->vm_next) {
 		struct file *file;
 		const char *filename;
@@ -1661,6 +1662,7 @@ static int fill_files_note(struct memelfnote *note)
 		filename =3D file_path(file, name_curpos, remaining);
 		if (IS_ERR(filename)) {
 			if (PTR_ERR(filename) =3D=3D -ENAMETOOLONG) {
+				mmap_read_unlock(mm);
 				kvfree(data);
 				size =3D size * 5 / 4;
 				goto alloc;
@@ -1680,6 +1682,7 @@ static int fill_files_note(struct memelfnote *note)
 		*start_end_ofs++ =3D vma->vm_pgoff;
 		count++;
 	}
+	mmap_read_unlock(mm);
=20
 	/* Now we know exact count of files, can store it */
 	data[0] =3D count;
--=20
2.34.1