Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8347a069-c36c-cb30-a0be-5b38f3c59b32@axentia.se>
Date:   Wed, 2 Feb 2022 18:04:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v13 02/11] iio: afe: rescale: add INT_PLUS_{MICRO,NANO}
 support
Content-Language: sv-SE
To:     Liam Beguin <liambeguin@gmail.com>, jic23@kernel.org,
        andy.shevchenko@gmail.com, lars@metafoo.de
Cc:     linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org
References: <20220130161101.1067691-1-liambeguin@gmail.com>
 <20220130161101.1067691-3-liambeguin@gmail.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20220130161101.1067691-3-liambeguin@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE1YWDI1dFg5eDNxOElSSUhkYnJLNlFYYTZ4QTZLV01TWnRjR0NrV3FGV1ZG?=
 =?utf-8?B?SUxpd2RTM1luMnpOM2Vlb3MyMkJ5Vy9COG5YMEExaWd2ZFhwMDU2Yklrb2ZB?=
 =?utf-8?B?SUdIRkF4eDdocHlrdjRyQUNXTHplZVFSUjhpcXNyRmxKY3BDb3JWL0oyOEtE?=
 =?utf-8?B?eGhtYmR6WVo4MWNSMVprZlMwMHF2Tm9tM21qeVVZQXYycFZuL3BrOXVFSzM1?=
 =?utf-8?B?Mll6cG52cDRxTUI1UE9jUUVEYUEyYjRiZTM5cS81K2V4dTBZay9OSEg5MXMx?=
 =?utf-8?B?Q0owRkU5MXlHQ0k3bSt6NTUwUk94OHF3R3N2dC9kMEpCUnlPQzN0TlJlY3ly?=
 =?utf-8?B?S2RyTXVZZnNaWHN3UHFuS01EZ0JXdThnYWNmd2xwWXlBZG1MZERJR0RaMWRX?=
 =?utf-8?B?T0VqMEdvTEVzMnA5cXJuek9xaStQSk03R3M5bTVxdUNxeUtCQk1jMTNOOXpC?=
 =?utf-8?B?QUtNOEQ5QU9GcWZqTnNCTThFWmYzMlB6clk4UDZDcVdrNERxaVl4M1lhQVg3?=
 =?utf-8?B?eWNxVkxJMjBka0JoeUJVZGZMN3A2ZWpidUVLUXdWTXdJWXFxQWZwblRCbEFN?=
 =?utf-8?B?WTFnMmFvMWdzQnd6VkRSMkU5cVV6MFlxVUpFTG9GQ3pGRE9FbkFiUm8yRTBS?=
 =?utf-8?B?NXZhSjZadFVWbStKMHpLRHR6QXFxQjJaUUxvdk1PQWsyaUZCVk44QlRTc0xE?=
 =?utf-8?B?ZWhjbStHK3d3c1VvWmZYTUNVSHgrNWRxMDhFdzcyZmdXTVFVM0xkRjFkK08x?=
 =?utf-8?B?eUhoQkRIUElReEEvalU3TG9BSjdDVTZQYVh2RERKZ3NnZkVSUGtreW80dzY2?=
 =?utf-8?B?eUN5MVlDUHI5YlFaWW5lS0doVXB3SW5rWng1YldzSkUzNk11ZG50emowdk8x?=
 =?utf-8?B?OUpLVW1PeUFlSjVjZkVvODk5cTRJbU1SeEFLcmpRc1RkZnFKODJ6VFFxdk5V?=
 =?utf-8?B?bUw3a01TL0hGT095TkUwOStSclozMHlZK2JHcExBSWZ5VXNmNkFYV3BHYnMy?=
 =?utf-8?B?T1Q1SS95MzluWVA4bVRyQWp0SncxTE1vaHU4WGt0OWNXcWlZcEVoNGhsRG03?=
 =?utf-8?B?aVg2d2RKckVEWTV2RGluU0lKOHBZWnNhV2ZvYTJLTDlFMmFiQ2RZN2tvaFMv?=
 =?utf-8?B?cTgzQWxHTUx4U0haTjlSWUVaZHNQWGRmUk40djNBZnliUTlWMU8zeFplcTVy?=
 =?utf-8?B?QXdIbXFoSjhBV1Z3UHJ0VkxVdVJaOW5ScDZjNUNZQVBDcXRsODg0cU96UkIy?=
 =?utf-8?B?TlJqRnhVd09jSFZRcWVMUE9lek1ON2dPSTBwOFVXOUZSRURYZkdpRDdyZnIr?=
 =?utf-8?B?TjF4NXYvZE55U1U2aTAwY0t3NjhNZjMrSXM4bGxJMGtOM1J6SFZxUmpjNGND?=
 =?utf-8?B?bWtYeGIrQUxpWHNZcDRzWUN0Z3RpbnRPSjRSc2xHdUVJeXZyOEJWcUVzY0di?=
 =?utf-8?B?K0tIUVJkellUNjZKNzFjK2EzdTdva0toYWpyQ25KZ0dIL3dTVGNkUlgwbEpF?=
 =?utf-8?B?YXFKVnliRFozZTVlOUxGMTBUbWJaL2t4djdFUy81MXREZ052U3Z0UW9PQk9E?=
 =?utf-8?B?aytJemZjR0hQcTBDYUttRU5nb1cvbkZBd1U4ZVVuUVU1cFNqN1Ewc2E4bG4w?=
 =?utf-8?B?bFRsRUZFT3dEdTdYVmsyVzV1YUhQTUkwYUVzK1RjUlR0U3k3akdoYzhoV1Jl?=
 =?utf-8?B?MVdsWHBIeGdydzVERUtXWU5iaEg0QVNGdXNIZGI2VzZyOE9jMkhPZjZxeE5N?=
 =?utf-8?B?K0lwKzRQeHBmWXRlVG9DTnZLRWs1YThqaiswUWFkSE9pbXJjemFBZ0Vkc3Z3?=
 =?utf-8?B?aUcvRFhraVd0WFQ0MnZ2YmtCZGwxUzVPYU5GQ3dNSmNkR1F4RXpFejBVOTV5?=
 =?utf-8?B?WGtLY2ZXMVlSWTJvalExYWlEbFVPSVNaK1pGYVVoR1krV1dkZTZFNS9ZdXdm?=
 =?utf-8?B?b2NtVzcva3ArbWNTdGJ6cHNoblBkMDROVk9zMCttV1lvVTk2djgvSW5TQmxq?=
 =?utf-8?B?V2NFazZIZngzcHBFcVMvR1FtZHgzV3owTGM5NVFGOHJsbkZJVnZOZlZKR2Rz?=
 =?utf-8?B?UERhMCtOZG1ZZjFzT09SbzNBbCtwdHloNGVFSGhEMHAzQ1NhYUZOSUFZODg0?=
 =?utf-8?Q?xKO0=3D?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: fbd3e924-3016-49fa-7485-08d9e66e12cf
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:04:28.7886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gTCmAweSeZe5o4RRUfFFOSE9iWaprJddrs6tL+Dwj94Eut6LemoJoYtXEQChrD53
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR02MB4902
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

On 2022-01-30 17:10, Liam Beguin wrote:
> Some ADCs use IIO_VAL_INT_PLUS_{NANO,MICRO} scale types.
> Add support for these to allow using the iio-rescaler with them.
> 
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> Reviewed-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/iio/afe/iio-rescale.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
> index 65832dd09249..f833eb38f8bb 100644
> --- a/drivers/iio/afe/iio-rescale.c
> +++ b/drivers/iio/afe/iio-rescale.c
> @@ -14,6 +14,7 @@
>  #include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
> +#include <linux/units.h>

This include should be moved to the first patch that uses stuff from
it.

Cheers,
Peter

*snip*