Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     Samuel Mendoza-Jonas <samjonas@amazon.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net] ixgbevf: Require large buffers for build_skb on
 82599VF
Thread-Topic: [PATCH net] ixgbevf: Require large buffers for build_skb on
 82599VF
Thread-Index: AQHYCAzJTdC6rocnTUaIwyNO+ZIFB6yAx5hA
Date:   Wed, 2 Feb 2022 19:34:33 +0000
Message-ID: <DM8PR11MB56216C0BF94DFA7D96DF1C98AB279@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <20220112233231.317259-1-samjonas@amazon.com>
In-Reply-To: <20220112233231.317259-1-samjonas@amazon.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N2jXqJPGfPd992gjH1bEmYyUt+d/okpbysP+PUCYiP6izws9ppVpqFjIVhCL?=
 =?us-ascii?Q?EG811r5BIPxkW9sVE+VkDJcUTRsP3Inw5XkebOw9U7Kcic6MyQA8o/BVYXMX?=
 =?us-ascii?Q?DEW3S8IoLjaj57F9bAMcn+Ca+74DZQ5xjon8auiMvVioC71gEO60Bv7gOPoi?=
 =?us-ascii?Q?O4GgcM2rPYRJM/bgHLrsnOBl1RvJflNo8vThDoYHMPQzfWyllO0MSKYybB0f?=
 =?us-ascii?Q?l7uwCt4lD2P52ooMNLbvHERmjuNpu0Ww8mRVe0t9T/1jibCRb16p+TSv1eX3?=
 =?us-ascii?Q?sL/qTm1+Sj9hZ18PVoh7no3DyIJlghUCVHuiygNEig9tJQMoDlh3HzPmiodk?=
 =?us-ascii?Q?9mkCHZGSMXb2gIn5+QFh6U3LNfpXpx0u75zhByKqw+LoRaJHzTKuSWALxJeh?=
 =?us-ascii?Q?kMLIUT/7rwXBTnZAGfDhxgFMcWllTZmGfdg40Nw7rQhI+Fq0BHyfd3FDtyN4?=
 =?us-ascii?Q?1SCdF/PhjMQa7TBNUvJJBMywpJbHGDv0UYjcBCsLHg5IUXbhd1nnHPD2YaOw?=
 =?us-ascii?Q?i8l6TieBwAlAdRzKsKOwWG1bYuEKwoEMBHdCYNQH2Kcfh4dw0I9CAmlHR78p?=
 =?us-ascii?Q?/du/PngzleddPcB6k4b7xyxJ3z+pB+ndy6Hvi9EOwllJu94omZAH11L7wzYN?=
 =?us-ascii?Q?iQt4xQmDzhSUyVVmMyfSNBCFb47HCSjq+At0WYMPNlAsYtZmQ9T6sr6QI8YM?=
 =?us-ascii?Q?I4Bqcsva9sbaPmqIYEQ6w5jS5xWeO7YLPwUpD6DqZ1v9tN2vLoVxnkHJYnuY?=
 =?us-ascii?Q?F1ScEsa+/DPAzGXS1nYWDkzfvFtNfZhkzbNp0ful7GoWReAI4JXoOP8Pyohi?=
 =?us-ascii?Q?0+Y+ITno4XZRHh7AqNrtG0wWu5EYPto0V221uOgIz4smSWFsyFGDtVj1vnIg?=
 =?us-ascii?Q?QkCqYAUBLjt1G/sKWjtpR009xiebuaNQ/CkBJGGulyRXTG7aBlkpH+OFPdFz?=
 =?us-ascii?Q?21dYS/FrgSm1o/DtI9M1EqkvxUAgmsMd2W0ZZ2yNj+tb45PbUml6cioggmcE?=
 =?us-ascii?Q?mCGBAXHTU+AjUDMorZS/TRuZ7kEutdX/IhBzanNSscsc5NcM1prz3BUn4l5C?=
 =?us-ascii?Q?GgLheZ0E/HYBImDO5bsf9LME+H3Rn9cU4nLBpd4CH6e/k+dPx4f9SCJRD5lp?=
 =?us-ascii?Q?l7lPtsCLGNgLlv8gG7FtRnnShEcl8ZsbkQ4dtzvDpXmHSrPxB4wopkmqylr4?=
 =?us-ascii?Q?iZ/1VbhqsMM6LiBSog9U9LmMDqOarlS/0eavAx/KyHuygX0Frc90ijlE8d/j?=
 =?us-ascii?Q?JtNrR/dJhbt2kk3k8ZX6BAv0epgb84woudt/z3IAPH5J/QOVMhZWwLHMiYdg?=
 =?us-ascii?Q?jFSFj0X8t9loQf38JbICiMqmZCvZ1Y/QNkk7STS4Et2O1B0jTUau/kkFvxIl?=
 =?us-ascii?Q?lzmZxxi70xU1grrUyiIJLpre0Q0hOTNHxpBnmJngQ0V2UhoSkSa7UKCUQ4lV?=
 =?us-ascii?Q?D0Dx73xGDJfWKu1P0KT+7gQt/A0ey/eEbPLv6FxW2oZLD1pslTdGGRzoaySH?=
 =?us-ascii?Q?D0X6rFKePVDexQc6L96brjYpJteXsd3eoN4968MWg/3tMArxwVIaKyjubztz?=
 =?us-ascii?Q?ZyeaPBvr2xDKRjReD0GN9l77azEpOai9serXEU072GmBZ0ZWp+EJqZx1rd6z?=
 =?us-ascii?Q?XYUR6Gmf1gFwZE1ZETgyI2gBCkadwXSUH9AqTL1vIG/t3jz9koXyewsWp2Qm?=
 =?us-ascii?Q?K8OR0A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6aa1d980-51e0-4e8e-70cf-08d9e6830a47
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 19:34:33.5944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GowbB0hzmdNscO6oq9pPjOodrTTQT7way0wUcIEEgHEV5EkxJb/l5ANNmAtE+WYMPVTRRO5sD7LFrJOUn7jt2M+hbHmL0vBlPa0gNcKSDzk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4009
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Samuel Mendoza-Jonas <samjonas@amazon.com>
> Sent: Thursday, January 13, 2022 12:33 AM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Cc: Samuel Mendoza-Jonas <samjonas@amazon.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; David S . Miller <davem@davemloft.net>;
> Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Jakub Kicinski
> <kuba@kernel.org>; linux-kernel@vger.kernel.org
> Subject: [PATCH net] ixgbevf: Require large buffers for build_skb on 8259=
9VF
>=20
> From 4.17 onwards the ixgbevf driver uses build_skb() to build an skb aro=
und
> new data in the page buffer shared with the ixgbe PF.
> This uses either a 2K or 3K buffer, and offsets the DMA mapping by
> NET_SKB_PAD + NET_IP_ALIGN. When using a smaller buffer RXDCTL is set
> to ensure the PF does not write a full 2K bytes into the buffer, which is
> actually 2K minus the offset.
>=20
> However on the 82599 virtual function, the RXDCTL mechanism is not
> available. The driver attempts to work around this by using the SET_LPE
> mailbox method to lower the maximm frame size, but the ixgbe PF driver
> ignores this in order to keep the PF and all VFs in sync[0].
>=20
> This means the PF will write up to the full 2K set in SRRCTL, causing it =
to write
> NET_SKB_PAD + NET_IP_ALIGN bytes past the end of the buffer.
> With 4K pages split into two buffers, this means it either writes
> NET_SKB_PAD + NET_IP_ALIGN bytes past the first buffer (and into the
> second), or NET_SKB_PAD + NET_IP_ALIGN bytes past the end of the DMA
> mapping.
>=20
> Avoid this by only enabling build_skb when using "large" buffers (3K).
> These are placed in each half of an order-1 page, preventing the PF from
> writing past the end of the mapping.
>=20
> [0]: Technically it only ever raises the max frame size, see
> ixgbe_set_vf_lpe() in ixgbe_sriov.c
>=20
> Signed-off-by: Samuel Mendoza-Jonas <samjonas@amazon.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index 0015fcf1df2b..0f293acd17e8 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>