Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 15:31:59 -0300
From:   Marcelo Tosatti <mtosatti@redhat.com>
To:     =?utf-8?B?5ZCRIOaZr+S6mA==?= <oscar0225@livemail.tw>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Nitesh Lal <nilal@redhat.com>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Christoph Lameter <cl@linux.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Alex Belits <abelits@belits.com>, Peter Xu <peterx@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH v10 1/10] add basic task isolation prctl interface
Message-ID: <Yfl8nwIOM0ZSiXZY@fuller.cnet>
References: <20220127173037.318440631@fedora.localdomain>
 <20220127173206.358254456@fedora.localdomain>
 <F94506EB-DA71-43F1-9126-8FBB134F6104@livemail.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <F94506EB-DA71-43F1-9126-8FBB134F6104@livemail.tw>
Precedence: bulk

On Sat, Jan 29, 2022 at 04:22:07AM +0000, 向 景亘 wrote:
> Hi,
> 
> On Jan 28, 2022, at 1:30 AM, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> > 
> > Index: linux-2.6/include/linux/task_isolation.h
> > ===================================================================
> > --- /dev/null
> > +++ linux-2.6/include/linux/task_isolation.h
> > @@ -0,0 +1,91 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +
> > +#ifndef __LINUX_TASK_ISOL_H
> > +#define __LINUX_TASK_ISOL_H
> > +
> > +#ifdef CONFIG_TASK_ISOLATION
> > +
> > +struct task_isol_info {
> > +	/* Which features have been configured */
> > +	u64 conf_mask;
> > +	/* Which features are active */
> > +	u64 active_mask;
> > +	/* Quiesce mask */
> > +	u64 quiesce_mask;
> > +
> > +	/* Oneshot mask */
> > +	u64 oneshot_mask;
> > +
> > +	u8 inherit_mask;
> > +};
> > +
> > +extern void __task_isol_free(struct task_struct *tsk);
> > +
> > +static inline void task_isol_free(struct task_struct *tsk)
> > +{
> > +	if (tsk->task_isol_info)
> > +		__task_isol_free(tsk);
> > +}
> > +
> > +int prctl_task_isol_feat_get(unsigned long arg2, unsigned long arg3,
> > +			     unsigned long arg4, unsigned long arg5);
> > +int prctl_task_isol_cfg_get(unsigned long arg2, unsigned long arg3,
> > +			    unsigned long arg4, unsigned long arg5);
> > +int prctl_task_isol_cfg_set(unsigned long arg2, unsigned long arg3,
> > +			    unsigned long arg4, unsigned long arg5);
> > +int prctl_task_isol_activate_get(unsigned long arg2, unsigned long arg3,
> > +				 unsigned long arg4, unsigned long arg5);
> > +int prctl_task_isol_activate_set(unsigned long arg2, unsigned long arg3,
> > +				 unsigned long arg4, unsigned long arg5);
> > +
> > +int __copy_task_isol(struct task_struct *tsk);
> > +
> > +#else
> > +
> > +static inline void task_isol_free(struct task_struct *tsk)
> > +{
> > +}
> > +
> > +static inline int prctl_task_isol_feat_get(unsigned long arg2,
> > +					   unsigned long arg3,
> > +					   unsigned long arg4,
> > +					   unsigned long arg5)
> > +{
> > +	return -EOPNOTSUPP;
> > +}
> > +
> > +static inline int prctl_task_isoln_cfg_get(unsigned long arg2,
> 
> I think this line should be "prctl_task_isol_cfg_get". 

Yes, fixed, thanks!