Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992439AbXBISPc (ORCPT ); Fri, 9 Feb 2007 13:15:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992730AbXBISPb (ORCPT ); Fri, 9 Feb 2007 13:15:31 -0500 Received: from mail3.sea5.speakeasy.net ([69.17.117.5]:57536 "EHLO mail3.sea5.speakeasy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992439AbXBISPb (ORCPT ); Fri, 9 Feb 2007 13:15:31 -0500 Date: Fri, 9 Feb 2007 13:15:28 -0500 (EST) From: James Morris X-X-Sender: jmorris@d.namei To: Rusty Russell cc: lkml - Kernel Mailing List , Andi Kleen , Andrew Morton , virtualization Subject: Re: [PATCH 4 of 7] lguest: Config and headers In-Reply-To: <1171033741.2718.172.camel@localhost.localdomain> Message-ID: References: <1171033146.2718.157.camel@localhost.localdomain> <1171033383.2718.163.camel@localhost.localdomain> <1171033436.2718.165.camel@localhost.localdomain> <1171033484.2718.167.camel@localhost.localdomain> <1171033741.2718.172.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 21 On Sat, 10 Feb 2007, Rusty Russell wrote: > +/* 64k ought to be enough for anybody! */ > +#define HYPERVISOR_MAP_ORDER 16 > +#define HYPERVISOR_PAGES ((1 << HYPERVISOR_MAP_ORDER)/PAGE_SIZE) I think it'd be better to go back to defining HYPERVISOR_SIZE then derive the map order from that via get_order(), as it should be 4 instead of 16; and this code is now both implying PAGE_SIZE while also using it for calculations. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/