Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2384519pxb; Thu, 3 Feb 2022 05:36:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzh3+C8JEc4CDSYFKoaydVfw+jNrlnqGgdNC3uL8tI/kr+7WhFjn5JS9dVzJMRW0UT8/NvB X-Received: by 2002:a05:6402:1e92:: with SMTP id f18mr35381744edf.347.1643895398699; Thu, 03 Feb 2022 05:36:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643895398; cv=none; d=google.com; s=arc-20160816; b=z7Yx5G1UaNR2CmxlL7xc/V23lF3Xu1tRhayRrhu4x3/IBk7RN8iLbxNOZxpuBilfOP k32fSOwheGEnG0td5eZkth786G1XAS3g48bMjplJIjVnBpyxPZaV98ZzDa195k6sQ531 E4Lfbm3CcUEmC2My8WDagO5bDJ600fs+YsQcEieyr0PR4xNtuZzFJ5maC9NMw5MiVya6 YI5NeutXqLlSBtW+ebdaOO/wPEItZl2k/BcUzi7MdYjDdpQQ9jb2T7wIo7sjaEUNaWvY nblQQp+0KHxxxUr/aZ6V4+IpSqONhMEOoBWdeVKjkd10PPU9+i/wfk9cvEqQNVAVQoNz D3Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:dkim-signature; bh=m3Jynn4I13NmuQ36YBQRadKKSRAnnonOGHGuw8J0xZs=; b=zjWZKFJ5czFxh2O53wZ6nuuPqU6I2kvXj+mWbjE8g06pWHQDvyBykNnm4lDzoUmKow b+pEBeHof/7LU/bA2boymA39gJMCN3TU/wAfLT0B9pNZN+spKsW5oNIXwiWmuDO/DNe0 zwtQ7EEG3YOOZAFS1gVJxm+7Vvt9ZL35fCHw3rTeZHVxzCz2ungR11fAwxdIA6Mf70EO cvM1ijwhXEzOytWpipDYhWYYu3ybBVCB/X4XtteNZ2Dh+wMSC/u8nxvbxA1yBUMxdIMv PdMkqxkvfSvkGjPx5wd9HNZml/OP7bMuEFjIZxG0tmleWbG6RnzxYsset0swHp0TAQq/ blBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=LYJZ6XT+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne18si11816827ejc.386.2022.02.03.05.36.13; Thu, 03 Feb 2022 05:36:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=LYJZ6XT+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349062AbiBCKaD (ORCPT + 99 others); Thu, 3 Feb 2022 05:30:03 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:34640 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231725AbiBCKaB (ORCPT ); Thu, 3 Feb 2022 05:30:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1643884201; x=1675420201; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1TXPyy/kpZBNxO1tbtGx3iBoVnJzfJ227qS4/tBvr18=; b=LYJZ6XT+Hd0/9mScnCjCfZWzcX34xsA+MSAoIuY4EvOvv5CRs4tkBQLP FL96IaQCZLClIyzDu0AJffAkQAEKYzkHqOOXP/TUapxTC6+zV9yCuTCxY s4H70GI58T3ny3RYgoBa08eRILQxTSQ1vo1vEs2iANe0tTWPwo+tBICuv yKKwaPKU8eamOoyXHsHNDlGAjkD/yerc4s1QnAHZZeVlCFEZDl2Y16TNo 4DUKZ6i/H/Imlpj30bp+Lqf6XlLqosDYFHabP/HszoGRr5HSCoS4frNVe nlF5/kMiCIXAXQsj9KniYAXovTTtL/HF5iK4CIkb78ywm28gtxvKMUfm/ g==; IronPort-SDR: KptEahQXKMdnpFose7f1Df66KQBgN5k2e7W95KLW+AC4ubFgizza4MgTI+t5MrZ24ksmbfM/w1 F68uLGKNQG6XHcStLBz+aPNh7uL5GEAtdkYyqVjYOmE6ca+EP42zwUSWue4JN9rPA7DHGLuugo LJWgr4dp/Z4NBtlHxGRml6/x9DVELeVMXtxm5h0XiHG2fnTs+oQVQUTAej+OccO7oxIxNY0QWj hLS8s1OkI606jg6a4WaC/Rkg81utatMXOWKT7J/cKPt1f1yyrd9D7I3RdG4n0Ydag2ut8pLOzP xwO4ms0GBCABQaEFHUvGAKYw X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="84547385" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Feb 2022 03:30:00 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 3 Feb 2022 03:30:01 -0700 Received: from den-dk-m31857.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Thu, 3 Feb 2022 03:29:59 -0700 From: Steen Hegelund To: "David S. Miller" , Jakub Kicinski , , , , CC: Steen Hegelund Subject: [PATCH net] net: sparx5: Fix get_stat64 crash in tcpdump Date: Thu, 3 Feb 2022 11:29:00 +0100 Message-ID: <20220203102900.528987-1-steen.hegelund@microchip.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This problem was found with Sparx5 when the tcpdump tool requests the do_get_stats64 (sparx5_get_stats64) statistic. The portstats pointer was incorrectly incremented when fetching priority based statistics. Fixes: af4b11022e2d (net: sparx5: add ethtool configuration and statistics support) Signed-off-by: Steen Hegelund --- drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c index 59783fc46a7b..10b866e9f726 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c @@ -1103,7 +1103,7 @@ void sparx5_get_stats64(struct net_device *ndev, stats->tx_carrier_errors = portstats[spx5_stats_tx_csense_cnt]; stats->tx_window_errors = portstats[spx5_stats_tx_late_coll_cnt]; stats->rx_dropped = portstats[spx5_stats_ana_ac_port_stat_lsb_cnt]; - for (idx = 0; idx < 2 * SPX5_PRIOS; ++idx, ++stats) + for (idx = 0; idx < 2 * SPX5_PRIOS; ++idx) stats->rx_dropped += portstats[spx5_stats_green_p0_rx_port_drop + idx]; stats->tx_dropped = portstats[spx5_stats_tx_local_drop]; -- 2.35.1