Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2440289pxb; Thu, 3 Feb 2022 06:47:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqefVL180B66FLLRmbb8YX+evVmyZuAFycY2WRPaCR+xX5BpyqNqfnO7stQoNa2CmO+QQI X-Received: by 2002:a17:902:bd03:: with SMTP id p3mr18518048pls.50.1643899639993; Thu, 03 Feb 2022 06:47:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643899639; cv=none; d=google.com; s=arc-20160816; b=m1EzIcmKDiV5/Tf388LumrWIZelvPgHWzyyYinaLcDkFKuFlNg0dLuUP6hseUvMdRg c0MUHOhaL+/R2Wpo83e7/xG0PiVuquTFTgTToN9DKVjfUtbNprFE8jeMJulrXL0wLVCc GiMWezEMhUHQfdtMH2RsH+1EedsAt68tXc6uJK+QO2J/wivGaFkGZZDVo9byBSVhroJz cAcrGRuD4Hw15EzcubkkE1dj9Vqe6LFenQR/LFjb3Hwi9vrvpK1+NK6pXfh36koi+0lM U4GspmfrJpIWi3kzYfXUjbElblsiPc4aMkDg/FDjkqjoUuflh3mslV8IJB8/TuRY3VPG 1kag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QdEwZ5pOBE6iVHIrXRlnkjzoCdm1EkBZKehYXmGCOKo=; b=OKOs1h52c5DV6XKgd2H4rN2J2a4sHQuiP8MZ9loXz2YqJhIjrFt3bZ7mAkhE4St8Au Fvw+lESRKc8+b+dhybH/vMVzsR6A75xLqEKNnY7auLdAWg/q+GCndQDLR8/IcC6DuhgT UKyUbd3NMymRX2ZoeDdCZGEfdTE84w16DNIr0MiEw3G7KPtJwADQX5N7A4PxYSHlaagC 4cKldehBnopR0NhTI17/yQTOt+5aWD/M8J2T3byoqP9nz/Qjo7oXOkGDOzJbd3PzeB/0 2/D5gdSwYPOUvIXFnS2nEZxlJxIy/hSgwp2xCSkvnV4alroferyekaUtryqS1tLVr+Xw Nkpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=IHpmp9Dv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 82si20821483pgf.547.2022.02.03.06.47.07; Thu, 03 Feb 2022 06:47:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=IHpmp9Dv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347367AbiBBWgW (ORCPT + 99 others); Wed, 2 Feb 2022 17:36:22 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:35574 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232825AbiBBWgV (ORCPT ); Wed, 2 Feb 2022 17:36:21 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C685D88; Wed, 2 Feb 2022 23:36:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643841380; bh=ZQLGa2eXC4sJhodB0WXU0SgIdYCeRWqlb+Ft/SAKtx8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IHpmp9Dv9pBUA8ju1C7drVB4fhDahT94AVPO+gxWujMdDvCj8AUKq1LJTg2RTlFnq 8OFXSBNpOt9bYxvTrNj7idkgdzp0dbCizH9+Bd1QUqzn2fJ3ZBPGJ7/7QgXzWt+znc /rCSexYSp5INrF1PtgitYVDrOfCW30myfAIDnlII= Date: Thu, 3 Feb 2022 00:35:57 +0200 From: Laurent Pinchart To: Jean-Michel Hautbois Cc: Stefan Wahren , dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, kernel-list@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, lukasz@jany.st, mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org, tomi.valkeinen@ideasonboard.com Subject: Re: [RFC PATCH v3 03/11] media: dt-bindings: media: Add bindings for bcm2835-unicam Message-ID: References: <20220202175639.149681-1-jeanmichel.hautbois@ideasonboard.com> <20220202175639.149681-4-jeanmichel.hautbois@ideasonboard.com> <9bce4322-881e-06a7-d6a4-431b1417ced5@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9bce4322-881e-06a7-d6a4-431b1417ced5@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean-Michel, On Wed, Feb 02, 2022 at 11:09:20PM +0100, Jean-Michel Hautbois wrote: > On 02/02/2022 19:33, Stefan Wahren wrote: > > Hi Jean-Michel, > > > > please drop the first "media:" before dt-bindings. > > > > Am 02.02.22 um 18:56 schrieb Jean-Michel Hautbois: > >> Introduce the dt-bindings documentation for bcm2835 CCP2/CSI2 Unicam > >> camera interface. Also add a MAINTAINERS entry for it. > >> > >> Signed-off-by: Dave Stevenson > >> Signed-off-by: Naushir Patuck > >> Signed-off-by: Jean-Michel Hautbois > >> --- > >> Dave: I assumed you were the maintainer for this file, as I based it on the > >> bcm2835-unicam.txt file. Are you happy to be added directly as the > >> maintainer, or should this be specified as "Raspberry Pi Kernel > >> Maintenance " > >> --- > >> .../bindings/media/brcm,bcm2835-unicam.yaml | 107 ++++++++++++++++++ > >> MAINTAINERS | 7 ++ > >> 2 files changed, 114 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml b/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >> new file mode 100644 > >> index 000000000000..5bf41a8834fa > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >> @@ -0,0 +1,107 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/media/brcm,bcm2835-unicam.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Broadcom BCM283x Camera Interface (Unicam) > >> + > >> +maintainers: > >> + - Dave Stevenson > >> + > >> +description: |- > >> + The Unicam block on BCM283x SoCs is the receiver for either > >> + CSI-2 or CCP2 data from image sensors or similar devices. > >> + > >> + The main platform using this SoC is the Raspberry Pi family of boards. > >> + On the Pi the VideoCore firmware can also control this hardware block, > >> + and driving it from two different processors will cause issues. > >> + To avoid this, the firmware checks the device tree configuration > >> + during boot. If it finds device tree nodes starting by csi then > >> + it will stop the firmware accessing the block, and it can then > >> + safely be used via the device tree binding. > >> + > >> +properties: > >> + compatible: > >> + const: brcm,bcm2835-unicam > >> + > >> + reg: > >> + maxItems: 2 > > > > I would be nice to have reg-names here similar to the clocks. > > Sure, I just don't know what the names are ;-). Please discuss this with the Rasperry Pi developers to figure out then. > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + clocks: > >> + items: > >> + - description: Clock for the camera. This also seems weird, as far as I know the SoC doesn't output a clock for the camera sensor (and it should be specified in the camera sensor DT node if it did anyway). > >> + - description: Clock for the vpu. > >> + > >> + clock-names: > >> + items: > >> + - const: lp > >> + - const: vpu > >> + > >> + power-domains: > >> + items: > >> + - description: Unicam power domain > >> + > >> + num-data-lanes: This is a vendor-specific property and thus requires a vendor prefix. > >> + items: > >> + - enum: [ 2, 4 ] > >> + > >> + port: > >> + additionalProperties: false > >> + $ref: /schemas/graph.yaml#/$defs/port-base > >> + > >> + properties: > >> + endpoint: > >> + $ref: /schemas/media/video-interfaces.yaml# > >> + unevaluatedProperties: false > >> + > >> + properties: > >> + data-lanes: true > >> + link-frequencies: true > >> + > >> + required: > >> + - data-lanes > >> + - link-frequencies > >> + > >> + required: > >> + - endpoint > >> + > >> +required: > >> + - compatible > >> + - reg > >> + - interrupts > >> + - clocks > >> + - clock-names > >> + - power-domains > >> + - num-data-lanes > >> + - port > >> + > >> +additionalProperties: False > >> + > >> +examples: > >> + - | > >> + #include > >> + #include > >> + #include > >> + csi1: csi@7e801000 { > >> + compatible = "brcm,bcm2835-unicam"; > >> + reg = <0x7e801000 0x800>, > >> + <0x7e802004 0x4>; > >> + interrupts = ; > >> + clocks = <&clocks BCM2835_CLOCK_CAM1>, > >> + <&firmware_clocks 4>; > >> + clock-names = "lp", "vpu"; > >> + power-domains = <&power RPI_POWER_DOMAIN_UNICAM1>; > >> + num-data-lanes = <2>; > >> + port { > >> + csi1_ep: endpoint { > >> + remote-endpoint = <&imx219_0>; > >> + data-lanes = <1 2>; > >> + link-frequencies = /bits/ 64 <456000000>; > >> + }; > >> + }; > >> + }; > >> +... > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index a0770a861ca4..29344ea86847 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -3670,6 +3670,13 @@ N: bcm113* > >> N: bcm216* > >> N: kona > >> > >> +BROADCOM BCM2835 CAMERA DRIVER > >> +M: Raspberry Pi Kernel Maintenance > >> +L: linux-media@vger.kernel.org > >> +S: Maintained > >> +F: Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >> +F: arch/arm/boot/dts/bcm283x* > >> + > > > > I suggest to make the MAINTAINERS changes a single separate patch > > instead of small incremental changes. > > I can make it a separate patch, indeed. > > >> BROADCOM BCM47XX MIPS ARCHITECTURE > >> M: Hauke Mehrtens > >> M: Rafał Miłecki -- Regards, Laurent Pinchart