Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Feb 2022 12:44:32 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Juan Vazquez <juvazq@linux.microsoft.com>
Cc:     Miaoqian Lin <linmq006@gmail.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: hv: vmbus: Fix memory leak in
 vmbus_add_channel_kobj
Message-ID: <20220203124432.ckvfzgyyg6fqe2pm@liuwe-devbox-debian-v2>
References: <20220126055247.8125-1-linmq006@gmail.com>
 <20220128215604.xuqdpnnn4yjqfaoy@surface>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220128215604.xuqdpnnn4yjqfaoy@surface>
Precedence: bulk

On Fri, Jan 28, 2022 at 01:56:04PM -0800, Juan Vazquez wrote:
> On Wed, Jan 26, 2022 at 05:52:46AM +0000, Miaoqian Lin wrote:
> > kobject_init_and_add() takes reference even when it fails.
> > According to the doc of kobject_init_and_add()：
> > 
> >    If this function returns an error, kobject_put() must be called to
> >    properly clean up the memory associated with the object.
> > 
> > Fix memory leak by calling kobject_put().
> > 
> > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> >  drivers/hv/vmbus_drv.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index 17bf55fe3169..9e055697783b 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -2028,8 +2028,10 @@ int vmbus_add_channel_kobj(struct hv_device *dev, struct vmbus_channel *channel)
> >  	kobj->kset = dev->channels_kset;
> >  	ret = kobject_init_and_add(kobj, &vmbus_chan_ktype, NULL,
> >  				   "%u", relid);
> > -	if (ret)
> > +	if (ret) {
> > +		kobject_put(kobj);
> >  		return ret;
> > +	}
> >  
> >  	ret = sysfs_create_group(kobj, &vmbus_chan_group);
> If sysfs_create_group() fails same cleanup I think is required.
> 
> Later kobject_uevent() may fail according to doc, but there is no error
> handling, maybe a good moment to consider adding it and do same cleanup.

Miaoqian, are you going to post a new version to address Juan's comment
here?

Thanks,
Wei.

> >  
> > -- 
> > 2.17.1