Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <962dc65c-6e52-bf02-5ba5-7e8731442390@oracle.com>
Date:   Thu, 3 Feb 2022 16:46:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Yazen Ghannam <yazen.ghannam@amd.com>, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, mchehab@kernel.org,
        tony.luck@intel.com, james.morse@arm.com, rric@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com
References: <20220202144307.2678405-1-yazen.ghannam@amd.com>
 <20220202144307.2678405-2-yazen.ghannam@amd.com>
 <a42a7696-0150-6d63-953e-adec19e25d02@oracle.com> <YfviHFrzzdapbwDt@zn.tnic>
From:   William Roche <william.roche@oracle.com>
In-Reply-To: <YfviHFrzzdapbwDt@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnV3L0t0Z1d3ZUpJTDJLS054bXpUYml2d3Q3MVR1MjRPU1FYQXhmdTYweFJn?=
 =?utf-8?B?VlRGNFkvdzkxV2ExWldhaUZVYjNVTmx5OTVMbCtnYjJScGoyUEFmU3dFWUNh?=
 =?utf-8?B?SGp2eXR5cSt0Y3RpVGVuUUhFOS8xNHMzNkgrdlpGWHFZdDR1RlZ2TWpuTWlv?=
 =?utf-8?B?WmRqSzBUMi9QQ2xQaUZUaU5ZYzAwdU9udHUyYysxYzVDSWRrM3JqaHJSSVZZ?=
 =?utf-8?B?NElYQlMxODkwOUJEVlY0VHppb3dIeXRtRmhta3dBSzlTUGRSRlBZQVZvM3dC?=
 =?utf-8?B?dzFUWGNwVHA2eXNBZkZUN3ZaQ0lYUzhyNFI0UEtCbXFGVVJFc2hxa2M1Tlh5?=
 =?utf-8?B?djhMajdaeHY5Wm5JL3hvSzI0aXdlTUJwdk9aczlnTGJmd2RrUGlHa0lXQ0Rq?=
 =?utf-8?B?TGt5bDlOMzIyYld6T2FSR25GdlZTa0lnQWY5OWJNd0liNEJiVWVxNW1haHdn?=
 =?utf-8?B?NTAzY092TlJDM3YrbTE3c3VJM3huUlFOQ1ZRWmh2RUluMmxESEtOYndObWNV?=
 =?utf-8?B?bkpkVWNzWTVVWElxSGNrUkMyd3ZMZ1cvaitBUk1TZkhnbk85UUJwY2tJTlNa?=
 =?utf-8?B?SytsemZpZUpRNkZnaERDU3YwMjFJaWdzVmZDdllBZUE3TUpTSHVnTDRPUy9u?=
 =?utf-8?B?R1BBQSs0K0NOSE5yalVmSVpxVDFHd291RG9ieHRXbHpVaWx5aXFFVXdnbnV0?=
 =?utf-8?B?MVlKVk5iYk9XVGN1R2dEa29FTzJXYzdOMHEzWEZSUTk2ZFJWQ3FlQ1dHWWlD?=
 =?utf-8?B?dXRqYUdROVhsMUxzaVYvUEtrc0M0RTZFd3RkYW55ZS9VNE1GVzRwZXJRbVlF?=
 =?utf-8?B?WU9PYWFmcXFIR1ZRNnFhYVprWlQyZU4zSE9DY2RYN0xuWk1rV2NDakRFMzND?=
 =?utf-8?B?dkQwWFpycHB6VFhXVTUzSG9NMHM3KzFiV2pPSnp0NGFidXRwRHFRc0YvQ0ZV?=
 =?utf-8?B?MU1WcVYvbFk3aStyMUxaTnh2dHJITUV3Zi9Hakl0ai8xd3htcGMzb0N0aFlX?=
 =?utf-8?B?SVJhQ28yYVcxS2NPeDNPTzd2bkpKYzNoVmVmU1lIZ29wOTdaak5NUXdOZEJ3?=
 =?utf-8?B?TGJNcEQzcTJvR3lRTkRkZnNhZ3FCVWY2NnVuRnBLUnJLMFpYSFQxczZ4eW1q?=
 =?utf-8?B?WmlxeGV0QWNKWklHdjRvLy9IUk1Lc1BtTjVweGR1WUZDbGx3blJtNUlmRjNm?=
 =?utf-8?B?ZjRwUjRVc1kvOG1jZkRvd1N4NVBUZERGcURyOGd6UnN0bnlseDJXYWlhMWlv?=
 =?utf-8?B?N0k0Y0VsOEtzNUZzbUt1TWdsMXpRUnlOMXhmRlRyQWpzSWF0UTF2aU54bGFq?=
 =?utf-8?B?Y1JsOW5tVElJajBOcUY4MGZBeXg1SGdpcVptcmpya0V4VzFKcVdxRldkODNI?=
 =?utf-8?B?L3l5d09TMVpTSUIyZnNPV2U1bmZVUHhrQ1dJWmxkd2pPSk5SZ01hMUhaNm5W?=
 =?utf-8?B?V2xycURDMVYvNnhPQnFOU2N1WnFXUm1tdnZOMEhKaWtlbC9Zd28xejBIcmRL?=
 =?utf-8?B?VmJLVkpjaHh5NU1DYnp6TXB0M1Bad0x5TDNqUXNOb1gzZ0FhRiszZzhmanZj?=
 =?utf-8?B?YVp0Ulk4UW1QNjY3OTlhd1RRRWNRT0U2cmNkTzBCdms2QnNRcW1TOThiSk9J?=
 =?utf-8?B?R3IyUFBqbDVjVkJ2NWV1b2hiQkJML053T1hZOHBjdVJXOWYwbXVxQmVEOWRX?=
 =?utf-8?B?K1Y0cmM0ZlVseVowTWlDM2tDV2laRjRUd0lwTlZkTDBqMDlHbmFFbURIbEx1?=
 =?utf-8?B?WUJabGxQNk1QbWJkVlFmc1ljalVDOWRVbjJvazdpaEloS2pDK2gvcTFnUlRm?=
 =?utf-8?B?eXBBY3R0YlgrQmRxWHBBeklSL0lEWlhlR3VHaVhFMmpXaDkxWFVSRFViNkdM?=
 =?utf-8?B?SXM5QnNmTWZSV05RbzUvck9QQis0L3MrWEhXVUZveS82cE9xcFc1MHBqUURw?=
 =?utf-8?B?N1pwWXZ5dTZxckJ4Q1hLVG5OaU1ERURGRVNJdjR0Zi8xTzBnbFhKUE5Ba0xw?=
 =?utf-8?B?SkNjWGZVR0J6TTdjQTJGMUhnbktUbmZXUVN6bW1yU0ZCSE16YU8vZTVXWXJm?=
 =?utf-8?B?UzVwVzVJSjdFSHRPbkMvbUUxRVFTdnpvVkNwUElLelRhZERpanhMc3RxVFdR?=
 =?utf-8?B?dis1L1o0ZjNNWkQ0cDJwbGlkRkwvQ0h6bTJEdUQ0Y24rSGtxV0tUVnQyWlB2?=
 =?utf-8?B?Tk14WUpYUThkbDc2enNDS0d4aFN5SGpGbTZib3NkNnh5cUR6ZlZlSDJNU2FV?=
 =?utf-8?B?ditEQktkczVETUVNY0wyRVVNSnNRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 949515b2-ff2d-4dba-8c06-08d9e72c651d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5481.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 15:46:51.4397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 58WJTvjHM5/VHctErDh7zyHzdc8SaLkHj+pPX0AxsnhXb5w/dDibh8Cg/QHmk1AI78H/8KA4qzBVnk1pf9SQDcjYvW5mcXAFjYyXQuXXtaI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4133
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10247 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=838 adultscore=0
 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202030096
X-Proofpoint-ORIG-GUID: YhkMrY1e9g5SjkJ0ZVwZLxrw15Fky51z
X-Proofpoint-GUID: YhkMrY1e9g5SjkJ0ZVwZLxrw15Fky51z
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/02/2022 15:09, Borislav Petkov wrote:

> On Thu, Feb 03, 2022 at 02:19:19PM +0100, William Roche wrote:
>> As we are moving the dram_type cached date from pvt to umc for family >=
>> 0x17, should we also add a small comment for the dram_type field in the
>> amd64_pvt structure to indicate that ?
> Who would be that comment for? People who are looking at the code, so
> that they know which is which?

Yes, it could be a hint about the use case of this field.
Of course we could be more complete and also comment the umc field use 
in this same structure that depends on the family higher or lower than 
17 too.
But I had the impression that the creation of a new dram_type cache 
field would be clarified by a comment on the old location, that's it.
It's up to Yazen and you to include or not  this small addition about 
dram_type.

>
>> Something like that for example:
>>
>> @@ -385,7 +385,7 @@
>>       /* place to store error injection parameters prior to issue */
>>       struct error_injection injection;
>>
>> -    /* cache the dram_type */
>> +    /* cache the dram_type for family<0x17 */
>>       enum mem_type dram_type;
>>
>>       struct amd64_umc *umc;    /* UMC registers */
>>
>>
>> Just a suggestion.
>> The code looks good to me.
>>
>> Reviewed-by: William Roche <william.roche@oracle.com>
>>
>> W.
> Btw, I'd appreciate it if you do not top-post.
>
> Thx.

Sure, sorry.