Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 02 Feb 2022 15:38:16 +0530
Message-ID: <1167862481.1626207.1643796496590@mail-kr5-2>
Mime-Version: 1.0
Subject: RE: [PATCH RESEND v2] scripts/checkpatch.pl: remove _deferred and
 _deferred_once false warning
Reply-To: maninder1.s@samsung.com
Sender: Maninder Singh <maninder1.s@samsung.com>
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Joe Perches <joe@perches.com>,
        "apw@canonical.com" <apw@canonical.com>,
        "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vaneet Narang <v.narang@samsung.com>
In-Reply-To: <b7f445008e9921f41df36077a7e28562675e8417.camel@perches.com>
Content-Type: multipart/mixed;
        boundary="----=_Part_1626206_1445824588.1643796496590"
CMS-TYPE: 105P
References: <b7f445008e9921f41df36077a7e28562675e8417.camel@perches.com>
        <4ee87d70d5348949787b2d747f90ecffa3119d0b.camel@perches.com>
        <20220202071405.1872044-1-maninder1.s@samsung.com>
        <20220202095225epcms5p271da4783d86cb7c51d12d80f097aea44@epcms5p2>
        <CGME20220202071414epcas5p1d329ae4f76c281c1f8f7f07bfb36a919@epcms5p5>
Precedence: bulk

------=_Part_1626206_1445824588.1643796496590
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"

Hi,

> > > >  printk_deferred and printk_deferred_once requires LOGLEVEL in argument,
> > > >  but checkpatch.pl reports it as warning:
> >  
> > > When did that occur?  Please reference the specific commit.
> > > When printk_sched (now printk_deferred) was created it did not
> > > allow KERN_<LEVEL>.
> >  
> > > see commit 3ccf3e830615 ("printk/sched: Introduce special printk_sched() for those awkward moments")
> >  
> > I think with below commit:
> > 
> > 98e35f5894cf208084688ec0c7bb7b713efc997f (printk: git rid of [sched_delayed] message for printk_deferred)
> > 
> > earlier it was passing hardcoded KERN_WARNING to all printk_deferred messages, but now it switched
> > to normal printk behavior.
> > 
> > -       if (in_sched)
> > -               text_len = scnprintf(text, sizeof(textbuf),
> > -                                    KERN_WARNING "[sched_delayed] ");
> > -
> > -       text_len += vscnprintf(text + text_len,
> > -                              sizeof(textbuf) - text_len, fmt, args);
> > +       text_len = vscnprintf(text, sizeof(textbuf), fmt, args);
> > 
> > 
> > I did not search that earlier, because we were fixing some issue in our local module code with printk_deferred
> > and then checkatch reported the issues, so thought of fixing it, becaue without level
> > pritk_deferred messages was shifted to default loglevel as done by normal printk.
> > 
> > So I thought it was designed to pass loglevel from starting stage and checjpatch reports falsely.
> > but seems checkpatch needs to fixed with that commit itself, because earlier it was not required to pass loglevel.
>  
> Most of that should be in the commit message.

Yes, Initially I thought it's added in checkpatch by mistake,
I Should have checked history of printk_deferred also.

I will send new version with updated comit message.

Thanks
------=_Part_1626206_1445824588.1643796496590
Content-Type: application/octet-stream
Content-Disposition: attachment; filename="rcptInfo.txt"
Content-Transfer-Encoding: base64

DQogICA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0NCiAgICAgIFN1YmplY3QgICAgOiBSZTogW1BBVENIIFJFU0VO
RCB2Ml0gc2NyaXB0cy9jaGVja3BhdGNoLnBsOiByZW1vdmUgX2RlZmVycmVkIGFuZCBfZGVmZXJy
ZWRfb25jZSBmYWxzZSB3YXJuaW5nDQogICAgICBGcm9tICAgICAgIDogbnVsbA0KICAgICAgU2Vu
dCBEYXRlICA6IDIwMjItMDItMDIgMTU6MjkgIEdNVCs1OjMwDQogICA9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
CiAgICAgICAgICAgICAgICAgIE5hbWUgICAgICAgICAgICAgICAgVHlwZSAgICAgICAgICBKb2Ig
VGl0bGUgICAgICAgICAgICAgICAgICAgICAgIERlcHQuICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIENvbXBhbnkgICAgICAgICAgICAgICAgDQogICA9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCiAgICAg
IE1hbmluZGVyIFNpbmdoICAgICAgICAgICAgICAgICBUTyAgICAgICAgIFN0YWZmIEVuZ2luZWVy
ICAgICAgICAgICAgIFN5c3RlbSBTL1cgR3JvdXAgL1NSSS1EZWxoaSAgICAgICAgICAgICAgIFNh
bXN1bmfCoEVsZWN0cm9uaWNzwqANCiAgICAgIGFwd0BjYW5vbmljYWwuY29tICAgICAgICAgICAg
ICBUTw0KICAgICAgZHdhaXBheWFucmF5MUBnbWFpbC5jb20gICAgICAgIFRPDQogICAgICBsdWth
cy5idWx3YWhuQGdtYWlsLmNvbSAgICAgICAgVE8NCiAgICAgIGxpbnV4LWtlcm5lbEB2Z2VyLmtl
cm5lbC5vcmcgICBDQw0KICAgICAgVmFuZWV0IE5hcmFuZyAgICAgICAgICAgICAgICAgIENDICAg
ICAgICAgQXNzb2NpYXRlIEFyY2hpdGVjdCAgICAgICAgU3lzdGVtIFMvVyBHcm91cCAvU1JJLURl
bGhpICAgICAgICAgICAgICAgU2Ftc3VuZyBFbGVjdHJvbmljcw0KICAgPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
DQo=

------=_Part_1626206_1445824588.1643796496590--