Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Hoyoung SEO'" <hy50.seo@samsung.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <avri.altman@wdc.com>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>, <beanhuo@micron.com>,
        <asutoshd@codeaurora.org>, <cang@codeaurora.org>,
        <bvanassche@acm.org>, <bhoon95.kim@samsung.com>,
        <kwmad.kim@samsung.com>
Cc:     "'kernel test robot'" <lkp@intel.com>
In-Reply-To: <12a201d81892$c8123d40$5836b7c0$@samsung.com>
Subject: RE: [PATCH v2] scsi: ufs: disable auto hibern8 while entering
 suspend
Date:   Thu, 3 Feb 2022 12:20:38 +0530
Message-ID: <066101d818ca$5dba71f0$192f55d0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIlzz+JKCbQP4e9lbbSHSqpu8nHvgHyie3oAmFa8EUCXuTdUKuwXzjw
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20220125062155epcas2p15da28303164091b1bf5a00dcf99fe59b@epcas2p1.samsung.com>
        <20220124180637.160524-1-hy50.seo@samsung.com>
        <40986ecb6c81812a1e1ab24d93e46eda75974c4e.camel@mediatek.com> 
        <12a201d81892$c8123d40$5836b7c0$@samsung.com>
Precedence: bulk

Hi Hoyoung

>-----Original Message-----
>From: Hoyoung SEO =5Bmailto:hy50.seo=40samsung.com=5D
>Sent: Thursday, February 3, 2022 5:43 AM
>To: linux-scsi=40vger.kernel.org; linux-kernel=40vger.kernel.org;
>alim.akhtar=40samsung.com; avri.altman=40wdc.com; jejb=40linux.ibm.com;
>martin.petersen=40oracle.com; beanhuo=40micron.com;
>asutoshd=40codeaurora.org; cang=40codeaurora.org; bvanassche=40acm.org;
>bhoon95.kim=40samsung.com; kwmad.kim=40samsung.com
>Cc: 'kernel test robot' <lkp=40intel.com>
>Subject: RE: =5BPATCH v2=5D scsi: ufs: disable auto hibern8 while entering=
 suspend
>
>Hi,
>Please check this patch.
>If there is any other opinion, please give me comments Thanks
>
>> -----Original Message-----
>> From: =EC=84=9C=ED=98=B8=EC=98=81=20=5Bmailto:hy50.seo=40samsung.com=5D=
=0D=0A>>=20Sent:=20Wednesday,=20January=2026,=202022=202:35=20PM=0D=0A>>=20=
To:=20'linux-scsi=40vger.kernel.org';=20'linux-kernel=40vger.kernel.org';=
=0D=0A>>=20'alim.akhtar=40samsung.com';=20'avri.altman=40wdc.com';=0D=0A>>=
=20'jejb=40linux.ibm.com';=20'martin.petersen=40oracle.com';=0D=0A>>=20'bea=
nhuo=40micron.com';=20'asutoshd=40codeaurora.org';=0D=0A>>=20'cang=40codeau=
rora.org';=20'bvanassche=40acm.org';=0D=0A>'bhoon95.kim=40samsung.com';=20'=
kwmad.kim=40samsung.com'=0D=0A>>=20Cc:=20'kernel=20test=20robot'=0D=0A>>=20=
Subject:=20RE:=20=5BPATCH=20v2=5D=20scsi:=20ufs:=20disable=20auto=20hibern8=
=20while=20entering=0D=0A>>=20suspend=0D=0A>>=0D=0A>>=20Hi,=0D=0A>>=20I=20t=
hink=20content=20is=20lacking=20in=20the=20UFSHCI=20spec.=0D=0A>>=20In=20th=
e=20process,=20AH8=20is=20in=20operation,=20and=20it=20seems=20that=20sendi=
ng=20the=0D=0A>>=20command=0D=0A>>=20hibern8=20by=20manual=20has=20a=20defe=
at.=0D=0A>>=20I=20don't=20know=20what=20the=20all=20hci=20vendor's=20hardwa=
re=20design=20will=20be,=20but=0D=0A>>=20there=20is=20a=20possibility=20tha=
t=20ah8=20and=20manual=20hibern8=20may=20overlap.=0D=0A>>=20So=20if=20is=20=
operating=20in=20ah8,=20it=20is=20thought=20that=20it=20will=20be=20safer=
=20to=0D=0A>>=20disable=0D=0A>>=20ah8=20before=20sending=20hibern8=20comman=
d.=0D=0A>>=0D=0AI=20am=20not=20sure,=20if=20this=20problem=20is=20generic=
=20and=20faced=20by=20all=20other=20UFS=20vendors.=0D=0AIf=20not,=20how=20a=
bout=20having=20a=20vendor=20specific=20call=20back=20for=20your=20platform=
=20only?=0D=0AJust=20a=20thought.=0D=0A=0D=0A>>=20>=20-----Original=20Messa=
ge-----=0D=0A>>=20>=20From:=20Stanley=20Chu=20=5Bmailto:stanley.chu=40media=
tek.com=5D=0D=0A>>=20>=20Sent:=20Wednesday,=20January=2026,=202022=2010:22=
=20AM=0D=0A>>=20>=20To:=20SEO=20HOYOUNG;=20linux-scsi=40vger.kernel.org;=0D=
=0A>>=20>=20linux-kernel=40vger.kernel.org;=20alim.akhtar=40samsung.com;=0D=
=0A>>=20>=20avri.altman=40wdc.com;=20jejb=40linux.ibm.com;=0D=0A>martin.pet=
ersen=40oracle.com;=0D=0A>>=20>=20beanhuo=40micron.com;=20asutoshd=40codeau=
rora.org;=0D=0A>cang=40codeaurora.org;=0D=0A>>=20>=20bvanassche=40acm.org;=
=20bhoon95.kim=40samsung.com;=0D=0A>kwmad.kim=40samsung.com=0D=0A>>=20>=20C=
c:=20kernel=20test=20robot;=20peter.wang=40mediatek.com=0D=0A>>=20>=20Subje=
ct:=20Re:=20=5BPATCH=20v2=5D=20scsi:=20ufs:=20disable=20auto=20hibern8=20wh=
ile=0D=0A>>=20>=20entering=20suspend=0D=0A>>=20>=0D=0A>>=20>=20Hi=20Hoyoung=
,=0D=0A>>=20>=0D=0A>>=20>=20On=20Tue,=202022-01-25=20at=2003:06=20+0900,=20=
SEO=20HOYOUNG=20wrote:=0D=0A>>=20>=20>=20v1->=20v2:=20fixed=20no=20previous=
=20prototype=20warning=0D=0A>>=20>=20>=20Reported-by:=20kernel=20test=20rob=
ot=20<lkp=40intel.com>=0D=0A>>=20>=20>=0D=0A>>=20>=20>=20All=20warnings=20(=
new=20ones=20prefixed=20by=20>>):=0D=0A>>=20>=20>=20>=20>=20drivers/scsi/uf=
s/ufshcd.c:4207:6:=20warning:=20no=20previous=0D=0A>>=20>=20>=20>=20>=20pro=
totype=0D=0A>>=20>=20>=0D=0A>>=20>=20>=20for=20'ufshcd_auto_hibern8_disable=
'=20=5B-Wmissing-prototypes=5D=0D=0A>>=20>=20>=204207=20=7C=20void=20ufshcd=
_auto_hibern8_disable(struct=20ufs_hba=20*hba)=0D=0A>>=20>=20>=0D=0A>>=20>=
=20>=20If=20using=20auto=20hibern8=20mode,=20need=20to=20disable=20auto=20h=
ibern8=20while=0D=0A>>=20>=20>=20entering=20suspend.=0D=0A>>=20>=20>=20When=
=20using=20auto=20hibern8=20mode,=20it=20does=20not=20seem=20right=20to=20s=
end=20a=20uic=0D=0A>>=20>=20>=20command=0D=0A>>=20>=0D=0A>>=20>=20The=20UFS=
HCI=20spec=20does=20not=20mention=20the=20above=20rule.=0D=0A>>=20>=20Why=
=20would=20you=20need=20to=20disable=20AH8=20before=20using=20UIC=20command=
=20to=20enter=0D=0A>H8?=0D=0A>>=20>=0D=0A>>=20>=20>=20for=20entry=20into=20=
hibern8=20in=20the=20next=0D=0A>>=20>=20>=20line(ufshcd_lik_state_transitio=
n(..))=0D=0A>>=20>=20>=20It=20seem=20right=20to=20send=20after=20disable=20=
auto=20hibern8.=0D=0A>>=20>=20>=0D=0A>>=20>=20>=20In=20addition,=20if=20the=
=20auto=20hibern8=20mode=20supported,=20it=20is=20enabled=20in=0D=0A>>=20>=
=20>=20resume.=0D=0A>>=20>=20>=20So=20it=20seems=20that=20it=20will=20be=20=
paired=20only=20when=20auto=20hibern8=20is=0D=0A>>=20>=20>=20disabled=20whi=
le=20entering=20suspend.=0D=0A>>=20>=20>=0D=0A>>=20>=20>=20Signed-off-by:=
=20SEO=20HOYOUNG=20<hy50.seo=40samsung.com>=0D=0A>>=20>=20>=20---=0D=0A>>=
=20>=20>=20=20drivers/scsi/ufs/ufshcd.c=20=7C=2014=20++++++++++++++=0D=0A>>=
=20>=20>=20=201=20file=20changed,=2014=20insertions(+)=0D=0A>>=20>=20>=0D=
=0A>>=20>=20>=20diff=20--git=20a/drivers/scsi/ufs/ufshcd.c=20b/drivers/scsi=
/ufs/ufshcd.c=0D=0A>>=20>=20>=20index=20460d2b440d2e..a6edbbd8ca2c=20100644=
=0D=0A>>=20>=20>=20---=20a/drivers/scsi/ufs/ufshcd.c=0D=0A>>=20>=20>=20+++=
=20b/drivers/scsi/ufs/ufshcd.c=0D=0A>>=20>=20>=20=40=40=20-254,6=20+254,7=
=20=40=40=20static=20void=0D=0A>>=20>=20>=20ufshcd_wb_toggle_flush_during_h=
8(struct=20ufs_hba=20*hba,=20bool=20set);=0D=0A>>=20>=20>=20static=20inline=
=20void=20ufshcd_wb_toggle_flush(struct=20ufs_hba=20*hba,=0D=0A>>=20>=20>=
=20bool=20enable);=20=20static=20void=20ufshcd_hba_vreg_set_lpm(struct=20uf=
s_hba=0D=0A>>=20>=20>=20*hba);=20static=20void=20ufshcd_hba_vreg_set_hpm(st=
ruct=20ufs_hba=20*hba);=0D=0A>>=20>=20>=20+static=20void=20ufshcd_auto_hibe=
rn8_disable(struct=20ufs_hba=20*hba);=0D=0A>>=20>=20>=0D=0A>>=20>=20>=20=20=
static=20inline=20void=20ufshcd_enable_irq(struct=20ufs_hba=20*hba)=20=20=
=7B=20=40=40=0D=0A>>=20>=20>=20-4204,6=20+4205,18=20=40=40=20void=20ufshcd_=
auto_hibern8_update(struct=20ufs_hba=0D=0A>>=20>=20>=20*hba,=20u32=20ahit)=
=20=20=7D=0D=0A>EXPORT_SYMBOL_GPL(ufshcd_auto_hibern8_update);=0D=0A>>=20>=
=20>=0D=0A>>=20>=20>=20+static=20void=20ufshcd_auto_hibern8_disable(struct=
=20ufs_hba=20*hba)=20=7B=0D=0A>>=20>=20>=20+=09unsigned=20long=20flags;=0D=
=0A>>=20>=20>=20+=0D=0A>>=20>=20>=20+=09if=20(=21ufshcd_is_auto_hibern8_sup=
ported(hba))=0D=0A>>=20>=20>=20+=09=09return;=0D=0A>>=20>=20>=20+=0D=0A>>=
=20>=20>=20+=09spin_lock_irqsave(hba->host->host_lock,=20flags);=0D=0A>>=20=
>=20>=20+=09ufshcd_writel(hba,=200,=20REG_AUTO_HIBERNATE_IDLE_TIMER);=0D=0A=
>>=20>=20>=20+=09spin_unlock_irqrestore(hba->host->host_lock,=20flags);=20=
=7D=0D=0A>>=20>=20>=20+=0D=0A>>=20>=20>=20=20void=20ufshcd_auto_hibern8_ena=
ble(struct=20ufs_hba=20*hba)=20=20=7B=0D=0A>>=20>=20>=20=20=09unsigned=20lo=
ng=20flags;=0D=0A>>=20>=20>=20=40=40=20-8925,6=20+8938,7=20=40=40=20static=
=20int=20__ufshcd_wl_suspend(struct=0D=0A>>=20>=20>=20ufs_hba=20*hba,=20enu=
m=20ufs_pm_op=20pm_op)=0D=0A>>=20>=20>=20=20=09=20*=20with=20the=20link=20o=
ff,=20so=20do=20not=20check=20for=20bkops.=0D=0A>>=20>=20>=20=20=09=20*/=0D=
=0A>>=20>=20>=20=20=09check_for_bkops=20=3D=20=21ufshcd_is_ufs_dev_deepslee=
p(hba);=0D=0A>>=20>=20>=20+=09ufshcd_auto_hibern8_disable(hba);=0D=0A>>=20>=
=20>=20=20=09ret=20=3D=20ufshcd_link_state_transition(hba,=20req_link_state=
,=0D=0A>>=20>=20>=20check_for_bkops);=0D=0A>>=20>=20>=20=20=09if=20(ret)=0D=
=0A>>=20>=20>=20=20=09=09goto=20set_dev_active;=0D=0A>=0D=0A>=0D=0A=0D=0A=
=0D=0A