Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v5 13/70] mm/mmap: Use the maple tree for find_vma_prev()
 instead of the rbtree
Thread-Topic: [PATCH v5 13/70] mm/mmap: Use the maple tree for find_vma_prev()
 instead of the rbtree
Thread-Index: AQHYF951yvrqr+mfu0qNX+NvqFgi7A==
Date:   Wed, 2 Feb 2022 02:42:02 +0000
Message-ID: <20220202024137.2516438-14-Liam.Howlett@oracle.com>
References: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?QAyEE0Zfte4IcBDXSBwiCPbIezQcrohlrYyf/Ej1HzQ9OfzsbjL+51x3/c?=
 =?iso-8859-1?Q?5ou7cgfZdZxTqld1NJAOriR56r0M80kK5K4Zw6nAIUW5JRE1KXQA+VCKDR?=
 =?iso-8859-1?Q?SdTi+WihLisQCJDuTe7L74gYr0RTGJMRT1+ypv1zlR3eyyGwQQ4IWKLGgE?=
 =?iso-8859-1?Q?aE+uQhb2XZ7ihPDdYPmhRgpSzwXQxU+zpx3HV+kckM5HXqoXk+CNVajt75?=
 =?iso-8859-1?Q?9mOkae7ZucjbPWUDhbz+rgHDg2p5QSJMAf7pyIRqNU6bgFuqhQwst8pilQ?=
 =?iso-8859-1?Q?AdX0hycfeMZuBAt2g9+yOxRPOUmj38u/1TF5XfyjNg9qzdjYpVpHOVXz/u?=
 =?iso-8859-1?Q?rPB1ch7+5SdbEBNxac0PaC/wn9njk5S2JDM3Aakqg/yWEbrmixM5eq7zps?=
 =?iso-8859-1?Q?brC3NYBD4gTHdEc8XaDP6MmVkXtJFE9zRq1lHOSv3eNW0AKnzeXZa5a8Iv?=
 =?iso-8859-1?Q?q+IrKu7njTn8inQbDgMu1JRJpZVvOQKVlyM6gdtJntAX3AioIft2g/ot01?=
 =?iso-8859-1?Q?eBEqilXqR/52qz5fW8NL8fGc6m3TLGfXMDNm7oSq8wwzRyXO6MalUuJI7V?=
 =?iso-8859-1?Q?x3cfu4KlyVaWY57WOnxU9AeSB2/nk3+eB65UXbLIP+zgB1TW96KQzakRSu?=
 =?iso-8859-1?Q?qyCfqmqp7rhBj5zTMQ4ulzqnMk8sX9T/c6nl9gq5o6zsprdk4HwvQj88q0?=
 =?iso-8859-1?Q?kKMlBDNFgEMV+OxbqBUSTSrWNlvPaPNKJQMhFz5b/DCbpUHcrRBA5fbKGz?=
 =?iso-8859-1?Q?/0pGkLZbdBrkTDKZvFL77G8lQVjnWxw3jsGYgM46y9UbFvcLxYhhehiWOp?=
 =?iso-8859-1?Q?4eKgL9EYC0CNgKCtPiPHkhg/JQ6MhVEGgmDNUMXg+66PyC0YmZqD9VIAFi?=
 =?iso-8859-1?Q?Bb3AKgSozYuyghzmNGLU4iumj6jB7wNN+4UMXIyaV400ZUm48EEIC2osPQ?=
 =?iso-8859-1?Q?vvwWKnZDRHGOXeyOnSAe6jnMyV922jk4vpEbu9YTA8Konj5Nf354VrKWLz?=
 =?iso-8859-1?Q?O1NPifITPip1MHjxpmj59WZa3eYYsqETxS1hN/pae5PBHaLSHjDSQJJJFM?=
 =?iso-8859-1?Q?8TgOdawAsYM8sVHClQOI4NYjyk3OQC2RDJ/QlvgDs0cVaf4xenw4w1Cs0u?=
 =?iso-8859-1?Q?QkE4c4qs4BZcX6HULdl1b460FSFn6A65jmfo6aXfRLk3JlzctXeUSU+Ddk?=
 =?iso-8859-1?Q?vjoNjNHhGZ/O0EXi2sjisSm1gOx6V5qbxn9EcwpQJOmhESZ/BIVO6Bf/Of?=
 =?iso-8859-1?Q?ysKJ4YS2jcv7EsczS8EE3oYOWL83wCJ1kNgSxVJtQwf5AGb6lekKEyVAs8?=
 =?iso-8859-1?Q?tCrq9Ta7M6ghWx4Bwkp2F0KfyWj02xqZodoiPAg1pupX47pmoFVyw8bsRd?=
 =?iso-8859-1?Q?zPEz1YmsJ6ckWyU9u5EtmSDIbW2q86Gf3TKbfVLlaZ50nE6DW2WyScNDC/?=
 =?iso-8859-1?Q?YcNSW6dmZEtO/TfxHPIAxEkjNLox5lp416r7XbEevuqN23VLkOp9P0s2Sd?=
 =?iso-8859-1?Q?J2YFgqrLEEkzWxDcd/sz/Tev1P/r1VwEWIDIhuzsYam0nZRBPEFDgP4755?=
 =?iso-8859-1?Q?VJfpT5bRcC93Y/epp6OxknAi33ztneJcLZkJ+6CmlsBYMeKeBs+M/hqxuv?=
 =?iso-8859-1?Q?DhLq4FqWnz934M6DmWvc+TkYhqYQJ39myt7DyWnu94E9GaBx9pIFzT83W/?=
 =?iso-8859-1?Q?3atRnvlFFKyAORv9D/Q=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62c32f1c-477b-40a2-43fd-08d9e5f598d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 02:42:02.6270
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cXIJoqXfH1NeglL6R5AD9amq4Mg8qsHKrEarD314SFsDTe5u6V0I+bc08WQw1aLnzbkDyWcEn/SNzj4fc3PEkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3970
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0
 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020010
X-Proofpoint-GUID: ayDZ7GXRekraqXsDdqxrJsSYnvF7fQhV
X-Proofpoint-ORIG-GUID: ayDZ7GXRekraqXsDdqxrJsSYnvF7fQhV
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Use the maple tree's advanced API and a maple state to walk the tree
for the entry at the address of the next vma, then use the maple state
to walk back one entry to find the previous entry.

Add kernel documentation comments for this API.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/mmap.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index bab66a33c9f9..5c331befe739 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2452,23 +2452,30 @@ struct vm_area_struct *find_vma(struct mm_struct *m=
m, unsigned long addr)
 }
 EXPORT_SYMBOL(find_vma);
=20
-/*
- * Same as find_vma, but also return a pointer to the previous VMA in *ppr=
ev.
+/**
+ * find_vma_prev() - Find the VMA for a given address, or the next vma and
+ * set %pprev to the previous VMA, if any.
+ * @mm: The mm_struct to check
+ * @addr: The address
+ * @pprev: The pointer to set to the previous VMA
+ *
+ * Note that RCU lock is missing here since the external mmap_lock() is us=
ed
+ * instead.
+ *
+ * Returns: The VMA associated with @addr, or the next vma.
+ * May return %NULL in the case of no vma at addr or above.
  */
 struct vm_area_struct *
 find_vma_prev(struct mm_struct *mm, unsigned long addr,
 			struct vm_area_struct **pprev)
 {
 	struct vm_area_struct *vma;
+	MA_STATE(mas, &mm->mm_mt, addr, addr);
=20
-	vma =3D find_vma(mm, addr);
-	if (vma) {
-		*pprev =3D vma->vm_prev;
-	} else {
-		struct rb_node *rb_node =3D rb_last(&mm->mm_rb);
-
-		*pprev =3D rb_node ? rb_entry(rb_node, struct vm_area_struct, vm_rb) : N=
ULL;
-	}
+	vma =3D mas_walk(&mas);
+	*pprev =3D mas_prev(&mas, 0);
+	if (!vma)
+		vma =3D mas_next(&mas, ULONG_MAX);
 	return vma;
 }
=20
--=20
2.34.1