Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75b07c8e-b951-fdde-5429-27c9ef198dcc@redhat.com>
Date:   Tue, 1 Feb 2022 18:19:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RESEND v2] KVM: LAPIC: Enable timer posted-interrupt when
 mwait/hlt is advertised
Content-Language: en-US
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, Aili Yao <yaoaili@kingsoft.com>
References: <1643112538-36743-1-git-send-email-wanpengli@tencent.com>
 <ae828eca-40bd-60f3-263f-5b3de637a9aa@redhat.com>
 <CANRm+CwkYJAsv=VngY6m1uQtCLa+WqOJwSJzx95dO7LRAkbsbg@mail.gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <CANRm+CwkYJAsv=VngY6m1uQtCLa+WqOJwSJzx95dO7LRAkbsbg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/1/22 14:57, Wanpeng Li wrote:
> On Tue, 1 Feb 2022 at 20:11, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 1/25/22 13:08, Wanpeng Li wrote:
>>> As commit 0c5f81dad46 (KVM: LAPIC: Inject timer interrupt via posted interrupt)
>>> mentioned that the host admin should well tune the guest setup, so that vCPUs
>>> are placed on isolated pCPUs, and with several pCPUs surplus for*busy*  housekeeping.
>>> It is better to disable mwait/hlt/pause vmexits to keep the vCPUs in non-root
>>> mode. However, we may isolate pCPUs for other purpose like DPDK or we can make
>>> some guests isolated and others not, we may lose vmx preemption timer/timer fastpath
>>> due to not well tuned setup, and the checking in kvm_can_post_timer_interrupt()
>>> is not enough. Let's guarantee mwait/hlt is advertised before enabling posted-interrupt
>>> interrupt. vmx preemption timer/timer fastpath can continue to work if both of them
>>> are not advertised.
>>
>> Is this the same thing that you meant?
>>
>> --------
>> As commit 0c5f81dad46 ("KVM: LAPIC: Inject timer interrupt via posted interrupt")
>> mentioned that the host admin should well tune the guest setup, so that vCPUs
>> are placed on isolated pCPUs, and with several pCPUs surplus for *busy* housekeeping.
>> In this setup, it is preferrable to disable mwait/hlt/pause vmexits to
>> keep the vCPUs in non-root mode.
>>
>> However, if only some guests isolated and others not, they would not have
>> any benefit from posted timer interrupts, and at the same time lose
>> VMX preemption timer fast paths because kvm_can_post_timer_interrupt()
>> returns true and therefore forces kvm_can_use_hv_timer() to false.
>>
>> By guaranteeing that posted-interrupt timer is only used if MWAIT or HLT
>> are done without vmexit, KVM can make a better choice and use the
>> VMX preemption timer and the corresponding fast paths.
>> --------
> 
> Looks better, thanks Paolo! :)

Queued then, thanks!

Paolo