Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a29174ef18ac5a4d6be2cc576252f77a7c16b306.camel@corsac.net>
Subject: Re: [PATCH v2 0/1] ipheth URB overflow fix
From:   Yves-Alexis Perez <corsac@corsac.net>
To:     Georgi Valkov <gvalkov@abv.bg>
Cc:     Jan Kiszka <jan.kiszka@siemens.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        linux-usb <linux-usb@vger.kernel.org>,
        Linux Netdev List <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "stable @ vger . kernel . org" <stable@vger.kernel.org>
Date:   Wed, 02 Feb 2022 18:01:07 +0100
In-Reply-To: <CE7AE1A3-51E9-45CE-A4EE-DACB03B96D9C@abv.bg>
References: <cover.1643699778.git.jan.kiszka@siemens.com>
         <0414e435e29d4ddf53d189d86fae2c55ed0f81ac.camel@corsac.net>
         <CE7AE1A3-51E9-45CE-A4EE-DACB03B96D9C@abv.bg>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.42.3-1 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2022-02-02 at 12:35 +0200, Georgi Valkov wrote:
> Without the patch I get EOVERFLOW and there is no further communication.
> It would be nice if a failsafe mechanism is implemented to recover from
> faults
> like that or in the event that no communication is detected over a certain
> period.
> With the patch applied, everything works fine:
> 1480 bytes from 10.98.8.1: icmp_seq=0 ttl=253 time=50.234 ms

Thanks for the steps. I can confirm that without the patch I get:

[  +4.516398] ipheth 1-3.3:4.2: ipheth_rcvbulk_callback: urb status: -75

and the interface doesn't work anymore.

With the patch applied, I get ping results and the network keeps going.

Regards,
-- 
Yves-Alexis