Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2713935pxb; Thu, 3 Feb 2022 12:33:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzp/Xq6vNhR6RsxJDCeYsdSUJIYXptLYk23SfbN3ftjwaCy1ep19E+EdGCgcLAKbR3Qkqvd X-Received: by 2002:a17:902:ec8f:: with SMTP id x15mr37123324plg.114.1643920402430; Thu, 03 Feb 2022 12:33:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643920402; cv=none; d=google.com; s=arc-20160816; b=jGuO+O8XbtcTcYrzW8dTmB5xiGLqhia2drHzK7pcRQ60V8+PJoSPxkMX01K19uP+oQ HyiUu7UCQZ0WBhsurONpmUQ2Y24FAiZFpVVZM/wQO4VfA+LO3Vy3zPmauJXPwknNsYF7 J9WHbG4D4YmOVKieJJhwUAM/WyFtnIzK4FolgZdZmNukwfmU8KELrHTpcLPWLk6fDOm9 x2kdOx7k2Svv42hkihmU7mI+Q5CysqDElBiZBn/2uzR9PbyLAG4q4sQglCJfahvo9mmK baSdQ3KpC8/uFVdjK7igIVkklGz39Qa6L/MSk9ALdXB+SkG+tSFr10Yr4wU+aBXB3cDr FdZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=gkMbcYY7mfxNWgteUj8QoW+GAKa3j0iV/RuOzaXfxTw=; b=DfAHIW3l+jqTN+p4ivTueVvALy07Z/Sto0Rb+YNKWnMYCpLAa+wD50XC5HqNAsXVNZ EuJCI+jtlknYpyYuXB7T8x+2qd+3oLO0JkDXrgZPO4JPyY0wuQvTz2bc2fQa/X2ohPqh 6kTLxwHXtKT7bDGw544GtGRLdrw1HHXpaox/RGi95HdZ+b5bOoMfsIunOTqehycyfiXX v5x+vcoHWwBkn4Fvr7MAWLdZQeN8dQSQoiuAtEvgcVzmdUOXGpzTfe09SoCnEzWU3XFN fvZNfFx+vmU/a4N1uwNejJ99jeZLKDRTeHk8wcujYEWgrTJWDukWVUG05HM1pgK36Pi5 ISrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KJQb78Ev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r198si4717937pgr.559.2022.02.03.12.33.08; Thu, 03 Feb 2022 12:33:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KJQb78Ev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233640AbiBAFuN (ORCPT + 99 others); Tue, 1 Feb 2022 00:50:13 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:50316 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbiBAFuL (ORCPT ); Tue, 1 Feb 2022 00:50:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D1F5B82D07; Tue, 1 Feb 2022 05:50:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 57745C340ED; Tue, 1 Feb 2022 05:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643694609; bh=pQPHU5fxPMOAOOTaPZAnrF/8lg7d1q5Ch6hn8OyX1iY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=KJQb78EvjJ1wJAB5kjtaP6zJ4XJXkV7hG7x4YB9/0hcJ7hsq/Qw6CJCeJoLHMSwn9 2K213a5lDxKXtYCOqECx5mcRvnnqs+HICUrB90jwsIPqf2UN0FuXmezBIOT3CigqIv 6UrAml1/mCj1m5d9RsnscQoeWhwWhTZEWND9xjRiENZKXL83P/gcebKlPuiT18YqSF X1Ut1Zxx4VyXnVM2jHpetyGXXCh+7xV4VlXR4xmA0wayc51qpskU17e3C3CeGR7sVS hsB1dC/FKIYAuwb2+y+4fLmMXtCr51aKZKanLAnVjsXSdo/Z+1HLIS1KNZZIwb2nWY g/tcoJOAWIUMA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3F973E5D08C; Tue, 1 Feb 2022 05:50:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] net: ena: Do not waste napi skb cache From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164369460925.12551.2952215902913305415.git-patchwork-notify@kernel.org> Date: Tue, 01 Feb 2022 05:50:09 +0000 References: In-Reply-To: To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: netdev@vger.kernel.org, jwiedmann.dev@gmail.com, shayagr@amazon.com, akiyano@amazon.com, darinzon@amazon.com, ndagan@amazon.com, saeedb@amazon.com, davem@davemloft.net, daniel@iogearbox.net, sameehj@amazon.com, weiyongjun1@huawei.com, lorenzo@kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Sat, 29 Jan 2022 08:53:36 +0000 you wrote: > By profiling, discovered that ena device driver allocates skb by > build_skb() and frees by napi_skb_cache_put(). Because the driver > does not use napi skb cache in allocation path, napi skb cache is > periodically filled and flushed. This is waste of napi skb cache. > > As ena_alloc_skb() is called only in napi, Use napi_build_skb() > and napi_alloc_skb() when allocating skb. > > [...] Here is the summary with links: - [v2] net: ena: Do not waste napi skb cache https://git.kernel.org/netdev/net-next/c/7354a426e063 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html