Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oleksandr Mazur <oleksandr.mazur@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <nikolay@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [RFC net-next] net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled
Date:   Thu,  3 Feb 2022 19:06:54 +0200
Message-Id: <20220203170654.29784-1-oleksandr.mazur@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YQ9nXn0BB68m7XePcvhDpfjAOvJYflLDl+u0s5hrXmIObCGO219z73EUroSy?=
 =?us-ascii?Q?1cS+fZrK0dHfPcon1NXLKe73csIrNVcmnfkGXYAW43hLJtq7DL3pXg2nfdeb?=
 =?us-ascii?Q?9HU48bW3IzPbl4cR3swIwwdxuNgh+Rr6IW/Zfy5FjM7d73D84hnNQ58IbiQu?=
 =?us-ascii?Q?BhZJkuxXodJXVVG9CRYVWXFSEF39XC8q1Amisb1HOhQkk+vOrnjId0jp21Jh?=
 =?us-ascii?Q?hTGbUw9kBCnpUK8cbd4+CAXfVpmvq6JgbM12aB6kzJjg0WamV9axkDSCBzw6?=
 =?us-ascii?Q?Of7Ersjlv6NiLiKKDkq1O0HmJn8X0tjcH6NzbZs4H99zV/A1zLcttXqa4A1J?=
 =?us-ascii?Q?0Zu4lcrNGEE2S3KZfCHYV8rUrPRwu9jqocZ9pUfYSNAmoljH0nygaSzTs5ZN?=
 =?us-ascii?Q?66EkJ/KQ3pjeY1lbq2V0PKUbF3xkMh4nMoCpi4oWKLQwSUPYrI3h0LoTX7qC?=
 =?us-ascii?Q?C0FophWchSIVm/6QHyWeVjvr09KuSAqVB+5tGc6ra3l3IlYxNt+fg381ChtQ?=
 =?us-ascii?Q?dvfp4gmTXSKbV1CL4RizvRgMo1klD4CYUx73cVSxjuHzINMSgfsqJlSDtqDL?=
 =?us-ascii?Q?fucY8uVuphiUksMTEEipE3witqUrxgLLVpmJp9stsgYC+tJdSzmxnjTVWCer?=
 =?us-ascii?Q?UoBp91yH5osGvN/WCwdXQTZtA4MUiY7Kql7XFQk7XSln2VUFbx0OIHLS0dhw?=
 =?us-ascii?Q?7rq3fDxcrk8DHIyLGQgPVnSkdfX4YJy7EH1ve/aAZX6RlKP9htH774QbDEXo?=
 =?us-ascii?Q?FI3oJOeHl0FstqJxhC9cpfSUgTqtUd+wGFRM49S+hDs/APb45TWG9+9i11qD?=
 =?us-ascii?Q?sBe1LP7e42JX3fcwORfQ/4wU53XsxOEy8D0czIr7McFG9iMx0whtCCubxVET?=
 =?us-ascii?Q?TfkVhR3GzbDYO8qEumJXUl3dQgo7bZKIKKRba5p9j1C+V9KfCYR40q/Jjhiq?=
 =?us-ascii?Q?Ra6sKLmo5RyLEuYs/Y13qhj0yvOjY3RA07rABrJSyFIYDUrvNTta4goO0Uzt?=
 =?us-ascii?Q?vINRwhHFIHNs13Zb1TZSvhbTjSmi3+ka2rEGdLX2n1LXTRngV+EaiIuWSKAJ?=
 =?us-ascii?Q?AHlWB87JEJkKcNSOL53jt4BxeW7qj9yBOFuRprxIS+trjnxVlqHcCp6SeJi9?=
 =?us-ascii?Q?iSu2IR1GAZjzz6haQIvktl+Y6BaOxJC+NdD1rAxFVegdQug6izS0CLZbKFnu?=
 =?us-ascii?Q?5LHHGDU81uUFjF/W801ByR3XDkOhCF4d993sEaaLSJvvB9U3B/JZyxV77y07?=
 =?us-ascii?Q?b20Dk+FH9axD8e8jSCoTx4yavVSOaUzs53MEr5paDZWa562eX+Y1Jy4CP1rp?=
 =?us-ascii?Q?SktSZT/KW3sxxLemlNpweX6KbEH/xts1wAnPQaAYtIuoPDnCnd3F0yHPMheU?=
 =?us-ascii?Q?yMbCEHGFxsBPm9GyftwqNFF1Cio4f8mX5y9Y7mPTHBTcjziWcS6HwAyhvGs1?=
 =?us-ascii?Q?dx3qQdX8eKsFD+ciCSRGeu4ncM7SGaCy/Ec0p6JeOJDC7G6GbN2F+CoYHhuO?=
 =?us-ascii?Q?YXrMjHWoON+uBjZ9DqPmTBdDpEpumxvouCRvmugKADIgQnkAHxfAMOvf1ROr?=
 =?us-ascii?Q?DRV49FbQ1TTmkUqzdKjUEsrqpgOrmsW1Djkg9/J6n1MRRwgS1W+/ZPpifEhs?=
 =?us-ascii?Q?DNkB+Uvzhhz7k5dl5duQKfRIfXCqCFrYPg2gWIMWtLek8oqKYIxVn8CzKO0+?=
 =?us-ascii?Q?3WZ1Iw=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: d80d484b-7193-4050-96ab-08d9e737a2ed
X-MS-Exchange-CrossTenant-AuthSource: AM0P190MB0738.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 17:07:19.3582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PVpmzEF9OSGiIO7UfvJdITJkhOP/s3CqoCWF9UpooMepw2Q/8rzLJwdSp16X3A70f8idVDvPIPsEpRhs3Km5zSSB3DtcoaDvVv7XPKgwZIE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1P190MB0734
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Whenever bridge driver hits the max capacity of MDBs, it disables
the MC processing (by setting corresponding bridge option), but never
notifies switchdev about such change (the notifiers are called only upon
explicit setting of this option, through the registered netlink interface).

This could lead to situation when Software MDB processing gets disabled,
but this event never gets offloaded to the underlying Hardware.

I would like to propose to simply add a notify message in such case,
as in other places where this option gets altered.

Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
---
 net/bridge/br_multicast.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index de2409889489..d53c08906bc8 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -82,6 +82,9 @@ static void br_multicast_find_del_pg(struct net_bridge *br,
 				     struct net_bridge_port_group *pg);
 static void __br_multicast_stop(struct net_bridge_mcast *brmctx);
 
+static int br_mc_disabled_update(struct net_device *dev, bool value,
+				 struct netlink_ext_ack *extack);
+
 static struct net_bridge_port_group *
 br_sg_port_find(struct net_bridge *br,
 		struct net_bridge_port_group_sg_key *sg_p)
@@ -1156,6 +1159,8 @@ struct net_bridge_mdb_entry *br_multicast_new_group(struct net_bridge *br,
 		return mp;
 
 	if (atomic_read(&br->mdb_hash_tbl.nelems) >= br->hash_max) {
+		err = br_mc_disabled_update(br->dev, false, NULL);
+		WARN_ON(err && err != -EOPNOTSUPP);
 		br_opt_toggle(br, BROPT_MULTICAST_ENABLED, false);
 		return ERR_PTR(-E2BIG);
 	}
-- 
2.17.1