Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        Petr Mladek <pmladek@suse.com>
Cc:     linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        John Ogness <john.ogness@linutronix.de>,
        Stephen Brennan <stephen.s.brennan@oracle.com>
Subject: [PATCH v4 3/4] printk: Avoid livelock with heavy printk during panic
Date:   Wed,  2 Feb 2022 09:18:20 -0800
Message-Id: <20220202171821.179394-4-stephen.s.brennan@oracle.com>
In-Reply-To: <20220202171821.179394-1-stephen.s.brennan@oracle.com>
References: <20220202171821.179394-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kOGXujxlJJx9cheAfOOnoo+9PXqz7NUNqrrZtip8g813WsO9Ta8nUBXAePzT?=
 =?us-ascii?Q?Hxhy8K24KC5Nytx8QzDUea7XWEFLxekC+khJiXCB/7uue6cE4M7n2rcabuHv?=
 =?us-ascii?Q?4ywVZ+HWMZlKQB8/UZcHFIflpwbVLw95z6rI2xHq7dBue0nCJGhp5AsTIT4Y?=
 =?us-ascii?Q?v8KYWYtUhgJBeTLPcS2Bt6Y7tqYss87nuVIQb/uBbCIrpCoEws8KUlHOWAu7?=
 =?us-ascii?Q?1YjaHB8ewUdIDSSa7GcDWJOMZF+WZDPEECu2pB5sqhyJJ1vBOe/QIdu3sfoL?=
 =?us-ascii?Q?B+zS+Y3SPdMviczC1FHzHNUlpbqe2lxKmhctaw20qwoKgMsdyDH3/FWEgPuX?=
 =?us-ascii?Q?KNC3S5CMGW8DJLk6EzIUxsaN+RPtuIblmcEDTvEIYCPxyVlOf2SPYaNIoKRe?=
 =?us-ascii?Q?3kNxcqinEuz6KgsN2JXIj3OOipzlt+FmGh6s/itwC3wm1qLuTVTiePXtLqZt?=
 =?us-ascii?Q?pDmuO1vwniDF8aGdV22dKB/le6N+rYi5LZrjTTAzivNN4d0wKdKvovOtzfsy?=
 =?us-ascii?Q?x9MLpyS/TXtwfMOyizO8wWpmiWD7WYa40XPUG6ZXRqq3qLoW78uao+jAc2pp?=
 =?us-ascii?Q?Vl5bluIFPh1tc59qvxOOLRfuJ+Iw8AEDUX72sbyYkFN0kvc1ooR48n7kG4Fh?=
 =?us-ascii?Q?U70EzCoAiek4FsFT65VMT6B6vTax5MDukx04Mb9xliwYrR7NFuuITCuL0COa?=
 =?us-ascii?Q?Ic6ca0ZAeR0oGGQSxaJK1HFMCzAa91XT2I7ffVieTqMZg+eqX90NwyB6jv/W?=
 =?us-ascii?Q?t9/JUO8BPj4ssQRimG2huwYb7B8mW6xw/055jFLVVSq8u8YwQL79mRf3ZQom?=
 =?us-ascii?Q?n+6ZAmrKBolUph91DUwd/6rAFM+rM/KqK99+CEApvPHqkfiNumkHehgqaG+M?=
 =?us-ascii?Q?TqlKZWG700nxecP/wmulVi1i9wcDgYqGPL5MWH8PHd/M04TZOUf0iT+P9SuQ?=
 =?us-ascii?Q?x9Ld5VhTsastnAolzZ30zXuUuI1D/fkt/bdhJ+bhY0Q+d8me6sqlFES7kG6N?=
 =?us-ascii?Q?hxHvKA8XUODKch8TgoExztX8iXNDSc8V8JI8i8MZ34cb6gvZ8p8H+PZG2Tff?=
 =?us-ascii?Q?r0cDrihHOk6DytNsc+Bb6meajmUi4p05IADduWR62eR26FOU4jyEJzn2YO7k?=
 =?us-ascii?Q?1lCHI1eJ+oIfCWAQNB8YxjzipFwdi31hliwCXHOL0wwQsV9bWQFj4Jy7iXzC?=
 =?us-ascii?Q?Zw2cTfClWAdd8tHwx4NmqSHeft253dZRTczLao/jyps6ewzcSBX4KPT42NXk?=
 =?us-ascii?Q?HNOvU/MSBMyt1KPDJI6v0mbWUX3/oAwDbVbwosN0ApM5CMaUImW/128x5Jcc?=
 =?us-ascii?Q?EDKGNjbQ2zu9bEV2ghJkrY0OY73JqvThrM03IKSdeAyA3O+24c4FM7azDleD?=
 =?us-ascii?Q?53P/65mz3WmXgaBKZR42jg11xIPYTjTWjV9YbjqFOl35VXKqERf8OWvRe5rs?=
 =?us-ascii?Q?Lac42p689WKlh7gh3eL6e9wwOdTimsKZ7TtFIdiVGrpUKI5UmSg4xUU/3AXX?=
 =?us-ascii?Q?53Q8pemEpxpmCkGiYxcfjk5u7+9/eXhJBxwMRMiqnxuhBa+0N9qtY8s1389A?=
 =?us-ascii?Q?9qqDNTbH/QYzMqnzjoLZccNMvAy6STo4HRo/8DlMWScXFlb/YC0le+CvMzmL?=
 =?us-ascii?Q?AfSBRzPlryHU6K2+9iSU9Vb9737M0diWpRIc9lgwJbNg6jeWSzvY3TG8ijLK?=
 =?us-ascii?Q?MoUqvw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfb1220b-7e66-4955-3561-08d9e6700ac6
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:18:34.2841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vuH3996yuAhsZa3ArV+Vydvc7vvikrp1LvFbBA+lcYW8LSNsuKkkaSejNZNwyJssldOAsst+hUywUURDz7nJr28+6Apcj3tDz9ZapSK3L8s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4236
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10246 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020097
X-Proofpoint-GUID: H99jLAZDGZEasr6OWl49C9z3_HUPDZ99
X-Proofpoint-ORIG-GUID: H99jLAZDGZEasr6OWl49C9z3_HUPDZ99
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

During panic(), if another CPU is writing heavily the kernel log (e.g.
via /dev/kmsg), then the panic CPU may livelock writing out its messages
to the console. Note when too many messages are dropped during panic and
suppress further printk, except from the panic CPU. This could result in
some important messages being dropped. However, messages are already
being dropped, so this approach at least prevents a livelock.

Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---

Notes:
    v3: Use pr_warn_once, and don't break the message line
    v2: Add pr_warn when we suppress printk on non-panic CPU

 kernel/printk/printk.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index dfac84876e7a..736f00d33087 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -93,6 +93,12 @@ EXPORT_SYMBOL_GPL(console_drivers);
  */
 int __read_mostly suppress_printk;
 
+/*
+ * During panic, heavy printk by other CPUs can delay the
+ * panic and risk deadlock on console resources.
+ */
+int __read_mostly suppress_panic_printk;
+
 #ifdef CONFIG_LOCKDEP
 static struct lockdep_map console_lock_dep_map = {
 	.name = "console_lock"
@@ -2233,6 +2239,10 @@ asmlinkage int vprintk_emit(int facility, int level,
 	if (unlikely(suppress_printk))
 		return 0;
 
+	if (unlikely(suppress_panic_printk) &&
+	    atomic_read(&panic_cpu) != raw_smp_processor_id())
+		return 0;
+
 	if (level == LOGLEVEL_SCHED) {
 		level = LOGLEVEL_DEFAULT;
 		in_sched = true;
@@ -2618,6 +2628,7 @@ void console_unlock(void)
 {
 	static char ext_text[CONSOLE_EXT_LOG_MAX];
 	static char text[CONSOLE_LOG_MAX];
+	static int panic_console_dropped;
 	unsigned long flags;
 	bool do_cond_resched, retry;
 	struct printk_info info;
@@ -2672,6 +2683,10 @@ void console_unlock(void)
 		if (console_seq != r.info->seq) {
 			console_dropped += r.info->seq - console_seq;
 			console_seq = r.info->seq;
+			if (panic_in_progress() && panic_console_dropped++ > 10) {
+				suppress_panic_printk = 1;
+				pr_warn_once("Too many dropped messages. Suppress messages on non-panic CPUs to prevent livelock.\n");
+			}
 		}
 
 		if (suppress_message_printing(r.info->level)) {
-- 
2.30.2