Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Mark Hemment <markhemm@googlemail.com>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 68/70] mm: Remove the vma linked list
Thread-Topic: [PATCH v5 68/70] mm: Remove the vma linked list
Thread-Index: AQHYF96DwcfP2GXKQkeyOLdIyTnhm6yBvcCAgABYm4A=
Date:   Thu, 3 Feb 2022 17:25:40 +0000
Message-ID: <20220203172533.em5ejhfstja5lk33@revolver>
References: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
 <20220202024137.2516438-69-Liam.Howlett@oracle.com>
 <CANe_+UjtS5_ynjfMfHC_hkb7mAADbsL8UWG7HOwM0aN3Mjn58Q@mail.gmail.com>
In-Reply-To: <CANe_+UjtS5_ynjfMfHC_hkb7mAADbsL8UWG7HOwM0aN3Mjn58Q@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BsnHuCxwi796NohN9kF4VmW9BshHLOjoL77iYuO5sLmrgrXDJvp3tluLrzHv?=
 =?us-ascii?Q?030QA1vhnB+d3HZTDDwYQC8KvHHLOaiatgWasQCIaonjL8eyzMYNZ/ST+Nz6?=
 =?us-ascii?Q?1nzhRPxB4Jp+ZgyKb3gxT6t3MQ9NQx5CDaC0HsQvdp6pLC59LyBgxsjaR0vX?=
 =?us-ascii?Q?Yh37tQ3re3yzOhgS3RwbVxdHibwjwxLkmBABp1U7lux9MmZRL4UBIYplVJ8K?=
 =?us-ascii?Q?iWfj5kV2mS4FFSeLMkPTarjGd7zCQV6UeHtC8OaApGp1yT+Bt1BF2ksMexBI?=
 =?us-ascii?Q?4/0rhF07xHFMUn942QtyNzCVf0FhOsos2gvWkL524atQjnpDeAzK6mCTMwtw?=
 =?us-ascii?Q?yay6+1IsXCp+JLE/i3Fzk/r2wRIR+T26x7bZ9+eEjZlXZTw+Up/W37To0nlb?=
 =?us-ascii?Q?GFOUJczjjV3JrF9w5PxfnXc7Ut/Da8wD4wE9AEUec5H222Jx+cv79Hm2IlFc?=
 =?us-ascii?Q?b1SIGs5em3022bcFd5qtHU8s04rSbSquRpeE1ek4wS86hqnEsbEBd7wrxhZW?=
 =?us-ascii?Q?YvSBZPyKJXXHaKAptwxPbltmta1jWpZ6+qO5M3h5603MU7/o2aNSwpLQwcvs?=
 =?us-ascii?Q?cq529z1nrodUW+eHsZwZLn3SEFHfWn66cA42hrG9tJz0M2uueUmIL7pd7ob4?=
 =?us-ascii?Q?hQnvjulVHQ7qAmknvU/W9eBn8rH29J/wZsb/SHwXBQUtQ0ayCUkpXr17C0V5?=
 =?us-ascii?Q?AWWTvXES+MgnURppNgFtW5VDUnCFMTS3rH1OkWw2xfAMYOh83kknL3qphwkw?=
 =?us-ascii?Q?QW/rx78hgOjHd9CH0bwYvlAvCByFF2M/NWuBp0ErPAkWOUXQHzHiADGleAsB?=
 =?us-ascii?Q?N4SBDGGq5BNS67TdGs44EbyHcDUHvR00Pv6U7edjsDojLR7wF4adoTXviUiO?=
 =?us-ascii?Q?tKb02PoqMBufSUjaPGkNKMdDKp+LfiNnn3A4jXuEbPVlis2pttx6KB94pgDq?=
 =?us-ascii?Q?4/ym3dZqF+qTHdBii+sBxRLoOzJruCnBONrRJ3Y2EZEb/ENRO0jp/Klpe2Ww?=
 =?us-ascii?Q?UXV2E8/bAZWzT/yaEmaUkTAraGEziZWdetvhr3rJ1406g3qtNo4s0Oc5ikbX?=
 =?us-ascii?Q?Ke0PSk+kDoPBIESrYn/Mpi+H1DBVULaMmspjzkQU+uWFr/phMUOuecIbEgdK?=
 =?us-ascii?Q?UO99CFj5TabtTjYt2YLvCBgUK6Y+OGHRj9nmpW508DnUQG2gJh5YOf+u2Bfj?=
 =?us-ascii?Q?QwBDg96p1qHCSWxmsqY4Gv+absca0Ef8bNtbpUP9Cr/jMJXWEzTq6SQWe+Sd?=
 =?us-ascii?Q?H/qJ6iwrkQXHP+ll5LxVGDqcxAu6c4gx0BP4QWjPxkLwmjRMb3j1U03eGUM5?=
 =?us-ascii?Q?aVLJAI71xUBIr4UIOMy6M2AivzM1fvJF3ku6sgM/9OGbtvnCcmxEOqbNQedE?=
 =?us-ascii?Q?MgX/tjxXwInSXii4n+khCHParMMve5o0G1Q6astRoFMAw4WuWX6Zz4i+OJeE?=
 =?us-ascii?Q?xihAyqQAIuuYxzay9OKyHJ2lr6wFbKjUxUR6Y1Zt0umE52CewD10W/ZLmDqC?=
 =?us-ascii?Q?vQ7FrzOrRoKUP7zHY6IfTS6WpOLSeeaTI0ERjMb8QBjfvDq5QbxBRBLZAm+S?=
 =?us-ascii?Q?oimZBPPEF3un6fo5fiBwwvhckr4ZCap5qi8wlidEVoJVyMdF8ExWcDcO3Mrt?=
 =?us-ascii?Q?IbCaNw3LGTZwf8KCj7aqh4A=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <906BC76BF497B6488795BE9F690655CF@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43aa14aa-9208-4e48-3697-08d9e73a335e
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 17:25:40.5098
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lZESoGQGr1P1mmd2LCtBvbmA0pL6MVJQekNdHZ6KcSznzhTiClefVgUnNMtYJLHW/YGU3UXWC5ATqB7tPQzXRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1394
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10247 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0
 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202030105
X-Proofpoint-GUID: d3NLBc1Rp3XsxFbDsmswcRPjVc8Cdtrg
X-Proofpoint-ORIG-GUID: d3NLBc1Rp3XsxFbDsmswcRPjVc8Cdtrg
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Mark Hemment <markhemm@googlemail.com> [220203 07:08]:
> On Wed, 2 Feb 2022 at 02:43, Liam Howlett <liam.howlett@oracle.com> wrote=
:
> >
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >
> > Replace any vm_next use with vma_find().
> >
> > Update free_pgtables(), unmap_vmas(), and zap_page_range() to use the
> > maple tree.
> >
> > Use the new free_pgtables() and unmap_vmas() in do_mas_align_munmap().
> > At the same time, alter the loop to be more compact.
> >
> > Now that free_pgtables() and unmap_vmas() take a maple tree as an
> > argument, rearrange do_mas_align_munmap() to use the new tree to hold
> > the vmas to remove.
> >
> > Remove __vma_link_list() and __vma_unlink_list() as they are exclusivel=
y
> > used to update the linked list
> >
> > Drop linked list update from __insert_vm_struct().
> >
> > Rework validation of tree as it was depending on the linked list.
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > ---
> >  include/linux/mm.h       |   5 +-
> >  include/linux/mm_types.h |   4 -
> >  kernel/fork.c            |  13 +-
> >  mm/debug.c               |  14 +-
> >  mm/gup.c                 |   2 +-
> >  mm/internal.h            |  10 +-
> >  mm/memory.c              |  33 ++-
> >  mm/mmap.c                | 518 +++++++++++++++++----------------------
> >  mm/nommu.c               |   2 -
> >  mm/util.c                |  40 ---
> >  10 files changed, 264 insertions(+), 377 deletions(-)
> ...
> > -static inline int
> > -unlock_range(struct vm_area_struct *start, struct vm_area_struct **tai=
l,
> > -            unsigned long limit)
> > -{
> > -       struct mm_struct *mm =3D start->vm_mm;
> > -       struct vm_area_struct *tmp =3D start;
> > -       int count =3D 0;
> > -
> > -       while (tmp && tmp->vm_start < limit) {
> > -               *tail =3D tmp;
> > -               count++;
> > -               if (tmp->vm_flags & VM_LOCKED) {
> > -                       mm->locked_vm -=3D vma_pages(tmp);
> > -                       munlock_vma_pages_all(tmp);
> > -               }
> > -
> > -               tmp =3D tmp->vm_next;
> > -       }
> > -
> > -       return count;
> > -}
>=20
> Trivial: Comment in exit_mmap(), for oom-victim case, has a reference
> to this removed function (unlock_range()).
>=20

Thanks, I will update the comment too.=