Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Mark Hemment <markhemm@googlemail.com>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 15/70] kernel/fork: Use maple tree for dup_mmap()
 during forking
Thread-Topic: [PATCH v5 15/70] kernel/fork: Use maple tree for dup_mmap()
 during forking
Thread-Index: AQHYF951lzhurrNAW02to7QCIMdfV6yBu18AgABZrIA=
Date:   Thu, 3 Feb 2022 17:20:57 +0000
Message-ID: <20220203172051.i2jnhnkudzssdsxg@revolver>
References: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
 <20220202024137.2516438-16-Liam.Howlett@oracle.com>
 <CANe_+Ui4tud5pnBx81qG-4V-pgO5XQX-rc9rXQWMCi6qqY5bew@mail.gmail.com>
In-Reply-To: <CANe_+Ui4tud5pnBx81qG-4V-pgO5XQX-rc9rXQWMCi6qqY5bew@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DLW8l/mPFRIO5OF565fskXxWCg1RlfFNlNH3b70RZh65RLMGhELCTZDsTuRL?=
 =?us-ascii?Q?fBhqBhSJkCgh366f8HsbmmZIR5jTrhqjrIO3+6haMoKouhWTRYgf7lZHy3W8?=
 =?us-ascii?Q?YcmcMMfscG3kIqEmMOLKp/fGjh5etObbgrIDW3t8wgFFBkkO3Q/03GL+bg4e?=
 =?us-ascii?Q?8+DIOBtTOT/ciS9/jRj8tyWCbp5Zw5rnVH5U7JmffY/l/h86fjq/QXEeTCNs?=
 =?us-ascii?Q?Dik8YMkDiOOWRgLxfihxC4h65RR6l5Ku+aVkv4ZrDxmNUhdqj3sNyzR1IOn1?=
 =?us-ascii?Q?dLi95ixBMwihFLCvIjSxP4wOTmx7yu3VEx4cjF1TiAmsJYAqLaAUIn9Qr+4V?=
 =?us-ascii?Q?utWvfj8UM0ZidUxk6lw2OpFdfnCKC8zGpN5rxhyM8CvhzqS4EcDd/w/75daD?=
 =?us-ascii?Q?TOBkUzNSb4nqD6UgpBhUuMV3VZFs2msmFJS4ZsL7RUpWDeX3pOQZOV7bSMbp?=
 =?us-ascii?Q?K9Mom+EFIdl9T+TMb+FBKbPPctic+bvF2+QRg2MnfjP9FmugpSenszeWBgNg?=
 =?us-ascii?Q?ja6SUUsLKCP1oApZ/UBNvprh02TkTsTQVy7IZqEok01moteYfdXQ6YGebrUX?=
 =?us-ascii?Q?FzGI1K+/3t117NobTYIpcMdFpz2bjL32EacXzjOaZ42h3wDeKO1WDVUrLYZf?=
 =?us-ascii?Q?MQhelSd4EgzM4SMemMGQVkZDOSIyzAOR3gOiMBYaBbMbg46TRdJctdt4sYB9?=
 =?us-ascii?Q?FnjUbfgHgQdrxAlLcbvmwUbVvXSCJVGY3CsbWXDVcwUNtH6NcdGjDyZ0fqI4?=
 =?us-ascii?Q?OUZME/hWSegXhkcit2YllJDR4RBkv0VhgH4+MVd+WCgBlQks77kaAsN3t9cZ?=
 =?us-ascii?Q?cCZImbryn76RS07S4OtUCBjzsvKGBJzdLWYndQqU2kietLtHLxaNyQFsjspW?=
 =?us-ascii?Q?vyOOq2+B75CbZgqKh/lB7Q/7FPSjx4G7w8EWbUmjtl++cy4/kWKJnLzEESwI?=
 =?us-ascii?Q?IZs0kvgRly5nVioQCwq1A/7Y5JSOBLoAikL+tzyNfsoUFZKv5jjVvXNHGDMu?=
 =?us-ascii?Q?72TosJshc6Vu4rX2rhfpaytty6BR3P4YoZnM1USxDRm3ivBmXkTPStgGcD2D?=
 =?us-ascii?Q?dK0G75KjNig3vcoL2Im6BpI84Bv3hjXK6Bb3pSF78jD1NdJ+aBQCdUHvOoG/?=
 =?us-ascii?Q?t91sJE02sfjCZO3aaD26xmSO+PAUKMUJjyEaz+EdrQDjyoyErKDrOXPVutkH?=
 =?us-ascii?Q?a0Ru94EOGMhzClXpzSmRxlMzR7HEzAqnWZSxAFWa6TpuM20Ert5dcjRhs7Jy?=
 =?us-ascii?Q?c5AGfc+EVXHTNUtQMR3NkaeYyVl5xbRuDA3EnMOnZhmrSoBZMIeDK5eajcgs?=
 =?us-ascii?Q?FhHejsmNj4YSjT8WRQPmvFEFgiCEnlNHjWk0Hp+XS7UOqAfatoifh86q6fNb?=
 =?us-ascii?Q?zdIJlJaNjEyKuurVBdaezXY6vlDHXaVSLuPnlBNiwCzIjW2FCnKbwIlgCJeo?=
 =?us-ascii?Q?sSGaN1SanWPs6G6XdWeFp9mFMOqnjU19kyWAbAboEONDFBWI1ARsph/7u2x1?=
 =?us-ascii?Q?/zU79TesU/rF3ZbMewVtnVsX8ukLGDT8z+qU7q762AjRb37Nw7Sf2uUo0kCu?=
 =?us-ascii?Q?Leg1qiBmTHVeLzOZTxgg5fpxigd6cH1HvEwikELDIgzglHrSlu/7e0f9V8y2?=
 =?us-ascii?Q?s69SLdnzvKLb3ngQJmmkX88=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1D0F182E2F3FF2459CCEA6A697C3F6ED@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea98e3f2-1516-4ecb-e2f9-08d9e7398b16
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 17:20:58.1695
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QrMq5uJJMXcF3WlMWFZoAnemBTV4jNKO7t2L+Ij+hEt0WtD7Dvq7n1b0ofYi9gb2JS5BwrjgdLRLcM8OUiQagg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5059
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10247 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202030105
X-Proofpoint-GUID: wzrMnO3Kdcz_j5YzRV3tRdriiOkevW-5
X-Proofpoint-ORIG-GUID: wzrMnO3Kdcz_j5YzRV3tRdriiOkevW-5
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Mark Hemment <markhemm@googlemail.com> [220203 07:00]:
> On Wed, 2 Feb 2022 at 03:23, Liam Howlett <liam.howlett@oracle.com> wrote=
:
> >
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >
> > The maple tree was already tracking VMAs in this function by an earlier
> > commit, but the rbtree iterator was being used to iterate the list.
> > Change the iterator to use a maple tree native iterator and switch to
> > the maple tree advanced API to avoid multiple walks of the tree during
> > insert operations.  Unexport the now-unused vma_store() function.
> >
> > We track whether we need to free the VMAs and tree nodes through RCU
> > (ie whether there have been multiple threads that can see the mm_struct
> > simultaneously; by pthread(), ptrace() or looking at /proc/$pid/maps).
> > This setting is sticky because it's too tricky to decide when it's safe
> > to exit RCU mode.
> >
> > For performance reasons we bulk allocate the maple tree nodes.  The nod=
e
> > calculations are done internally to the tree and use the VMA count and
> > assume the worst-case node requirements.  The VM_DONT_COPY flag does
> > not allow for the most efficient copy method of the tree and so a bulk
> > loading algorithm is used.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > Acked-by: Vlastimil Babka <vbabka@suse.cz>
> > ---
> >  include/linux/mm.h       |  2 --
> >  include/linux/sched/mm.h | 13 +++++++++++++
> >  kernel/fork.c            | 35 +++++++++++++++++++++++++++++------
> >  3 files changed, 42 insertions(+), 8 deletions(-)
> ....
> > diff --git a/kernel/fork.c b/kernel/fork.c
> > index 51a7971651ef..8ea683fcefcd 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -377,6 +377,16 @@ void vm_area_free(struct vm_area_struct *vma)
> >         kmem_cache_free(vm_area_cachep, vma);
> >  }
> >
> > +void mm_set_in_rcu(struct mm_struct *mm)
> > +{
> > +       if (!mt_in_rcu(&mm->mm_mt))
> > +               return;
> > +       mmap_write_lock(mm);
> > +       mm->mm_mt.ma_flags |=3D MT_FLAGS_USE_RCU;
> > +       mmap_write_unlock(mm);
> > +}
> > +EXPORT_SYMBOL(mm_set_in_rcu);
>=20
> The mt_in_rcu() test looks wrong (inverted).
> mt_in_rcu() returns true only when MT_FLAGS_USE_RCU is set, so this
> flag will never set here.
> All callers of mm_set_in_rcu() check mt_in_rcu() so the test here
> could be removed.

Yes, you are correct.  Thanks.  I will rerun my benchmarks with this
change.

It's not a critical thing at this point since all the vma work is still
under the mmap_lock.  But it could affect performance.