Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Feb 2022 12:41:54 +0900
From:   Sergey Senozhatsky <senozhatsky@chromium.org>
To:     Aditya Garg <gargaditya08@live.com>
Cc:     "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "laurent.pinchart+renesas@ideasonboard.com" 
        <laurent.pinchart+renesas@ideasonboard.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
        "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
        "sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
        "ribalda@chromium.org" <ribalda@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        Orlando Chamberlain <redecorating@protonmail.com>,
        "paul@mrarm.io" <paul@mrarm.io>, Aun-Ali Zaidi <admin@kodeit.net>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple
 T2-attached FaceTime HD Camera
Message-ID: <Yfn9glTzki60IRFy@google.com>
References: <527C2E71-12E2-45D1-9B50-5A413B6920A1@live.com>
 <9BD1D373-F588-44EE-AFC0-3D691B4134DA@live.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9BD1D373-F588-44EE-AFC0-3D691B4134DA@live.com>
Precedence: bulk

On (22/01/31 09:12), Aditya Garg wrote:
> > On 26-Jan-2022, at 4:07 PM, Aditya Garg <gargaditya08@live.com> wrote:
> > 
> > From: Paul Pawlowski <paul@mrarm.io>
> > 
> > Adds the requisite device id to support detection of the Apple FaceTime
> > HD webcam exposed over the T2 BCE VHCI interface.
> > 
> > Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> > Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>

I'm not the maintainer, but the patch looks OK to me
FWIW
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>


Laurent, Ricardo, any thoughts?


> > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 7c007426e..88dc9e7aa 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> > 	  .bInterfaceProtocol	= 0,
> > 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> > 					| UVC_QUIRK_BUILTIN_ISIGHT) },
> > +	/* Apple FaceTime HD Camera (Built-In) */
> > +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		= 0x05ac,
> > +	  .idProduct		= 0x8514,
> > +	  .bInterfaceClass	= USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	= 1,
> > +	  .bInterfaceProtocol	= 0,
> > +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
> > 	/* Apple Built-In iSight via iBridge */
> > 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> > 				| USB_DEVICE_ID_MATCH_INT_INFO,