Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2802546pxb; Thu, 3 Feb 2022 15:00:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAljQPHn8rvTuEr3pLezxovO9KMW+EROZmgl2RfghHXR3BQ12eSDUJ1M0jXtII83bLKNhj X-Received: by 2002:a17:907:3d94:: with SMTP id he20mr90548ejc.637.1643929239958; Thu, 03 Feb 2022 15:00:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643929239; cv=none; d=google.com; s=arc-20160816; b=U0Q9I6JQcM/HGZSanEAzNhHnSiTBa1m/73BRuu0tNO5OFQeqnt+QsRv0/05HEvJT2o pIanHGlJ+BG9fHC0TrKBbwbOkBqYq9NnpcrdGk8L9XEWEy3oPrRmBq0gfFnSMG7CfPGT 6T94jBSxefYYpMqsLb+na2H9YaTzgaOAdDGPYINmvtTNc9y/G9uUegki1faYSMjInmhs 37KmB2BfqK0OUPcxeYc/iyfIWFlxaytYugpG9yuwrf2tU19fVDGgcTJJpfUR1PB68HQl 7Tq2AssFgUr2yaN6SbqE384WZQIBn6oI5q00FzJ8r4oFC7Fz1V7vkZFb5C15rphsi/dm BsHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=69oC9K6bP5zXfYZ3RPqGsmz6Po3E4WX3hDMRIgEHu/M=; b=PdjZV30NdwblEotn6/tB++u9HSVD/ZW8TSb6EZbBM8RR+MUaA1u3kNqXfGsEB+nIOM EVmldcBnYrCI+0xrTPj+HNlCd8BulmDqbsbFkiEz5jLXOOeYN3IQiyTpIvOk7SDHjze+ SRrpL1l1ns4xNNgWzqryly4Ns8wFegId1+wqARVUf59xJ1uSFjdh4D18jf05uMmV3pt/ MWWSG37wMTvFB39Yy0Op8ekWXAmAvQEMwPSDzoFmQIj+4jkcsDSXf6KYh48YjmtcuFSx zUEBTz3Qa2wn3PXkluEaW7ngHMfw4aDsREVaI5NOcWqGoDa2VDpST1165UzpjHtkKZ9f SD7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=prjLCJpZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9si64799edt.243.2022.02.03.15.00.13; Thu, 03 Feb 2022 15:00:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=prjLCJpZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349445AbiBCHmN (ORCPT + 99 others); Thu, 3 Feb 2022 02:42:13 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:42900 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241953AbiBCHmK (ORCPT ); Thu, 3 Feb 2022 02:42:10 -0500 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id EB1074019A for ; Thu, 3 Feb 2022 07:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1643874129; bh=69oC9K6bP5zXfYZ3RPqGsmz6Po3E4WX3hDMRIgEHu/M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=prjLCJpZBMzeFlAnt1Q3ZRFf7aCbx5PsJ08g/iKbO3OC6wcUqpUqU3dPnXe2UhPVW 3VtDaPDja5UFB+Jinv/PElCW4zpu/XWGzvwN63MEDUaw+3OQ+5SnGlEYZjLmXoodEk JOQw+tal7CoJGyMpCxfzDVAqU5No4yeVo8CwwK5Vf16pIEufwOq2WdtWz7TgEL3Mig RSSTSTGJSh8N4Q48bVwTqkEaipOIorwAd85P4gi5k37qeDoCTKugvexnQ0iYqNPbrJ TFgyew37GBJQ/1zYay1WMaaQsvcQh7VyMQw6O9hTk5Z9o7k+jesJHCCxoOYc8KUxpE etD8CKYXdfCwg== Received: by mail-ed1-f69.google.com with SMTP id h11-20020a05640250cb00b003fa024f87c2so1010305edb.4 for ; Wed, 02 Feb 2022 23:42:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=69oC9K6bP5zXfYZ3RPqGsmz6Po3E4WX3hDMRIgEHu/M=; b=fvADogSAXsQJrkeTyNTb8WnqZhuqvEinXenr4IdK4xwGVLALS+k1ldcdJvSqGyIRQT 4R0wuJxBDOV0gLcbWt4V8uZBduJlWrJp2ePkMy49KNza1GmQbtR80Sg9VfCLCNeWljhD u2/d5O3IuyEURewDdqyvSp+DvkyzDOwqbeLNUw5QMouQ1xqz89fTSYgLjtLgavPZC6BF r8+mDsaJfT0GNAJ/ox7qQet9butHNPruxXQZQTJ8LmfMMf7VRfhwZR3lTku+bDCpgKiv drOu5I34+b0PNJmM8cTA1huLCxBM1j/uQlXRXviKsMqhptUQbJKn86CbeIB1q/XPgN94 Z92w== X-Gm-Message-State: AOAM53343/ZH5FEaH4C4SBOp9o+eMTx4p2XS6QaGtXaPOmCzGgHz9RNO ZfztiOQeDU9bv4i+M93HyraUW6Q0bLhG18h7NOY2JrmNhcrwlDhHIzLRyIlzwX1tlXMlfsCSau2 1DubWuX9xaD5fDHP+K6+0wRvBL3PM/EYU7yr0+JrEIQ== X-Received: by 2002:a05:6000:10cf:: with SMTP id b15mr28156931wrx.70.1643874119534; Wed, 02 Feb 2022 23:41:59 -0800 (PST) X-Received: by 2002:a05:6000:10cf:: with SMTP id b15mr28156886wrx.70.1643874119363; Wed, 02 Feb 2022 23:41:59 -0800 (PST) Received: from [192.168.0.80] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id t18sm19832712wri.34.2022.02.02.23.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 23:41:58 -0800 (PST) Message-ID: <1d549a00-b9f5-d60f-2d5b-798e92139f86@canonical.com> Date: Thu, 3 Feb 2022 08:41:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] HPE BMC GXP SUPPORT Content-Language: en-US To: nick.hawkins@hpe.com, verdun@hpe.com Cc: David Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Russell King , Arnd Bergmann , Olof Johansson , soc@kernel.org, Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , "Russell King (Oracle)" , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220202165315.18282-1-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20220202165315.18282-1-nick.hawkins@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2022 17:52, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and Superdome machines) > It does support many features including: > ARMv7 architecture, and it is based on a Cortex A9 core > Use an AXI bus to which > a memory controller is attached, as well as > multiple SPI interfaces to connect boot flash, > and ROM flash, a 10/100/1000 Mac engine which > supports SGMII (2 ports) and RMII > Multiple I2C engines to drive connectivity with a host infrastructure > A video engine which support VGA and DP, as well as > an hardware video encoder > Multiple PCIe ports > A PECI interface, and LPC eSPI > Multiple UART for debug purpose, and Virtual UART for host connectivity > A GPIO engine > This Patch Includes: > Documentation for device tree bindings > Device Tree Bindings > GXP Timer Support > GXP Architecture Support > 1. Please version your patchses and document the changes under ---. 2. With your v1 I responded what has to be separate patch. This was totally ignored here, so no. You have to follow this. 3. Please run checkpatch and be sure there are no warnings. 4. Bindings in dtschema, not in text. Best regards, Krzysztof Best regards, Krzysztof