Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <222e01e6-bb00-51ee-a94c-089b43cbaf42@nvidia.com>
Date:   Thu, 3 Feb 2022 12:44:57 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: Weird code with change "mm/gup: clean up follow_pfn_pte()
 slightly"
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>, Peter Xu <peterx@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        David Hildenbrand <david@redhat.com>, Jan Kara <jack@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
References: <CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com>
 <6d38ed2a-72cb-3eb6-5af1-caee61d94005@nvidia.com>
 <20220203130137.GZ1786498@nvidia.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220203130137.GZ1786498@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDZsWUpOV1lEMDRpNEpZb0Y3eHdET2VBZCtGZ1dJZ3dKMmMwOWMxZW94Ukdt?=
 =?utf-8?B?cWxHUFVkbkM3Q2c1Qy9rand0bE94cENGdEV6eXBQUEpKNThPNkY0Nldld3A3?=
 =?utf-8?B?a2NoK3lqZFd4TllPY2ZDaWRqTFg5eTNHRFVCSXQ1OXRPdlBsVGxpcmxJWkdF?=
 =?utf-8?B?MnBuUGdTZ1lpKzBtMElFcExCaTFQQVBXbmVqMVoxektSclVFQXlqUXRvS1hQ?=
 =?utf-8?B?cUtGenhYK2lYdFI5QmFjQ1BITWZxYUdwdnRFZzFNcWRlSmlkSTRmTVhCU05Y?=
 =?utf-8?B?RWI0TFc1N2M4VU9HM2djZkVkd0E4anV5RFNmL1U0UlZIZWh3RE9sUkZaZkJP?=
 =?utf-8?B?UC9XTTZ1WC9DWVkzWHpYL1pjdFBSbGM4ajBsTXF4OGhFV0pBNmR6KzVzQlBJ?=
 =?utf-8?B?OW5kYlc1SW1pRG9oTVZLSW5xd1VZM01mZkJ0MjhVK0kyU1hJMjN6THNVcjlW?=
 =?utf-8?B?RTl3VHBGMjB2czRhZzhrUk1td0taeXpkQkh6bkloOElhaFhNdXdqNzNPYms0?=
 =?utf-8?B?c0o1eG1tK0JJOFNkU3B4NmxFbjZkQ2J3ekIrS0ZaTHZJMkRROVU3MzdGRjJQ?=
 =?utf-8?B?cm5MU0NpUGlwWFlJTzdoa2ZJd25SK1k1OUxaV0lOL0JuL3l2OEN0WEViaFY5?=
 =?utf-8?B?QU8xRHdGTWRNN2o3WDY3MEgxR3lyWEpWcEFBdFZsZlNCZEdSS2ZnLzZlNnha?=
 =?utf-8?B?dWR5Snl6ZlhjdUZrdjRyTTEyY080OE11bjNFVEl2c2dub2JGTUZQN29EYjc4?=
 =?utf-8?B?NEU3c1BGNlJMdXNobGwyQzBBYkc5OEVFb045aE9PZEpRNlQ0Ky9Yd0hlY3By?=
 =?utf-8?B?cE1rM2Y2ZjduV0tyUTkzR2g3RUNGRmUzbTRFTDlXOFA3VmVOdjdnTUhCYi9Q?=
 =?utf-8?B?OHdCVzIvOFhhMnlaZ1JrZ0xWUkZHYU1lSXZxazlwcENuVFVOb1F1ZEtHeUN2?=
 =?utf-8?B?UUlzbi9lVTQ0cW5URGtPUlkvSWNzRXdTMXlvNHV5cU9qVGs3MjRVSTl6QjVu?=
 =?utf-8?B?bEdVZ0NQMHJUQ2Vvbm9Mb01oOUIzcklDekh3bDRUaTAreCtWRVZJcDBCTjdz?=
 =?utf-8?B?Rnk4TVh5cC8ySkxEdkFrZ3FqMVk0am1LZ29DTkE5d3hKanZ6MGUxTW5OR3J1?=
 =?utf-8?B?UnE5N0o2aGx5TlFZMVZNQWdtQmVnbTNWN2k5N245VUhTcXhPR2t0WFl3NDRG?=
 =?utf-8?B?SGFwV0puS1cwUE1CRTdnNlZ5THZWMGFFZjBEVVlidlRkdmlZeW9LSjc1ZWZR?=
 =?utf-8?B?QmZ6S0xRMWJlbVdaeTZDWEJvZ1o2ci9GUFNqbExxTHYva1VEOVRhbi91ZEor?=
 =?utf-8?B?djFDb1EyZ1NWaVVRZlBRa3AxVXNHSGhubCtjcnlpSEZhSVhjbTJTOXQ5MjZY?=
 =?utf-8?B?dFF6WHAvRHlaQU0yNjB3VXl6dmIzem9TNldwdVlDeHNlTFB3T0pocGZjQUNK?=
 =?utf-8?B?ODZDUWlrV3R5OCtaeDhIcnZCeUM0UjBDNnRid010Y1cySU9qN1AzUlFyNTA0?=
 =?utf-8?B?d256S3RhandhaHExMVpYcDhxUWM4aHNkaCtWdWE5M3FSOS9EcHZrTVNKS3Zt?=
 =?utf-8?B?NGdaK0l0dmJUV3BlRVk5ZEQ1bGs2ek9ZVjJtaHdoV0w5MSthWEZYVGc4ZEVH?=
 =?utf-8?B?VWZjL2lUcTEreWFUQmdQcjVXVlA4K0N6K1BwaHR3RFpRWFlGaWVrTmtwMDA1?=
 =?utf-8?B?azNzbk1zZmwyZ29scGhyOVNKaW84WWpMVVBUL0gxNGdRL05DTXRndDlGNkNN?=
 =?utf-8?B?R1BVTzhkZ3lIdHVRVlo2YlZ2dGFCOEFIbldXdEEwZEFFQzQxaVJvTDcvMjFM?=
 =?utf-8?B?V0tKSnBRT0d4MWE0NVUzWTdCV1RpOGh5TlBBM3NneGRCdkJqMzNsbkRjM0FL?=
 =?utf-8?B?NHBubzB6YzlWUWQwWTNMVjc1TDFOL0l0OUMvT3p2WVg5MkNoVm4weGE3Q1ZL?=
 =?utf-8?B?ajU5Vkd6TmZoNERWUVlHSDA2U21aMGo5Vk9DNlpqU3pDbmpSZ1V2Y2RoQSt0?=
 =?utf-8?B?eGtITVN6SzRVYjNxZVZGSjB0czFkZHFVQ0ZhUW16N3dWUUZleXIyYUgzeUVI?=
 =?utf-8?B?MUh0dktvb2hoNjFOQlZHVGlQZ0VjS1FmNUt4NTgvdllkRFlVeFluRW05ZEZD?=
 =?utf-8?B?TmRkRkhXWG9jdHY0N2VoQTBENXlacDN4akI1YWs3RlBHZFJGY2ZEK0U0ak5n?=
 =?utf-8?Q?oY/pc268GebvQaS085w2LVo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f49a6f7b-bce3-40f4-9afc-08d9e7560b92
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 20:44:59.9027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uISKk1LJqQCA5Rs1gNL8GvFy9JGVIJmNiXJINJrsQ4/1165jsJnl+V4zBquq4WXa1egXmLEF1eORlht9pvX+jQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4750
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/3/22 05:01, Jason Gunthorpe wrote:
...
>>> In the new branch if (pages), you set page = ERR_PTR(-EFAULT) and goto
>>> out. However, at the label out, the value of page is not used, but the
>>> return uses the variables i and ret.
>>
>> Yes, I think that the complaint is accurate. The intent of this code is
>> to return either number of pages so far (i) or ret (which should be zero
>> in this case), because we are just stopping early, rather than calling
>> this an actual error.
> 
> IIRC GUP shouldn't return 0, it should return an error code, not zero.
> 
> Jason

Errors work for single pages, but GUP is a multi-page API call. If it
returned an error part way through the list of pages, then callers would
have no way of knowing how many pages to release.

With that in mind, the API returns the number of pages that were
successfully pinned, if that number is > 0 (or even 0, in some cases),
even when an error has been encountered.

__get_user_pages()'s kerneldoc documentation covers it. And I see now
that it needs tweaking to include the FOLL_PIN case, but anyway:

  * Returns either number of pages pinned (which may be less than the
  * number requested), or an error. Details about the return value:
  *
  * -- If nr_pages is 0, returns 0.
  * -- If nr_pages is >0, but no pages were pinned, returns -errno.
  * -- If nr_pages is >0, and some pages were pinned, returns the number of
  *    pages pinned. Again, this may be less than nr_pages.
  * -- 0 return value is possible when the fault would need to be retried.
  *
  * The caller is responsible for releasing returned @pages, via put_page().


thanks,
-- 
John Hubbard
NVIDIA