Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79022c90-674a-04d1-0de8-5738df5882b5@redhat.com>
Date:   Tue, 1 Feb 2022 14:34:02 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] mm/sparsemem: Fix 'mem_section' will never be NULL gcc 12
 warning
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Justin Forbes <jforbes@redhat.com>,
        Rafael Aquini <aquini@redhat.com>
References: <20220201192924.672675-1-longman@redhat.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20220201192924.672675-1-longman@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/1/22 14:29, Waiman Long wrote:
> The gcc 12 compiler reports a warning on the following code:
>
>      static inline struct mem_section *__nr_to_section(unsigned long nr)
>      {
>      #ifdef CONFIG_SPARSEMEM_EXTREME
>          if (!mem_section)
>                  return NULL;
>      #endif
>         :
>
> With CONFIG_SPARSEMEM_EXTREME on, the mem_section definition is
>
>      extern struct mem_section **mem_section;
>
> Obviously, mem_section cannot be NULL, but *mem_section can be if memory
> hasn't been allocated for the dynamic mem_section[] array yet. Fix this
> warning by checking for "!*mem_section" instead.
>
> Fixes: 83e3c48729d9 ("mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y")

Sorry, I forgot to add the line

Reported-by: Justin Forbes <jforbes@redhat.com>

> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
>   include/linux/mmzone.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index aed44e9b5d89..bd1b19925f3b 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1390,7 +1390,7 @@ static inline unsigned long *section_to_usemap(struct mem_section *ms)
>   static inline struct mem_section *__nr_to_section(unsigned long nr)
>   {
>   #ifdef CONFIG_SPARSEMEM_EXTREME
> -	if (!mem_section)
> +	if (!*mem_section)
>   		return NULL;
>   #endif
>   	if (!mem_section[SECTION_NR_TO_ROOT(nr)])