Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92a2ce30-5bdf-d6a0-cb97-f375411eab16@quicinc.com>
Date:   Thu, 3 Feb 2022 17:21:31 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 3/4] input: misc: pm8941-pwrkey: add software key press
 debouncing support
Content-Language: en-US
To:     Stephen Boyd <swboyd@chromium.org>, <dmitry.torokhov@gmail.com>
CC:     <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <collinsd@codeaurora.org>,
        <bjorn.andersson@linaro.org>, <skakit@codeaurora.org>
References: <20220203010804.20883-2-quic_amelende@quicinc.com>
 <20220203010804.20883-4-quic_amelende@quicinc.com>
 <CAE-0n51WVcbvgRrbi84JWDYAciXrz0LyHHym2VLXhiz_hoX7sg@mail.gmail.com>
From:   Anjelique Melendez <quic_amelende@quicinc.com>
In-Reply-To: <CAE-0n51WVcbvgRrbi84JWDYAciXrz0LyHHym2VLXhiz_hoX7sg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/3/2022 1:20 PM, Stephen Boyd wrote:
> Quoting Anjelique Melendez (2022-02-02 17:08:07)
>> From: David Collins <collinsd@codeaurora.org>
>>
>> On certain PMICs, an unexpected assertion of KPDPWR_DEB (the
>> positive logic hardware debounced power key signal) may be seen
>> during the falling edge of KPDPWR_N (i.e. a power key press) when
>> it occurs close to the rising edge of SLEEP_CLK.  This then
>> triggers a spurious KPDPWR interrupt.
>>
>> Handle this issue by adding software debouncing support to ignore
>> key events that occur within the hardware debounce delay after the
>> most recent key release event.
>>
>> Signed-off-by: David Collins <collinsd@codeaurora.org>
>> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
>> ---
> 
> Is there a Fixes tag that should be here? Is it a new problem with newer
> PMICs?

There is no Fixes tag since this is a workaround for a HW bug. Yes, this is a relatively new problem
with the past few PMICs. Starting with PM8450, we need this workaround in pm8941-pwrkey
since we are no longer using an older downstream driver that had an equivalent work around.