Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76703db31c4562dba1301e839c70381cf8e403b3.camel@ew.tq-group.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65: disable optional
 peripherals by default
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Jan Kiszka <jan.kiszka@siemens.com>, Nishanth Menon <nm@ti.com>
Cc:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 03 Feb 2022 14:06:20 +0100
In-Reply-To: <e427670b-0570-df33-c114-fd0633ac1d44@siemens.com>
References: <5beef188724ef42b0c2147ca9bf6e6ca25c75dec.1641900122.git.matthias.schiffer@ew.tq-group.com>
         <20220202203217.sf2cr4orwl4usvyf@starry>
         <e427670b-0570-df33-c114-fd0633ac1d44@siemens.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-02-03 at 12:39 +0100, Jan Kiszka wrote:
> On 02.02.22 21:32, Nishanth Menon wrote:
> > On 12:25-20220111, Matthias Schiffer wrote:
> > > All peripharals that require pinmuxing or other configuration to
> > > work
> > > should be disabled by default. Dependent DTS are adjusted
> > > accordingly.
> > > 
> > > The following nodes are now "disabled" according to dtx_diff and
> > > were not
> > > overridden to "okay", as they define no pinctrl:
> > > 
> > > k3-am654-base-board:
> > > - mcu_i2c0
> > > - mcu_spi0..2
> > > - cal
> > > - main_i2c3
> > > - ehrpwm0..5
> > > - main_uart1..2
> > > - main_spi1..4
> > > 
> > > k3-am65-iot2050*:
> > > - mci_spi1..2
> > > - cal
> > > - ehrpwm0..5
> > > - main_spi0..4
> > > 
> > > Signed-off-by: Matthias Schiffer <
> > > matthias.schiffer@ew.tq-group.com>
> > 
> > Jan: you ok with this series? Please ack.
> > 
> 
> Just rebased the still-too-long backlog to our system fully working
> over 
> mainline.

Thanks for testing. As noted earlier, I will send a v2 of this patch
that fixes one more inconsistency.

> Basically looks good, but this might be a regression of the 
> patch:
> 
> [    1.810083] OF: /bus@100000/pcie@5600000: phandle pcie-mode@4070
> needs 1, found 0
> ...
> [    1.854840] OF: /bus@100000/pcie@5600000: phandle pcie-devid@210
> needs 1, found 0
> 
> Jan
> 

That seems to be an older issue, rather than a regression of this
patch:

k3-am65-main.dtsi defines:

    ti,syscon-pcie-id = <&pcie_devid>;
    ti,syscon-pcie-mode = <&pcie0_mode>

While according the driver binding docs something like the following is
expected:

    ti,syscon-pcie-id = <&scm_conf 0x0210>;
    ti,syscon-pcie-mode = <&scm_conf 0x4060>;

I assume that the k3-am65-main.dtsi section was imported from ti-linux
without accounting for the mainline driver's different binding.

Matthias