Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7108583e-d495-809f-9530-63dbd5e15179@amd.com>
Date:   Wed, 2 Feb 2022 11:07:17 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v3 3/3] KVM: SVM: Extend host physical APIC ID field to
 support more than 8-bit
Content-Language: en-US
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
        pbonzini@redhat.com, joro@8bytes.org, mlevitsk@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        peterz@infradead.org, hpa@zytor.com, thomas.lendacky@amd.com,
        jon.grimm@amd.com
References: <20211213113110.12143-1-suravee.suthikulpanit@amd.com>
 <20211213113110.12143-4-suravee.suthikulpanit@amd.com>
 <Yc3qt/x1YPYKe4G0@google.com> <34a47847-d80d-e93d-a3fe-c22382977c1c@amd.com>
In-Reply-To: <34a47847-d80d-e93d-a3fe-c22382977c1c@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2xGWkswNUhaK2t1T3dWbFNBU0dWQlBIWG1oVVRQT2NpbnNqdDUvZXZGTm1z?=
 =?utf-8?B?SkF1cWJQTFN5UUd1cjgzQTJ2TnpvWjNQYktZd1RZSW9lZXp1b2h3TUMwTDFa?=
 =?utf-8?B?TGJHbmpjTSs2UDJzTnlqOWV3Wm96bzUySlEreFQrbTY3SXJyZjNjRElpemRh?=
 =?utf-8?B?MUtvS0lNcVdEdmxRWmlXcXdlZTByWUVDOHFwS3BxS0lsb1JzeDUvdmZYZml3?=
 =?utf-8?B?dVZoVGpSRk53OWl6bHRGbXY1aVcydVlqR3VnMHFQN3MxU0NJUk5BTVkyOUN4?=
 =?utf-8?B?ays5M0pFREl4aUFjUU5CdkNvcWVaQmxkS3VLVWR3Z3N5U3JXV1lGZE9QdllL?=
 =?utf-8?B?b3RZQVdsSDVRVHhZcmo5cjRhd3FSbmtOL2tJWHVQY21VT3JNWm9DL0ZBOVQ1?=
 =?utf-8?B?NWlRSXFSUDBSeUxBRkdTaXI1MnlPMG90N3VRY2c1NUtFR01KL0hkMWI0MlNv?=
 =?utf-8?B?TVFIRzNCZWd2STAyYWFzVWFnR3J4V0pQQk1nR3VJMXNYZTJVY0JRZE5UaGtZ?=
 =?utf-8?B?cU42SHlpbGd2Y1ZmL0JrUDhUbk9QVUMrTktvaW12T0RKYVAwY2w2eURxMW5R?=
 =?utf-8?B?WHJVUTRHSjNONE9IbUxSQTh3aWlST0l5ZVpZOUhZUnBBZUxaRzJyQVhIZTVr?=
 =?utf-8?B?Zm0rNzdZeXFrZ1g0cXhqcjlsVEUyTTZCaitOejFTSWg1REZkUk1GQ3ozMXhC?=
 =?utf-8?B?TDFoTHJTY0hRUGpsYlJ0dUFrZlV4clB0U1o5ZGdPMVRtM0hmUlNJUzRoajhE?=
 =?utf-8?B?OUtETk5yWWZXK0tjdzJLRXNWVWZPejhRMjdJUitNa20yc2dkcnJIS3ZWSFRI?=
 =?utf-8?B?N0hqR3lJQ2dCVUtZdVVTbFFlUlhSUVJuRDA4YjFxZ0R5K0diZnpiY1ZOeDlC?=
 =?utf-8?B?d3BEVjUwQ1IrVy9RMjl0ZXZIdEF0bmloR3lMODIzZkJEbk0vWDJFY3hGWkxS?=
 =?utf-8?B?cWlseWlzam40NTcrejkvUWJOaU1wYUdydm51RHUxUW9scFBqdkJmSnYrOUdV?=
 =?utf-8?B?OXJ4Qk5HcjlONU1pcE40QUxIY0MxdWhMNlRkRGM5WUNFbnRpbWFWakQ1amZE?=
 =?utf-8?B?UVNzeUhoZU1Wc296SGFrWWJqOGh0cjRXU0VtS2hOUVZkaVF4bFFkaFE5S0Q2?=
 =?utf-8?B?MmFhQzZrMEY4T0V5bGFhcWk4T3p2VzNjRlZ0d2I2U05sNGFIZ24vSmJxMzZD?=
 =?utf-8?B?Q1NwMjliUk9XaFZhekNRbTVqS1kra05KaXhxZWJvZEdiWnFhSjJVMGxpTG1P?=
 =?utf-8?B?MGttUk9uSGNOelVFcjlwb2JoK3VkSkp2Nm8vNU0ybGx1Wm05eWpzbVhDcmJF?=
 =?utf-8?B?NG1mRDljQlVOZXFQam83ZUN3alhsTFNxZjk5OEdKRU1SbFlzZGlmOTJ6T0U1?=
 =?utf-8?B?NXpjNmtmWUVVcUxFcHl1SklaNW9EdXU1SnNrNytIRm9GWk9ycVFuaGRKaFFI?=
 =?utf-8?B?VU9scTRobW1GV3lQWTRHWXJ3OGdveVlLbDVuemx1NUhjakw4Vi9ocmJZbkpp?=
 =?utf-8?B?WUdTNXRPTnovMUxwRTFUTlp5M3hWRTlBZkQ1ZlF3bkNvUllzUGZwQ0l1M0M0?=
 =?utf-8?B?RlBZbVVxUzhBSmcvU2laem1ZV2ZTZFlkNlBEcE5ad3hHZkl1bVpoNmkvWjlD?=
 =?utf-8?B?TkhuWURpc2FKeFZORzZYQlB3M21iL2hsTnhTOGxQV1d3ejNUam53RTMwdlIw?=
 =?utf-8?B?Umh3MTB2V2tvR0VmdVJxMVZXZDBPc3dmKzQ1Mk1JZHBGY0R4bitZUWdQOE9M?=
 =?utf-8?B?QWFZK3FlcVMzbXdvdEhENFhjZXJHU1laQ3JGeGhHTXJYdStlR1JFemhvRHpn?=
 =?utf-8?B?TExSemY5SkxuVG5uMGtXVVBQRkd2ZFVsNy9ZdXA3bjdNUEc4TktwV0I0cWlY?=
 =?utf-8?B?OUhUWnVMdW5ZSWJzTmRML2tzRjUzZGdZR1VMZFhDZ2tjWGRmMnR2VVVBUHh4?=
 =?utf-8?B?bFR2cWhLNDIvL1dud2dsTXc5NTBvMWFvMVBKc3JUdnVvRGR2V0F0cTVlcnlV?=
 =?utf-8?B?aU5pdDhaWkFLWnNGb3dRbUdVRld3K2JVb0ExeTR6dlNWczhqUEIzTjBtUFRk?=
 =?utf-8?B?MllSZlBvdmtJaXV0NkdpL3IxNXlVdHFPVDc4aUxzOEZCS1R4am5nSU9PUmxo?=
 =?utf-8?B?NlcrdEtDZFhqZXdMN2pudFJUdUNOeUt2WW45TVVCS2c3YVh1a2JBaVBCTFhM?=
 =?utf-8?Q?87X/atauZoxgjZ+Va82ZF7M=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c56252c-0307-4478-c78f-08d9e60187ad
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5452.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 04:07:30.3595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sBDj5bO1u50Qk0hUJjlavwLtMmSd7rovM1nVdN3VxjU6KPC7xeGVIghshOtfKOu0tBPVU8w+UKzpI/zqDh1xTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2732
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/1/2022 7:58 PM, Suthikulpanit, Suravee wrote:
>> Anyways, for the new larger mask, IMO dynamically computing the mask based on what
>> APIC IDs were enumerated to the kernel is pointless.  If the AVIC doesn't support
>> using bits 11:0 to address APIC IDs then KVM is silently hosed no matter what if
>> any APIC ID is >255.
> 
> The reason for dynamic mask is to protect the reserved bits, which varies between
> the current platform (i.e 11:8) vs. newer platform (i.e. 11:10), in which
> there is no good way to tell except to check the max_physical_apicid (see below).
> 
>> Ideally, there would be a feature flag enumerating the larger AVIC support so we
>> could do:
>>
>>     if (!x2apic_mode || !boot_cpu_has(X86_FEATURE_FANCY_NEW_AVIC))
>>         avic_host_physical_id_mask = GENMASK(7:0);
>>     else
>>         avic_host_physical_id_mask = GENMASK(11:0);
>>
>> but since it sounds like that's not the case, and presumably hardware is smart
>> enough not to assign APIC IDs it can't address, this can simply be
>>
>>     if (!x2apic_mode)
>>         avic_host_physical_id_mask = GENMASK(7:0);
>>     else
>>         avic_host_physical_id_mask = GENMASK(11:0);
>>
>> and patch 01 to add+export apic_get_max_phys_apicid() goes away.
> 
> Unfortunately, we do not have the "X86_FEATURE_FANCY_NEW_AVIC" CPUID bit :(
> 
> Also, based on the previous comment, we can't use the x2APIC mode in the host
> to determine such condition. Hence, the need for dynamic mask based on
> the max_physical_apicid.

I recheck this part, and it should be safe to assume that AVIC HW can support
upto 8-bit (old platform) vs. 12-bit (new platform) depending on the maximum
host physical APIC ID available on the system.

I'll simplify this in v4.

Regards,
Suravee