Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Feb 2022 09:01:37 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>, Peter Xu <peterx@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        David Hildenbrand <david@redhat.com>, Jan Kara <jack@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: Weird code with change "mm/gup: clean up follow_pfn_pte()
 slightly"
Message-ID: <20220203130137.GZ1786498@nvidia.com>
References: <CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com>
 <6d38ed2a-72cb-3eb6-5af1-caee61d94005@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6d38ed2a-72cb-3eb6-5af1-caee61d94005@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hFvQfYNAuPa1Ssf/vSu1qFj/cfZuWC2K14Nd6VljzOE1DREiFOEygQUiaM7R?=
 =?us-ascii?Q?uS9XJaJMAQJ2oH+VIkozFrG7QA6Clh4Pxy5SB/IH1kE+UD2082M5H7uKZ1kY?=
 =?us-ascii?Q?l6IsoZlUEYTftK3+O6ZjFddOPdfXQwfhkEwIBU3jZaHQVLHcdcjPClBLSNGv?=
 =?us-ascii?Q?xPossRD0n9hfJLvrSN8fsFUbytw1IrUkclBpQTHalfP4CQ0HhbNB4lw5Et2V?=
 =?us-ascii?Q?jin3GDWaByA+nOalKK5bQ3BaSFOn8NXKF86ggz1yswz7U2DXYD1UyaDhCSCk?=
 =?us-ascii?Q?2LMAzHGRrr59zzadYXgbe8bmqeqsBoP/TZ1vqN1Sj6xJh+7GiRELhLnK8I9B?=
 =?us-ascii?Q?h8g6VC8Nj94MepkA4mbvSHgX/g/76HF6T93N5AcGrvs+dK/CduKbr4nw0Xe9?=
 =?us-ascii?Q?ceKBs0wp01EoX2DX1GZtt6D0hvuFrz+a0ARHHe/c9XXBcMzOD6N3Y7p7x8H+?=
 =?us-ascii?Q?N/ly+UF3TASDAUxjcBuKR9tBZdsXsBsoAkCtBkJ/uD2+ydHolx4Tvg6YBOuf?=
 =?us-ascii?Q?vy6aFWZKcMCbx1K51rIuHTUtIV0hxLaueWpLviYSWKmCdK359BERhz1EdKzm?=
 =?us-ascii?Q?WNMliIcX8VwIPGifVMX/K6K3IGEVMANIE3FHMAO57oO+8rae0rR3jblIi8DI?=
 =?us-ascii?Q?vvG2OHJpfzCHP+EtPbDwjElvkPH7/oktGyMkdTBDXp37BY8Psi0w/6yg0/7p?=
 =?us-ascii?Q?oTbrCUCiZpeyUggJXQ/y6wZjVZcMnofmLg2aPm5rFSNlnMrEts+0/lvLOP+Q?=
 =?us-ascii?Q?atg45pAMQXr9u+KrKtabYr52A24F7Fk38ovhDrhYlWss3OyLqcdnPNpsBnEA?=
 =?us-ascii?Q?PvTPiiSGtm9pQJlvuefoUI2TkhEkWiPKdXukDdnIYI2FwgRzgQf3vSdqkmkp?=
 =?us-ascii?Q?7PNuu04ixCotPBS0QWXC634orqQzt/iY2mAhJy7ngu8J/liiAzQVsP8pHbLL?=
 =?us-ascii?Q?giMUladghw0Scy6SS5KsnhitbmD1v/xyZBq418hARW3TkS0cOY5V5IzfcWKT?=
 =?us-ascii?Q?FYVeFyWSRQPE+fsIfXTjuXql2wg9zhS/eDUJexeVIp4JDuQH3bs7TbWqBvYH?=
 =?us-ascii?Q?8tR/QgEUSTyx4osf6hCudVgKQQXZ6CDMHzg+gboV+5AuBxkmBQSbLS5Lf1nm?=
 =?us-ascii?Q?fWLU45r5c+ckGA6oSGgLxIdqhP5R/8MvVJ7NabiP7yorT6hiiRmcUTt6o7ig?=
 =?us-ascii?Q?+oPbPpYiX0Of9SueO2Iae0NGLSoSwWa+5zZ+4J4gwzc7soRoX2NuDAhMbDex?=
 =?us-ascii?Q?JHkjVqiDc9wZuEzE9uRKhReO925VjwSPLardUn9HPRgbB7y/0CP2a2LPIu16?=
 =?us-ascii?Q?vPlPUqsMfU7PkbopDXJucufhlhidnmlYBDIg/mjyRS23rQIv9cru3RpFYTk2?=
 =?us-ascii?Q?zHhf/pTTjEPPFgRQUC5eOaevgQEIEiEaScvjUvNQjvUIiu+4l0DPs+17FJwg?=
 =?us-ascii?Q?tIJ+dwNVU7476jcKRLO+rifngAllh7BQZ23a2v+Roh/LAXuqJ3uFxRnnPhbI?=
 =?us-ascii?Q?46y2duRX/BmGKnVS5TejQT6sa/e7N4XqUmSpZ67oD9ztectM7uvc0Hrhu+ur?=
 =?us-ascii?Q?95SAAAGpQSg5D6C98UM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee1c8fc-29a6-4cf7-e3e5-08d9e71550af
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 13:01:38.4763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nf9laW/eqtf5A2ERymuR2drngwifNwsCfgRJF+1G9S4goq78lUw5N4gvMJ/vYJKl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3775
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 03, 2022 at 12:38:33AM -0800, John Hubbard wrote:
> On 2/2/22 22:27, Lukas Bulwahn wrote:
> > Dear John,
> > 
> > Your change "mm/gup: clean up follow_pfn_pte() slightly" (see Link),
> > visible in linux-next as commit 05fef840b5c6 ("mm/gup: clean up
> > follow_pfn_pte() slightly"), is somehow weird.
> 
> Well. That sounds like something to be avoided. :)
> 
> > 
> > In the new branch if (pages), you set page = ERR_PTR(-EFAULT) and goto
> > out. However, at the label out, the value of page is not used, but the
> > return uses the variables i and ret.
> 
> Yes, I think that the complaint is accurate. The intent of this code is
> to return either number of pages so far (i) or ret (which should be zero
> in this case), because we are just stopping early, rather than calling
> this an actual error.

IIRC GUP shouldn't return 0, it should return an error code, not zero.

Jason