Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20211215160403.69264-1-carsten.haitzler@foss.arm.com> <20211215160403.69264-6-carsten.haitzler@foss.arm.com>
In-Reply-To: <20211215160403.69264-6-carsten.haitzler@foss.arm.com>
From:   Mike Leach <mike.leach@linaro.org>
Date:   Fri, 4 Feb 2022 10:36:45 +0000
Message-ID: <CAJ9a7Vj+f5p+mYsnot3=kRtsf-aGY99PX6Uy0FmWeN0WrwOphQ@mail.gmail.com>
Subject: Re: [PATCH 06/12] perf test: Add tests to re-use the thread loop test
 to check aux data
To:     carsten.haitzler@foss.arm.com
Cc:     linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
        suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
        leo.yan@linaro.org, inux-perf-users@vger.kernel.org,
        acme@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Carsten,

On Wed, 15 Dec 2021 at 16:04, <carsten.haitzler@foss.arm.com> wrote:
>
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> This checks to see that the thread_loop tests produces sensible
> amounts of aux coresight data.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> ---
>  .../tests/shell/coresight_thread_loop_2.sh     | 18 ++++++++++++++++++
>  .../tests/shell/coresight_thread_loop_25.sh    | 18 ++++++++++++++++++
>  .../tests/shell/coresight_thread_loop_250.sh   | 18 ++++++++++++++++++
>  3 files changed, 54 insertions(+)
>  create mode 100755 tools/perf/tests/shell/coresight_thread_loop_2.sh
>  create mode 100755 tools/perf/tests/shell/coresight_thread_loop_25.sh
>  create mode 100755 tools/perf/tests/shell/coresight_thread_loop_250.sh
>
> diff --git a/tools/perf/tests/shell/coresight_thread_loop_2.sh b/tools/perf/tests/shell/coresight_thread_loop_2.sh
> new file mode 100755
> index 000000000000..6d790b870a67
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_thread_loop_2.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Thread Loop 2 Threads
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="thread_loop"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="2 20"
> +DATV="2th"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 724 11 11
> +

The only difference I can see between this test and the set of tests
in patch 05 is the verification script run on the output file.
Is there some reason that both scripts cannot be run on the same
output file, rather than rerun perf ?

Regards

Mike


> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_thread_loop_25.sh b/tools/perf/tests/shell/coresight_thread_loop_25.sh
> new file mode 100755
> index 000000000000..cce74202e4db
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_thread_loop_25.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Thread Loop 25 Threads
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="thread_loop"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="25 2"
> +DATV="25th"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 388121 1255 1255
> +
> +err=$?
> +exit $err
> diff --git a/tools/perf/tests/shell/coresight_thread_loop_250.sh b/tools/perf/tests/shell/coresight_thread_loop_250.sh
> new file mode 100755
> index 000000000000..55f271462a4d
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight_thread_loop_250.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# Coresight / Thread Loop 250 Threads
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="thread_loop"
> +. $(dirname $0)/lib/coresight.sh
> +ARGS="250 1"
> +DATV="250th"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 724 11 11
> +
> +err=$?
> +exit $err
> --
> 2.32.0
>


-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK