Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54be0878-a7da-cc8a-3efc-1bb0c53caf47@acm.org>
Date:   Thu, 3 Feb 2022 08:53:40 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] scsi: ufs: disable auto hibern8 while entering suspend
Content-Language: en-US
To:     Alim Akhtar <alim.akhtar@samsung.com>,
        'Hoyoung SEO' <hy50.seo@samsung.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, beanhuo@micron.com,
        asutoshd@codeaurora.org, cang@codeaurora.org,
        bhoon95.kim@samsung.com, kwmad.kim@samsung.com
Cc:     'kernel test robot' <lkp@intel.com>
References: <CGME20220125062155epcas2p15da28303164091b1bf5a00dcf99fe59b@epcas2p1.samsung.com>
 <20220124180637.160524-1-hy50.seo@samsung.com>
 <40986ecb6c81812a1e1ab24d93e46eda75974c4e.camel@mediatek.com>
 <12a201d81892$c8123d40$5836b7c0$@samsung.com>
 <066101d818ca$5dba71f0$192f55d0$@samsung.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <066101d818ca$5dba71f0$192f55d0$@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/2/22 22:50, Alim Akhtar wrote:
> I am not sure, if this problem is generic and faced by all other UFS vendors.
> If not, how about having a vendor specific call back for your platform only?
> Just a thought.

I agree with the above. Since the code change does not follow from the 
spec, it should be guarded with a check for a new quirk flag.

Thanks,

Bart.