Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Feb 2022 16:41:48 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     Miaoqian Lin <linmq006@gmail.com>, bp@suse.de,
        daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org,
        tzimmermann@suse.de
Subject: Re: [PATCH v2] drivers/firmware: Add missing platform_device_put()
 in sysfb_create_simplefb
Message-ID: <Yf1JPCD1L4qt0T2c@kroah.com>
References: <735d2b47-227f-f09d-ddd6-28bc82a066a5@redhat.com>
 <20220116121654.7730-1-linmq006@gmail.com>
 <259abc88-58ac-9101-21a1-5130168fcdac@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <259abc88-58ac-9101-21a1-5130168fcdac@redhat.com>
Precedence: bulk

On Sun, Jan 16, 2022 at 06:31:09PM +0100, Javier Martinez Canillas wrote:
> On 1/16/22 13:16, Miaoqian Lin wrote:
> > Add the missing platform_device_put() before return from
> > sysfb_create_simplefb() in the error handling case.
> > 
> > Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > Changes in v2:
> > - Use goto label to avoid duplicating the error code logic.
> > ---
> >  drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Does not apply to my tree :(