Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c5ffe29-d3d3-2955-cf78-ad275110f012@amd.com>
Date:   Fri, 4 Feb 2022 09:59:45 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 6/6] drivers/node: Show in sysfs node's crypto
 capabilities
Content-Language: en-US
To:     Martin Fernandez <martin.fernandez@eclypsium.com>,
        "Limonciello, Mario" <mario.limonciello@amd.com>
Cc:     linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, linux-mm@kvack.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        ardb@kernel.org, dvhart@infradead.org, andy@infradead.org,
        gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org,
        akpm@linux-foundation.org, daniel.gutson@eclypsium.com,
        hughsient@gmail.com, alex.bazhaniuk@eclypsium.com,
        alison.schofield@intel.com, keescook@chromium.org
References: <20220203164328.203629-1-martin.fernandez@eclypsium.com>
 <20220203164328.203629-7-martin.fernandez@eclypsium.com>
 <67d2711b-200c-0894-4ff7-beb3eb304399@amd.com>
 <CAKgze5YM2+BRjj2nvb+_dnuCg5WtWvQ6FQyNYJ1c8G6Orn=aQw@mail.gmail.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <CAKgze5YM2+BRjj2nvb+_dnuCg5WtWvQ6FQyNYJ1c8G6Orn=aQw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uy9GcTZrTi9aUUgwcDNSQUVDMExtWWt5ZHBTNkhHeEl4ZjU5M3dVcDNua3RX?=
 =?utf-8?B?YmUyRmVrZGZWbkIzVnFpRHludmNNVmNPZTNubWR6RGNRVWxwTDFZdFMvM2ky?=
 =?utf-8?B?cGhSNWlkVW5SRmVsbElLcmxSNTJsRTdRWDA1SmRSTkp0dXNVNlJWTDRXaVFl?=
 =?utf-8?B?OWpsUEVLaDg1WGxlbExZQ2hGY0podkJtMlpVdjdNRnIzSHRRQjIxcE4reGVU?=
 =?utf-8?B?OFkwT3YvRFVTTTJmTkwrTFRCNTQzRU56OW5vcUY1eEVFcWNJclpFSmZKbUxl?=
 =?utf-8?B?RC8vRFFPQXl1RjFHSEdGR2Vmb3cvR1dFaWVxZ1d6ekRZTEtlOVZiRVExL2h0?=
 =?utf-8?B?UTM0NDJ2eVhwbmJoZlFlSy92NWQ4VnIxK0VCYWNXTmt2SVZPeW9pUEdRVDVD?=
 =?utf-8?B?VmFTcnN4U3FUMXJVSjZ6MFJCbXA4YmE1ckpXdzVwYXlkOGR3Q1VnRmZWS0c1?=
 =?utf-8?B?L3JzQ3Z6Qk9NanEzSURkdll0Q0s1S1djejFXR0xpMkRld0Q3dUFvbVpUSnJh?=
 =?utf-8?B?eEl6bDkvRzV1d091NWU4QnlKMTBtYVJVeGNkRW9EY3NneEZEb0FkK3dTSE13?=
 =?utf-8?B?dGFTblpUb0NVWm9vNjhSdkhnVXhVT1Q4ZkJQS1hGUGVhcThiWGVNYTFTUTFK?=
 =?utf-8?B?WHlSUHlzWldnVTVKd0VGUWI0bHExdTR3U2YxUG9DTWZ2eTh4WTBrSlJZTFFo?=
 =?utf-8?B?b0xaMkZqLzV3NzdjVGVteDdNd1ZEeFNxMm1tNXN3YkZJUEQ0a2NJazhhelk3?=
 =?utf-8?B?L1dvckV1ZjZhWW4zUDJOVDU5T2ozOWU2Z255cW1BbW42eVNrUUlLaG5oWWRP?=
 =?utf-8?B?WG9PREZtd0VCbFhEdFdPcEpXbG1SZ05sQTZQNlFCclV1UE1FMVB2ejYrYUh3?=
 =?utf-8?B?eTZKeG1rcVpkejFWYVl5cFk4UmZ1dllrTkVuVzc3YUk3bzZSZTdLTGhKeklm?=
 =?utf-8?B?OXpUNVMzaDdYWFlhQ3lBaFNFYi85M1gzSzZYY3E3bnBuQTBLcVJha1kycWpa?=
 =?utf-8?B?eFdNelkwRFV1VS93U1lNSW56WmV3MkNabktRSkg2UUhtY1B1MVBCVGRMbFIw?=
 =?utf-8?B?YnpKaytUU0w4dTZuSDJGV2xicERmM0VrMEFWcS9VZkpBNHRHeDQ5RkFFb3Vy?=
 =?utf-8?B?djdNZllad0wwcHVyeTlUVlgyVm9hZVMwQWlqOUFCSUNzYlEralYzYmdsUk1r?=
 =?utf-8?B?bW9QRUk5ZWhxRmdkWmY0Y1ZUSHRGVmd3S256Kzl4dmdxaDFJR0d2emxYQ2JV?=
 =?utf-8?B?V2VwZDRZaTZHeWdJRXB4QmMyM3R6U2VyVjBNL1Z4Zm01STVicEs4ejkrNGtY?=
 =?utf-8?B?UFlvc3RlZFVpL2lRUUJ1MWtnYVZmVXVTdWh2Z2ZhOEpoU0ZxZzFvQU84UmEw?=
 =?utf-8?B?aDVlU2dCMXM2UUszK2JEQzJteG9kUG9hRlZ5MnhIWC9ZdXZ5TDREWm5qK0M3?=
 =?utf-8?B?NktOaUZTZkFXWUhXcThrb0xJVHZsN0xCSHY4OG83T3JEV3huSXFEZXhvN3M3?=
 =?utf-8?B?R0xFeWhOczJIcnZscUk0Vk1NaS9McWlvcDRwNFJNbmM5RHFlNEtUV2NCL051?=
 =?utf-8?B?TlJEOFovZ2d1U3VsQTVHWG4veURZdFNXUzlReThhQ0ZqeTlGV0NobUNtL3Bx?=
 =?utf-8?B?RW1TTXBmMXlIVWpiT29idUl6QzNvRVZkcTlCOGpKZE00MXpqdUdiUUY3NGc3?=
 =?utf-8?B?aWFOanFqZkRZUEtlMmhRWnEvVkIrNkdlcmFpOHZFcHoxVldRREFqb0Y3YzFk?=
 =?utf-8?B?Ylh3K21HbElueUsvd2lTTElRRUxSU1cxR1ZDUjd4UlpFT0xVZy9XUWhRbkgw?=
 =?utf-8?B?NHlKNFMxQlRjMUxrekFBNEFBekJjdWJObStQekhic09TdUN6N0hSbFEwNEFI?=
 =?utf-8?B?YUFPOHMwb2JMbHZydC9sTmpmdXdjVU8xMjlRUktoUXlpb29VcThjWlJMMzFB?=
 =?utf-8?B?R2dEbWxRUVpHcFZoUWFxbjVqSlRuUXNlT2ptZHVQRGYvbi8zT2h2ZUFMTjZW?=
 =?utf-8?B?cWhlVjhTUXhCd2ZaYnZaRTBEWFJ1RGpBRzNVZEE0LzJUVUVhZzZuazlVeEV0?=
 =?utf-8?B?ZnhDM0MzRnpBYy9WbjlUa2Zmc3RrMjhDYkNkcS9lMktNVUpjcXVkZlhCZzZh?=
 =?utf-8?B?eG9aOEd4MEUzaUdjZTcvV0NINUcyeWdhbGFLZDF2WE5BUGhWb0lnZnk2c2lL?=
 =?utf-8?Q?Mg2BfGWpnYIOPmacf3K/w6w=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99e20ead-b041-476e-a16b-08d9e7f75f25
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5221.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 15:59:49.2468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gLwjjlnCPto7JMdh7O6pns+6DRl/YixKceyFcW+FchMBhi/kOixdgXyfrczk6Vwb0elQPgF23wy9pzDECh1uuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3708
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/4/22 07:21, Martin Fernandez wrote:
> On 2/4/22, Limonciello, Mario <mario.limonciello@amd.com> wrote:
>> On 2/3/2022 10:43, Martin Fernandez wrote:
>>> +static ssize_t crypto_capable_show(struct device *dev,
>>> +				   struct device_attribute *attr, char *buf)
>>> +{
>>> +	struct pglist_data *pgdat = NODE_DATA(dev->id);
>>> +
>>> +	return sysfs_emit(buf, "%d\n", pgdat->crypto_capable);
>>
>> As there is interest in seeing these capabilities from userspace, it
>> seems like a logical time to also expose a `crypto_active` attribute.
> 
> I planned to do something similar to this, but to show (or actually
> hide if inactive) tme in cpuinfo, just as Borislav Petkov suggested a
> few versions back.
> 
> https://lore.kernel.org/linux-efi/YXrnkxgdjWbcPlJA@zn.tnic/
> 
>> Then userspace can make a judgement call if the system supports crypto
>> memory (`crypto_capable`) and then also whether or not it's been turned
>> on (`crypto_active`).
>>
>> `crypto_active` could be detected with some existing support in the
>> kernel of `mem_encrypt_active()`.  This will then work for a variety of
>> architectures too that offer `mem_encrypt_active()`.
> 
> I need a hand with this, I grepped for mem_encrypt_active and nothing
> showed up...

The mem_encrypt_active() function has been replaced by 
cc_platform_has(CC_ATTR_MEM_ENCRYPT).

> 
>> As it stands today the only reliable way to tell from userspace (at
>> least for AMD's x86 implementation) is by grepping the system log for
>> the line "AMD Memory Encryption Features active".
> 
> Isn't enough to grep for sme/sev in cpuinfo?

No, it's not enough. Cpuinfo shows a processors capabilities and not 
necessarily whether that capability is being used.

Thanks,
Tom