Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3576060pxb; Fri, 4 Feb 2022 11:28:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyH8bYofz8o9d3XtnJiUPNP6EvbA1W1X8hJLg8umIBlx7atRPXTv+NN0g+AvjXNR21T1NOg X-Received: by 2002:a17:90b:4f87:: with SMTP id qe7mr4850852pjb.141.1644002914409; Fri, 04 Feb 2022 11:28:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644002914; cv=none; d=google.com; s=arc-20160816; b=DiRZBFxLptPt5lFIE73yWkxmc1968iLODuuGOGAYix1ZUENY7VfDIBkSZRtkXyM2D3 kibl9R2jPw7bQAGs3VMNX4rJwZSTx2S5kbHI6//OplGQhxr81Fcq6QRZPmtdEvop4RKO FkxVR3bOQSldJ96r7e13m0UTy+tk6nwYiifsvz7AwazQsIbzd4hOTNzq+JTqFxBPXIl3 CsucGeztt9WPbGYTZ7vpuWFcUYhCGX4nPDaefYUo7/mYDycdT2jV8WfAXEQlMDGep6Fo gCm+aaNb71peVTWIz4ZTTTfAgQ7+jbB8BMknyvjduemDDc0rDjMa45mJ/05oYArkw7D5 TZtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=TTYD7A710n89LQ9vI0o0t1Jd/yr3/XBLKa8FSQDU288=; b=pFbSl/xYHJrsrqIHw4FE4HEtT+56vYQzv3BNCAh0175dGS3UTbzrPjgbF3VRvuCU7+ ew33QnNcsHeJB1+WjHgYsPwCsldVA/PI6vdI4NJ0pzvub909ZkTTq+qwzTxg+RGvvdGt HxbAryjWChtixtnkOacpyvuIwQHqs8GGsJMeFBtWYkBYkt5dfoR/DDzPSJWB4dtijmht 3Q5JOBwqIFUMu4bU1XG5KB0oxtOf3508ihocNrVU6oGHga+ivWKlDTnVswdyIg4hobNZ A3hFwmCZL3pToq+7UBXAYq604d6DKbXtbiBG7eicqyZhDTr8e7FB5uEAY40cO4bcA8bJ 0aFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si3017040plh.441.2022.02.04.11.28.19; Fri, 04 Feb 2022 11:28:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358662AbiBDMS4 (ORCPT + 99 others); Fri, 4 Feb 2022 07:18:56 -0500 Received: from relay3.hostedemail.com ([64.99.140.33]:6281 "EHLO relay3.hostedemail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355405AbiBDMSw (ORCPT ); Fri, 4 Feb 2022 07:18:52 -0500 Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CDA3723327; Fri, 4 Feb 2022 12:18:46 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA id 90F8A2D; Fri, 4 Feb 2022 12:18:11 +0000 (UTC) Message-ID: Subject: Re: [PATCH] HPE BMC GXP SUPPORT From: Joe Perches To: "Russell King (Oracle)" , nick.hawkins@hpe.com Cc: verdun@hpe.com, David Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , Olof Johansson , soc@kernel.org, Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Fri, 04 Feb 2022 04:18:24 -0800 In-Reply-To: References: <20220202165315.18282-1-nick.hawkins@hpe.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.74 X-Stat-Signature: sr19sijeo6q79z8ey9jcj9w15gn7bijc X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 90F8A2D X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/fXooa1LZuZOlkfFu/TpMmSAbR8ShcuZI= X-HE-Tag: 1643977091-269336 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote: > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@hpe.com wrote: [] > > diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile [] > > +static irqreturn_t gxp_time_interrupt(int irq, void *dev_id) > > +{ > > + struct gxp_timer *timer = dev_id; > > + void (*event_handler)(struct clock_event_device *timer); > > + > > + > > One too many blank lines. > > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) { > > + writeb_relaxed(MASK_TCS_TC, timer->control); > > + > > + event_handler = READ_ONCE(timer->evt.event_handler); > > + if (event_handler) > > + event_handler(&timer->evt); > > + return IRQ_HANDLED; > > + } else { > > + return IRQ_NONE; > > + } > > +} It's also less indented code and perhaps clearer to reverse the test if (!readb_relaxed(timer->control) & MASK_TCS_TC) return IRQ_NONE; writeb_relaxed(MASK_TCS_TC, timer->control); event_handler = READ_ONCE(timer->evt.event_handler); if (event_handler) event_handler(&timer->evt); return IRQ_HANDLED;