Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3602980pxb; Fri, 4 Feb 2022 12:07:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0cCkjCuGjjq/Kcswbu3zZ+zYsTv91kwVRLnCZ2TEVQrfVowVUACLUKMwE/yrK5PMEtDQa X-Received: by 2002:a17:907:d14:: with SMTP id gn20mr484133ejc.49.1644005274924; Fri, 04 Feb 2022 12:07:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644005274; cv=none; d=google.com; s=arc-20160816; b=NKxqA6aGetazOifQp6JBTJXhbuAZUZv4DvEG43MQnxbeTcqwPpYzo4DqzCLjQWfKb7 UGaBf1s/EgEbxUplnZXIpP7YQNEbAsPgVpcbruExH8yzjhWKuxYbRtJAjEaYiU8NH/om DbZl2VnHjmFfY+bPkMtLa7M23zVgPPlrR/fQU+LfT4P3h2qWY1ppN47BfUYbLEnklk34 MsDAwtfF9w2LD76EzJfjgID6ov5gsD17OjpgkXLWemEqzz9lkeienE5rbxgX8DaAcYiX jBRZ07xLBTN13EeCe9JL7ClikNbFb0rhZhPgfGSZ75IQfpK8R3c3oym64yI2R9YKC0U6 RrBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4Ca9I/sAMzQIMCAYXBkIkytKRwdb7KuHMc9w1XGE+7A=; b=szG8i4relWgi+EkK6KaIEZY5LzeU+6o4mOH0qrro3GxjndQw9Lb/Z3jlE6gIRE2BHu n6pflGn9bAaVdvhJBTG8SOUwCDODcDD16o5P2W6QyucYzvFJ4qw2ARSGTAIHyyL3L/Al Ha+HUKpAkWdTaUbrpidqtZvPl+RJZ4EL2OyfaVrjyR8oIIbDxFw0HrvWxOCxWzg2d4I8 YdpX66dAUp3TCAUpQ5XKibFDLpD0bVhsd4VPl/KAco9POAEJ0IPcm9HhPogFA4+vMAar 0ev4DGwFD3MjQY1kz8EfVpZhQNiwD9IdroR/fFkPiG5eE50O7aovkwZHv52dm/JRnLwS DvsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0N30fHOe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g3si2204091ejt.122.2022.02.04.12.07.29; Fri, 04 Feb 2022 12:07:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0N30fHOe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358872AbiBDNdj (ORCPT + 99 others); Fri, 4 Feb 2022 08:33:39 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:42488 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356417AbiBDNdh (ORCPT ); Fri, 4 Feb 2022 08:33:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4Ca9I/sAMzQIMCAYXBkIkytKRwdb7KuHMc9w1XGE+7A=; b=0N30fHOeJKKiEmBzHSSAjOwTCo NpvFMTne+ReR7L/rMoQIq2d5/1hRKjsDPqIORGjajQW+UTS2E2q3Z/w61nDp6gVZ6OVzpiYsw2EyW pLoL11FZdneTXfJN6pJjgvs7Ay984ejA0+yx0g4+Hjhydr9jhY9l2gbt/i994/BsW7lk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nFyhL-004Gxv-Fm; Fri, 04 Feb 2022 14:32:23 +0100 Date: Fri, 4 Feb 2022 14:32:23 +0100 From: Andrew Lunn To: "Russell King (Oracle)" Cc: nick.hawkins@hpe.com, verdun@hpe.com, David Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , Olof Johansson , soc@kernel.org, Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] HPE BMC GXP SUPPORT Message-ID: References: <20220202165315.18282-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > It's normal to list all linux/ includes before asm/ includes. Please > rearrange. Hi Nick Since you are new to the kernel, please let me point out, you should consider Russell comments for all your code, not just this one file. Many of the comments are generic to code anywhere in the kernel. So it would be good to fix the same issues in the rest of your code base before submitting them. I would also suggest that when you start submitting drivers, submit just one or two to start with. You will learn a lot from the feedback you get, and you can apply what you have learnt to the rest of your code before you post them for review. I would also suggest you spend 30 minutes a day just reading comments other patches receive. You can also learn a lot that way, see if the comments apply to your own code. You will also learn about processes this way, which can be just as challenging to get right as code. Andrew