Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3607831pxb; Fri, 4 Feb 2022 12:14:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsvnkkZEll9SPpFz0mqyGURzmNmZTDP0CqwtHiDFq+Pyq4h6aDCe+XySoW54XdSeznAfpz X-Received: by 2002:a17:90b:4a41:: with SMTP id lb1mr5118468pjb.151.1644005657016; Fri, 04 Feb 2022 12:14:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644005657; cv=none; d=google.com; s=arc-20160816; b=UILTH94CzlQfe94stJdVyII0IfAHA8lgjk9yxnFOwCT2OTgV2LXhOu2T1RjaxYahDy NvL83d3YkD1T4ogc5d6olKly1wsCuwTWAbJjUAAlJOw6iQWjEaJ+UO6+3V+D+L/z4w70 Xy7rnD/GLlpHoOZFHkK/b4oboacylpCXsa457ifMsth2TrKEgbzays2bZduATmZO9WqT DFdyMaGB5C/w6YnQJqw0ackvgS5Te+tl+eyHgAnnYUU/n/qTvFn5384CJPU/78Yjh1XK jMC7w9JHsh1MK5nCe8jI7tdzNZHkkITAcqaUHzej3eBpcxrcgUD2X+pOXSvf3oqF/6ww ZwAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=MlC6uuAkhdySzV2FqH3X00l8X5hzQKz1Xvjq6btdC2I=; b=O8Kv47nU0cO2RG/P67zSku8l9/tvDNNOzTCTIZzoKJKiVq4EuwoThHAJBo/3w+LB75 67pF2F3y30L4WmJE2fNANnDLXl78osQKbu5CaAt+HLdwIlXuQowi0UEZ3Tcga7MeYsSG zQuLcmvXksALdSSUjJI+YYvgXQHWoECWqZMgwe2ynzDgxqU2vvPewT82Qf2XjeEJ5THz RhOleENgjY7IjupRLz5mLVHThg7uY6mgA5WjAAI03ib9LfRuNS6TcQzNgW/lUP2Gs3w7 wmtdn8poy3Z8abRYwqj7ZN6vm4P6IQoEwy1RRFvspDgAizolfinfe0G74bFryYBfiYgi akJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f187si2860889pgc.312.2022.02.04.12.14.05; Fri, 04 Feb 2022 12:14:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235895AbiBDMCU (ORCPT + 99 others); Fri, 4 Feb 2022 07:02:20 -0500 Received: from foss.arm.com ([217.140.110.172]:39440 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbiBDMCS (ORCPT ); Fri, 4 Feb 2022 07:02:18 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A003F1480; Fri, 4 Feb 2022 04:02:17 -0800 (PST) Received: from [10.57.88.9] (unknown [10.57.88.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A782A3F40C; Fri, 4 Feb 2022 04:02:15 -0800 (PST) Message-ID: <0c235c48-49b3-42ee-f65b-0043b599bcd3@arm.com> Date: Fri, 4 Feb 2022 12:02:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2] coresight: trbe: Move check for kernel page table isolation from EL0 to probe To: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mathieu Poirier , Mike Leach , Leo Yan , Anshuman Khandual , coresight@lists.linaro.org References: <20220203190159.3145272-1-sudeep.holla@arm.com> From: Suzuki K Poulose In-Reply-To: <20220203190159.3145272-1-sudeep.holla@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2022 19:01, Sudeep Holla wrote: > Currently with the check present in the module initialisation, it shouts > on all the systems irrespective of presence of coresight trace buffer > extensions. > > Similar to Arm SPE perf driver, move the check for kernel page table > isolation from EL0 to the device probe stage instead of the module > initialisation so that it complains only on the systems that support TRBE. > > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: Leo Yan > Cc: Anshuman Khandual > Cc: coresight@lists.linaro.org > Signed-off-by: Sudeep Holla Thanks, I have now queued this. https://git.kernel.org/coresight/c/ebbce265bba164c4f0d5271c277a540bd3b2fd3c Kind regards Suzuki