Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 5/7] usb: dwc3: Add snps,ref-clock-frequency-hz
 property for ACPI
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Robert Hancock <robert.hancock@calian.com>,
        Baruch Siach <baruch@tkos.co.il>,
        Felipe Balbi <balbi@kernel.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Balaji Prakash J <bjagadee@codeaurora.org>
References: <20220127200636.1456175-1-sean.anderson@seco.com>
 <20220127200636.1456175-6-sean.anderson@seco.com>
 <CAHp75Vc--RYW7P0wLA8Jcr53xKSkphJV=wTeZiPC-AYu4sGYFA@mail.gmail.com>
 <2c1832a5-1e13-1423-2be8-e31b5ec5195a@seco.com>
 <CAHp75VfGFNFqOU0BymNwh_FWKVw+rSyJJRDSKOinWY_Z39qaGA@mail.gmail.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <928f7c83-281c-b995-1bf5-be35b7539de6@seco.com>
Date:   Fri, 4 Feb 2022 13:44:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <CAHp75VfGFNFqOU0BymNwh_FWKVw+rSyJJRDSKOinWY_Z39qaGA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1Jyc0FzWHROU2VTQWlacDlHNGhXd285SXBvTFhJbytOM3dZTG9zWk5ZMExn?=
 =?utf-8?B?bjR5ODkrWjhEdnJsdlJrUlBRK0YxdHFUS1JwWlpDcXkvTmxodFN3eXBlVHV2?=
 =?utf-8?B?dmpOemhEdlJnWk1jUkMwejY0N2Y1czlYSmcxM0F0R29oZVI1eGZVQjVOMktL?=
 =?utf-8?B?R2wxa1RiV29pUFZDS1lndTRvZWVVM2dIVTIrTjVsYjZvZFZhWGtTTElKT1Yz?=
 =?utf-8?B?NmhkY2VGVzkvWHdqaHF3bjF2clBuOWh3ajdZV2VoZVd0VFRDZ3lQZ1BsRi9w?=
 =?utf-8?B?bjlRMGVZR0hPdGY3cmFKS29BUU53Sm45VDQrSmZmUFV1cDhraWszSlRWbXpP?=
 =?utf-8?B?U0FqT1hxcUhFc0lSWVpjbXJWbThZRkt2dEdLNFBQN1JlL3N3azYzZFNyY3F1?=
 =?utf-8?B?Qkg4RnJqRXdsZXlmOC9hZEpzbnlLejNhaWFsN2xPdldSTTRhZXVOdkh4ZCsv?=
 =?utf-8?B?RUg0SHhYaUJCM09lWkJpZ0ZLb1k5MkVlaTR1MEZDNVJvWkYzMlQyd1RmYlFW?=
 =?utf-8?B?Mlc5MWxSUkFURWVnOEhSUHVUeEZCVkZIS1YxQUJ2WjgzRUdidmtFNytaR2JF?=
 =?utf-8?B?Mk43RENwMlE1Y1E1cmdPMzRaM2psT3krS0RCWW82WGZEY0d2NFFhcE12Z1V3?=
 =?utf-8?B?Umo3QXBDMWZTTUJ6c1FlTGNobmc3Z3E3ano4Tk92ZVZuV0xrbDhQTk1qZTZp?=
 =?utf-8?B?ekVESUlaYmtWZVp4VlVhamF6azdxQnpXSjNMTjRqanZSbytwRGFjRHhraHVz?=
 =?utf-8?B?N2ZSNFd2OG5odFdIcUNEeDFVM0d1emUwSEd3Vi9XZmdCdzFqbkkwWjd1U29Q?=
 =?utf-8?B?VkQ5NTdjR3Z1SGJ4TURCLyt0WGM1VnRxQlhDM3JzMDFHM0NXM3B1cG9iSUkw?=
 =?utf-8?B?T3VWUzdhYkRSU01jOGFkOHZSVU9ZOXlXdUdOLzQrb0U5MXJxVkM2RldiN2pR?=
 =?utf-8?B?YU9hYndxaWNQOXVYTkhRSWRJcVBqYjdBY1M4WGZicStzT2w1ZXJycUFqNVI3?=
 =?utf-8?B?R09iVWhRZ3UwMWVmY1VGY1FvaldKWmZ5VXRPVW5TbXQvMUV1R2VTRmVDVGZT?=
 =?utf-8?B?UThFdHVOYjFGbzFoQU9PaDJ1ZXFtUTlXc21tSkUvUDV4TFU0aU1mZXd0SkFO?=
 =?utf-8?B?RDJOZUViK0Q3OTlUbExuTGpaR1YrUi8zWVpueDNiQldpd3EvUWxiRTJ0WVVN?=
 =?utf-8?B?MnVvdjFDWDZPREd5amFsSGRzeHZ6Z0NoQU11RDR2cFdMUGdQeS9PT21jN2du?=
 =?utf-8?B?SU9od1YrUTN5eEJ6U0NCb0xQVXROeFpzTHQzUjNXWGgrVkhPcWhCMGEvcyt4?=
 =?utf-8?B?K0pIVW1pbVN1VyttVnl0d0QrSzh3ZTd2Vnc4VTlNek12TDFUakQvTW1xUDJM?=
 =?utf-8?B?SzAwbTFMY2ZwNm5RSEMxTG9hT2RHcWtKUHU2cnhTMU9lb1kvYlp4NWFsUm5n?=
 =?utf-8?B?TVAxNlFpMEl4c2l1cUQrWmMrb2FqS3d0S0pJTDJheVNaV1pCbld0TGNzYjdQ?=
 =?utf-8?B?dFhmZHk3dXliQW9KRWFtVGNzcThpeXh0R2tQVGMzTkpEa29OTTZEU1dLam0x?=
 =?utf-8?B?ejk3S1JCZ05Sc1lSOURST0N0QkZTeWNNVjQ3VHRQZXM5RGZDRWoveURNNzVI?=
 =?utf-8?B?M0hYTXh4cEJ1NEVFR2w2YUNXSlFWa1RCQVRvU3FFVW9sM0hzYUZSTHo0RE4v?=
 =?utf-8?B?aHozSDY4YWVoRElpUTFPM0N3OGY0bXpKS2N6V0VmSER3UFBVMEtnYTgrY3dv?=
 =?utf-8?B?cEg1UnJ3VVB5ZTZQeFFjb09veDk5aHVSb09XdVplQ0x3L0VhdDkzcjVkL3E4?=
 =?utf-8?B?cGROdUZybHNPQXRDUFc0WS9WcWY5SDBrdW85N0d5SWc2cTkwRzVwL0l1QzVo?=
 =?utf-8?B?clV5MFRNbUlmSUFxdXBSbS9LVU85SGFlZ1JwRHdDeThKRVNXOWhhR3VKblU0?=
 =?utf-8?B?NSs5SG9vT00xTW90RmRrWlF2T0VwSVNPc2VVYmhMaE9iNTN5L0V3ZzdTZzVx?=
 =?utf-8?B?RUprTERZWXIxMUUvd0RuejRqOEJ0Nnl1QS9ZN1VSdUl4OVQ4WmthZEo1OXlG?=
 =?utf-8?B?VEtyUUtiMnB0SURUVzQveWZTajNwbkJwNjU2a3ZSU0tjZlFkZmNVMnpFMzZz?=
 =?utf-8?B?c1FOdU96Wm4xZHFnbGFjWFUvZ2YzaU9QNzRjYWtVMnJpWWJJQjdqMGRzSlpW?=
 =?utf-8?Q?02s1FBsHgWi7DxsoF35Vn+M=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15f25442-ded6-42e3-d6c3-08d9e80e67e3
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 18:44:42.1994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: agSYMPOllem6twZgerMIA/jdfr6iq6NmFwY3m43H34kgVIG0E8dzqGHkAdrVOiMnkYde7Q+gZMdafvsze7CF5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3706
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/4/22 1:38 PM, Andy Shevchenko wrote:
> On Fri, Feb 4, 2022 at 6:00 PM Sean Anderson <sean.anderson@seco.com> wrote:
>> On 2/4/22 7:54 AM, Andy Shevchenko wrote:
> 
> ...
> 
>> > On Thursday, January 27, 2022, Sean Anderson <sean.anderson@seco.com <mailto:sean.anderson@seco.com>> wrote:
> 
>> > Is it function or interface clock?
>> >
>> > We have standard property for the functional clock rate, I.e. “clock-frequency” (in Hz), can it be used here?
>>
>> I believe this is a "functional" clock. It it is a reference for the USB
>> signals. I'm not sure exactly what the purpose of this clock is, since I
>> do not have access to the databook for this IP. I considered using
>> "clock-frequency", but I am concerned about ambiguity because there is a
>> second "suspend" clock which is also a "functional" clock. The latter
>> clock appears to be used when the PHY is shut down (and not necessarily
>> corresponding to Linux's notion of a suspended device). If it is
>> necessary in the future to configure that clock on ACPI platforms (e.g.
>> to set GCTL.PWRDNSCALE) I think it is clear what the property name would
>> be (snps,susp-clock-frequency-hz).
> 
> In order to have more or less unified APIs in the future I would
> suggest using 'clock-frequency' for the "main" functional clock. For
> example, 8250_dw uses it for the baud rate generator, while it also
> utilizes auxiliary clock(s) on some platforms.
> 

OK, I had a look though that driver, and it seems like it uses
clock-frequency only for the baudclk, and e.g. apb_pclk has no
corresponding frequency property. For this driver, it would mean that
the suspend clock would only be configurable through device tree. Is
that the approach you recommend?

--Sean