Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbXBJCbu (ORCPT ); Fri, 9 Feb 2007 21:31:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752656AbXBJCbu (ORCPT ); Fri, 9 Feb 2007 21:31:50 -0500 Received: from cantor.suse.de ([195.135.220.2]:52280 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbXBJCbs (ORCPT ); Fri, 9 Feb 2007 21:31:48 -0500 From: Nick Piggin To: Andrew Morton Cc: Hugh Dickins , Nick Piggin , Linux Memory Management , Martin Schwidefsky , Linux Kernel Message-Id: <20070210001906.21921.45798.sendpatchset@linux.site> In-Reply-To: <20070210001844.21921.48605.sendpatchset@linux.site> References: <20070210001844.21921.48605.sendpatchset@linux.site> Subject: [patch 2/3] fs: buffer don't PageUptodate without page locked Date: Sat, 10 Feb 2007 03:31:44 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1440 Lines: 42 __block_write_full_page is calling SetPageUptodate without the page locked. This is unusual, but not incorrect, as PG_writeback is still set. However the next patch will require that SetPageUptodate always be called with the page locked. Simply don't bother setting the page uptodate in this case (it is unusual that the write path does such a thing anyway). Instead just leave it to the read side to bring the page uptodate when it notices that all buffers are uptodate. Signed-off-by: Nick Piggin fs/buffer.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) Index: linux-2.6/fs/buffer.c =================================================================== --- linux-2.6.orig/fs/buffer.c +++ linux-2.6/fs/buffer.c @@ -1698,17 +1698,8 @@ done: * clean. Someone wrote them back by hand with * ll_rw_block/submit_bh. A rare case. */ - int uptodate = 1; - do { - if (!buffer_uptodate(bh)) { - uptodate = 0; - break; - } - bh = bh->b_this_page; - } while (bh != head); - if (uptodate) - SetPageUptodate(page); end_page_writeback(page); + /* * The page and buffer_heads can be released at any time from * here on. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/