Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <682714ab20540935c972adfa9304482ba6999a0c.camel@linux.intel.com>
Subject: Re: [PATCH V5 1/3] platform/x86: Add Intel Software Defined Silicon
 driver
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Joe Perches <joe@perches.com>, hdegoede@redhat.com,
        gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
        srinivas.pandruvada@intel.com, mgross@linux.intel.com
Cc:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Mark Gross <markgross@kernel.org>
Date:   Fri, 04 Feb 2022 09:01:07 -0800
In-Reply-To: <71d3f97b4d4937b6e57772a56603766be7dd1ac8.camel@perches.com>
References: <20220204053046.2475671-1-david.e.box@linux.intel.com>
         <20220204053046.2475671-2-david.e.box@linux.intel.com>
         <aa16191c1241473fbfd55995bbba37bd2ab4a41c.camel@perches.com>
         <372f76f7b1b7cf3d0ca38a7a84bcc23322ff12ed.camel@linux.intel.com>
         <71d3f97b4d4937b6e57772a56603766be7dd1ac8.camel@perches.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-02-04 at 06:01 -0800, Joe Perches wrote:
> On Fri, 2022-02-04 at 05:23 -0800, David E. Box wrote:
> > On Fri, 2022-02-04 at 02:14 -0800, Joe Perches wrote:
> > > On Thu, 2022-02-03 at 21:30 -0800, David E. Box wrote:
> []
> > > >   - In binary attribute handlers where ret is only used for errors,
> > > >     replace,
> > > >               return (ret < 0) ? ret : size;
> > > >     with,
> > > >               return ret ?: size;
> > > 
> > > I think this style overly tricky.
> > > 
> > > Why not the canonical:
> > > 
> > > 	if (ret < 0)
> > > 		return ret;
> > > 
> > > 	return size;
> > 
> > I can see not using the 2 parameter shortcut of the ternary operator, but
> > the
> > regular 3 parameter expression is easy to read for simple operations.
> 
> The issue to me is it combines an error test and error return
> with the common return.

Ah, okay.

> 
> it's also being used and avoided / naked with the similar
> 
> 	return min(ret, size);
> 
> https://lore.kernel.org/lkml/20211116121014.1675-1-zhaoxiao@uniontech.com/T/

Thanks.