Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3701179pxb; Fri, 4 Feb 2022 14:31:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJybibNPpAX9cr5GJKLo1CKjgz3cx8kzqIi4kmwXsF4jEqt731qlDhtggy5kIKzyvtOx4HV1 X-Received: by 2002:aa7:dc05:: with SMTP id b5mr1391705edu.197.1644013877196; Fri, 04 Feb 2022 14:31:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644013877; cv=none; d=google.com; s=arc-20160816; b=KzBysRpCNskxl4xxYWpzlf3Awz/SXkBfKlOVc2GA5bdYSJDvz755bj4/FHEHErQqwg a/zN2hOH+T+0PW2f2J1RJnIqR3Xt0kpy0aia04KhCXC2v97dhz18fxX2jLjxlYsZ8KP+ 8IMsDkL6nDTVlriiXwiFPtBdnthvlTTGPkSFUMwlgOI9QUIboUGA6btoE5IbYi7ze7tZ GGrkaIeVRqMjqgcvXD+sAsfPc+z5hMlro1A3i5Zn+xWf/9pfKTBZ7Ej3SpdQepMQNfzR Ij6SWStjT2tugKJ+PKDgeu4wqjFlTrCFxRd79JFa5Ew8irpSMGCu9ZyorZqn7fpnuwJy WniQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mzxF9rMeHdGHwkTPDimCxRmilWqf6MiwMi9qg5Sr64g=; b=Q4TVGzSttoX99kAtI5ZZ4OZrbV0ncBN0alfbswpkfNqYuOfedsBoXCkQ8F/OZB5cbS P+eEcM6MWxZfPBuQryVVYoUmhbyBIMEHmoEqJGHc2KmM4MM92BBoHz6vUMtOy78LXpcC oQjnc46a66RfzUpeAduFYSQXYkloOQzRr+j/Y5fs9p+MUj1F2m0LirWMS6eNLKlJKdw8 megoxwOvFZW6bNYi3Bx6iB+aKVu7ZMn4wZ4tvTCQLpKcHbcJttXdYiz/kE9Zqx7kipB2 TJ8WYCEFxVmCyW/5NICpq8HWhg0sOIHAZar3rzzqBj2m6wOzaj5wiQ8XFlxwniDixzrB c7Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=vl3i11hF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f18si2455980edd.434.2022.02.04.14.30.49; Fri, 04 Feb 2022 14:31:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=vl3i11hF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358832AbiBDMbz (ORCPT + 99 others); Fri, 4 Feb 2022 07:31:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234861AbiBDMby (ORCPT ); Fri, 4 Feb 2022 07:31:54 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 883CDC061714; Fri, 4 Feb 2022 04:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mzxF9rMeHdGHwkTPDimCxRmilWqf6MiwMi9qg5Sr64g=; b=vl3i11hF8iQy1h0Ag1YRBLQAG7 dAUWYNtSwGnV/h/3SZGvDI79vCb1IEbbtu1UQ3FfZta2TTQ2uI3cfSWVhx6A7bIW/Wj5SVNcGD6XY 418/0rcrILwiuHAWq2bEWrG3CtJrTzBtQ1S0fQbDDKu7PuyDjJWcpusaTPiE+f8BhmPgO0W9dxqG4 ANF4a80aclwToWxEzEbz1ZbszC59Wpan34MN2z1REh6gVUGqTNlsaxyfNT/K03UeG6PDgF8dQPSMY lB6C1Kf71mwm4Og/bizKfCFlky7D1xuMSKf6R6BoJmtueaOi3urC0I9J+3NpAOum1WYjEIoCK3VOg bTdYh5bg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57040) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nFxk9-0004Zj-N4; Fri, 04 Feb 2022 12:31:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nFxk2-0004yb-7L; Fri, 04 Feb 2022 12:31:06 +0000 Date: Fri, 4 Feb 2022 12:31:06 +0000 From: "Russell King (Oracle)" To: Joe Perches Cc: nick.hawkins@hpe.com, verdun@hpe.com, David Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , Olof Johansson , soc@kernel.org, Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] HPE BMC GXP SUPPORT Message-ID: References: <20220202165315.18282-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 04, 2022 at 04:18:24AM -0800, Joe Perches wrote: > On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote: > > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@hpe.com wrote: > > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) { > > > + writeb_relaxed(MASK_TCS_TC, timer->control); > > > + > > > + event_handler = READ_ONCE(timer->evt.event_handler); > > > + if (event_handler) > > > + event_handler(&timer->evt); > > > + return IRQ_HANDLED; > > > + } else { > > > + return IRQ_NONE; > > > + } > > > +} > > It's also less indented code and perhaps clearer to reverse the test > > if (!readb_relaxed(timer->control) & MASK_TCS_TC) This will need to be: if (!(readb_relaxed(timer->control) & MASK_TCS_TC)) > return IRQ_NONE; > > writeb_relaxed(MASK_TCS_TC, timer->control); > > event_handler = READ_ONCE(timer->evt.event_handler); > if (event_handler) > event_handler(&timer->evt); > > return IRQ_HANDLED; > > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!