Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Feb 2022 21:26:07 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>, Peter Xu <peterx@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        David Hildenbrand <david@redhat.com>, Jan Kara <jack@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: Weird code with change "mm/gup: clean up follow_pfn_pte()
 slightly"
Message-ID: <20220204012607.GQ1786498@nvidia.com>
References: <CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com>
 <6d38ed2a-72cb-3eb6-5af1-caee61d94005@nvidia.com>
 <20220203130137.GZ1786498@nvidia.com>
 <222e01e6-bb00-51ee-a94c-089b43cbaf42@nvidia.com>
 <20220204004541.GL1786498@nvidia.com>
 <c0f57bfc-d34b-a34b-4f2d-0d66782e4ae7@nvidia.com>
 <20220204010612.GO1786498@nvidia.com>
 <afedd0c6-23c0-7e79-3b14-48fffaed7f99@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <afedd0c6-23c0-7e79-3b14-48fffaed7f99@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HW/shb3/aKJjqi0j30HixqchMf0DHWdQpBa+xzOrJPg7OQ3ZFFv9qQaN/Fk6?=
 =?us-ascii?Q?QBqyiJ0mt3cuVgDdxSiexlSXKccLU14qmNz+ejgZdIyyQ22PtrSxWpgT0BSD?=
 =?us-ascii?Q?0A07ab600trxjaMzY3GinabtYDUeqvF8KC9AF5T+nhPwiRq981PXNDD7A3RR?=
 =?us-ascii?Q?Eh5DSUn961MpMCjjh/V8QX0SQhQ++lOobpmrfSGO7xmYJW/qxxYpm8q8p3i6?=
 =?us-ascii?Q?LXrL563SNYYZYwjJMxgDXZCR7ObOPfAb5sPqx4unFXAe4+s0X8yUZDdzMiRE?=
 =?us-ascii?Q?WJ4qkJEFX27MqxjrcJH26KdiN0+DKXs0kcoKYzwLKH9ByK4f0LcpsHQTmSWt?=
 =?us-ascii?Q?KqRBKwt8zxUNSggXMFX3ipBcSYsBSOoANKCxewx1lnGRRA8FwnETX0nzEHP5?=
 =?us-ascii?Q?A5g5ril4qthamq3hZTx7HblhYrMu3XiN28NUyee7xGzBIeCPAW1GRuQDRSth?=
 =?us-ascii?Q?0ZLdi59pizpAlePMh5/6aHup6Fk28iMk14JzdVc4ZlLwFrrmO3VUVm802f/t?=
 =?us-ascii?Q?9JVt8qlqVNcYttuaBvS/yIKGDpKO/AAL2ZcP2Rpo2cWM8g9ORpTMfFbUyaOF?=
 =?us-ascii?Q?aMM1qXppNACgwEthlE68z7n+9xuk2/f6EJAg7EdZteBlvlOY269PKT/o3dks?=
 =?us-ascii?Q?2QWpghjep75SadDq7dG713sxYM08T22tdsHvBcmVP8wCWsUssUlvl4o9ohLF?=
 =?us-ascii?Q?YB3FgQZ/u5CpfFzDMnzlg0ZY/zH17Ubx/jWKgYcl3EMFWAxV5nx4F+ScQ79f?=
 =?us-ascii?Q?QxivWq+ovxD5j+9kSCYz9CQ+uvMPZp5GOHhXtdSu0I87E4+Dk7t86DnanNtF?=
 =?us-ascii?Q?737k9pALp1ECS04G6AB1OmmUUZ/l3IFG5MXPuJC8bVvMKHkdxx/4b+htB7lT?=
 =?us-ascii?Q?sQ+oFXShi2358095+h/YimWWEpcbs56p22CFf5jhMoGpPrx7NPT0VdZfLawx?=
 =?us-ascii?Q?xxhTLUCfCvcwjby02guW3y7HIURneTilv71OlwO4772m3TZuurkLyYfRboSL?=
 =?us-ascii?Q?XjZEwhUXZKovxucws75Itu2kd0u/sxwrhozxG7JVdDXTxqICrqp/T7PpW2gC?=
 =?us-ascii?Q?cHa6gtzDTvI99cby+BSW1FArYapsipWHP7HRYsAY7ycSak0lkoUKDv60740p?=
 =?us-ascii?Q?c3SHVb34BL3GV7tUmI8jG2zR8ZWi4to+DymAYE+tUbKHOkQRPG8QIjSScweS?=
 =?us-ascii?Q?wMpR/hmKXidZiD1/jHvaW3hVqYPgBvKZZ/dNwSMfoyqp5306LekgGurGvwLA?=
 =?us-ascii?Q?WVIepDKG4lxlyG/zG2ZOejEUpgbwXUSUSzGHiaVoEV/DIBE9hQUR8KMThPE+?=
 =?us-ascii?Q?SlyRWF2UTRNLDWuzJsR0ONqKddjbQXqJPRGyUUpehGWiErje69LwhxlxCKQJ?=
 =?us-ascii?Q?SPRPxKlJ0doO/TUFKUSo9Z3u463xOR7UQEAyLYGJ5W5fiVfaL1JprxFyveNK?=
 =?us-ascii?Q?H1qO1Qrjw61o9lqknIjty94tPofVeVKLBAVYBvqRYUY8RLGtqDVAOmTEVJes?=
 =?us-ascii?Q?byCZ18WDLzDSvN5ygjRFESvn8trqakQNaZrKG08wY/O6hJ9mTYnCaBZsng7q?=
 =?us-ascii?Q?BZ2RBv0YoZy0VcQoAW0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d1bc984-9274-4276-010a-08d9e77d52a4
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 01:26:09.4293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LZ7FUW7/DtGH/7+bmbdHyUvtZT2wesITP9BlMyQF+gLsuky3pp5l/+NbEI97u9dF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4180
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 03, 2022 at 05:22:36PM -0800, John Hubbard wrote:
> > So why do we return 0, if it means an error, instead of returning the
> > actual errno?
> 
> Well, now returning 0 sounds all wrong, when you put it like that. :)
> 
> So, simply this approach? :
> 
> @@ -1205,8 +1201,15 @@ static long __get_user_pages(struct mm_struct *mm,
>  		} else if (PTR_ERR(page) == -EEXIST) {
>  			/*
>  			 * Proper page table entry exists, but no corresponding
> -			 * struct page.
> +			 * struct page. If the caller expects **pages to be
> +			 * filled in, bail out now, because that can't be done
> +			 * for this page.
>  			 */
> +			if (pages) {
> +				ret = PTR_ERR(page);
> +				goto out;
> +			}
> +
>  			goto next_page;
>  		} else if (IS_ERR(page)) {
>  			ret = PTR_ERR(page);

It is what I had in mind, I certainly wouldn't add a new condition
that returns 0..

Jason