Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9915edbf-ccda-be71-87a0-0c74c683d3d8@linux.intel.com>
Date:   Sat, 5 Feb 2022 11:31:31 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Cc:     baolu.lu@linux.intel.com, LKML <linux-kernel@vger.kernel.org>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        iommu@lists.linux-foundation.org
Subject: Re: [PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get_device()
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        David Woodhouse <dwmw2@infradead.org>
References: <1807113.tdWV9SEqCh@kreacher>
From:   Lu Baolu <baolu.lu@linux.intel.com>
In-Reply-To: <1807113.tdWV9SEqCh@kreacher>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/2/2 2:11, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/iommu/intel/dmar.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/iommu/intel/dmar.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/intel/dmar.c
> +++ linux-pm/drivers/iommu/intel/dmar.c
> @@ -789,7 +789,8 @@ static int __init dmar_acpi_dev_scope_in
>   				       andd->device_name);
>   				continue;
>   			}
> -			if (acpi_bus_get_device(h, &adev)) {
> +			adev = acpi_fetch_acpi_dev(h);
> +			if (!adev) {
>   				pr_err("Failed to get device for ACPI object %s\n",
>   				       andd->device_name);
>   				continue;

Please adjust the patch title to "iommu/vtd: Replace acpi_bus_get_device()"

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu