Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b95078f2-180a-e691-d10b-f19a87575274@linaro.org>
Date:   Thu, 3 Feb 2022 08:14:41 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4] sched/fair: Fix fault in reweight_entity
Content-Language: en-US
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>, peterz@infradead.org
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Zhang Qiao <zhangqiao22@huawei.com>, stable@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        syzbot+af7a719bc92395ee41b3@syzkaller.appspotmail.com
References: <20220125193403.778497-1-tadeusz.struk@linaro.org>
 <20220127205623.1258029-1-tadeusz.struk@linaro.org>
 <dc241a1f-74c2-3db6-e932-04b653e469bb@arm.com>
From:   Tadeusz Struk <tadeusz.struk@linaro.org>
In-Reply-To: <dc241a1f-74c2-3db6-e932-04b653e469bb@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/3/22 01:40, Dietmar Eggemann wrote:
>> -static void set_load_weight(struct task_struct *p, bool update_load)
>> +static void set_load_weight(struct task_struct *p)
>>   {
>>   	int prio = p->static_prio - MAX_RT_PRIO;
>>   	struct load_weight *load = &p->se.load;
>> +	bool update_load = !(READ_ONCE(p->__state) & TASK_NEW);
> nit-pick: reverse fir tree order
> 
> cat Documentation/process/maintainer-tip.rst | grep -A 10 "Variable
> declarations"
> 
> I was able to recreate the initial issue with the reproducer on arm64
> Juno-r0 with CONFIG_CGROUP_SCHED=y .
> 
> Reviewed-by: Dietmar Eggemann<dietmar.eggemann@arm.com>

Thanks for reviewing. I will send a v5 soon.

-- 
Thanks,
Tadeusz