Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Feb 2022 11:08:51 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 06/44] mm/pkeys: Add Kconfig options for PKS
Message-ID: <20220204190851.GY785175@iweiny-DESK2.sc.intel.com>
References: <20220127175505.851391-1-ira.weiny@intel.com>
 <20220127175505.851391-7-ira.weiny@intel.com>
 <9c4a8275-236d-67b6-07f9-5e46f66396c0@intel.com>
 <20220128231015.GK785175@iweiny-DESK2.sc.intel.com>
 <f72b0e17-11bf-b12e-fe7a-d38b0833acdc@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f72b0e17-11bf-b12e-fe7a-d38b0833acdc@intel.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Fri, Jan 28, 2022 at 03:51:56PM -0800, Dave Hansen wrote:
> On 1/28/22 15:10, Ira Weiny wrote:
> > This issue is that because PKS users are in kernel only and are not part of the
> > architecture specific code there needs to be 2 mechanisms within the Kconfig
> > structure.  One to communicate an architectures support PKS such that the user
> > who needs it can depend on that config as well as a second to allow that user
> > to communicate back to the architecture to enable PKS.
> 
> I *think* the point here is to ensure that PKS isn't compiled in unless
> it is supported *AND* needed.

Yes.

> You have to have architecture support
> (ARCH_HAS_SUPERVISOR_PKEYS) to permit features that depend on PKS to be
> enabled.  Then, once one ore more of *THOSE* is enabled,
> ARCH_ENABLE_SUPERVISOR_PKEYS comes into play and actually compiles the
> feature in.
> 
> In other words, there are two things that must happen before the code
> gets compiled in:
> 
> 1. Arch support
> 2. One or more features to use the arch support

Yes.  I really think we are both say the same thing with different words.

Ira