Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5100538pxb; Sun, 6 Feb 2022 13:50:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWhukY8jA51gCax6HwaHE0WFDkrthsOatrd3t/087Ier4u9ZU2Lk2Fqujc9IzLPHxNa6im X-Received: by 2002:a17:907:928:: with SMTP id au8mr2047899ejc.72.1644184245719; Sun, 06 Feb 2022 13:50:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644184245; cv=none; d=google.com; s=arc-20160816; b=ScJQR2ptpmy/hfIG15KBO25PQYNrTZVIGEDX2Vq8mADuq9hzPgxog5/PJc1XDSz+l0 Sz2i5fWoiCoVtZ3ka7TsneISg6Ew4zm7Am5C6OMb6rEH9GxCtcwrdtj4mF9epnRU240c QkE9yLS0yy+7trDqcldNe72LummWKdXA8AT8hQj8u3FjCkjlZNCbC4wpgFl4S/wmVzKt ZwSa1HmYLpj8wP9K6zPMRXrr4PUJNDEvanZvwieVwSeiJE6WaSQhbeZ9fqg6EYdOB8Jd e6o5MLWr0wJwu4HXHfLp6Fa7Xi9599q+WtOYLm2BMgwTO88Fsnt/YNZuD0Fi7KEd0Eyl f7rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=y95VeXJpx3vOoeikTCD1Ve6P/I02Gee/QGrE9GHvt58=; b=rgO8Ix800EW6Xe/86jUzBUD2FdTtYqJJQIhrdT86OfxUZxfCN8C/CuJ5gonOB1F1ek GdMpimGWlCILW43xlHN2JYpp3t2yZyaqto4lPwr785kcSklIubBUXGQACs41y1+pTS1B Uoes+vwwZ6a4t6obfFxOluaS6m2C7bvcGATxen71CIlbLu7xirkW2vjV6OItNffGpTfF 5kZf4a/eMmqqiU/yVEItnNOE5ElRd6IT+0kVtORBYXwagCOXbG8g48FtP6bmwNlYhCDW XeRHFJHGQXVgDxz82hCosWtxJZs8cehqj5SlOPu/w1ujSrhWZonbS1dLhrkRhenrf68j 0hpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Hwy8ON0g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21si5852070eji.830.2022.02.06.13.50.21; Sun, 06 Feb 2022 13:50:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Hwy8ON0g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354680AbiBCVUq (ORCPT + 99 others); Thu, 3 Feb 2022 16:20:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354625AbiBCVUp (ORCPT ); Thu, 3 Feb 2022 16:20:45 -0500 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF30C06173D for ; Thu, 3 Feb 2022 13:20:45 -0800 (PST) Received: by mail-oo1-xc2d.google.com with SMTP id c7-20020a4ad207000000b002e7ab4185d2so2672321oos.6 for ; Thu, 03 Feb 2022 13:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=y95VeXJpx3vOoeikTCD1Ve6P/I02Gee/QGrE9GHvt58=; b=Hwy8ON0gG1kh+ZTpl33LE55dFkF7cMNSwBU+IDKTLPfYa6tqKfxAJFe49sUn0vO69V JPT2hu3wAB/ef+R0ClcvvjISRSyq2uTNpGXa+bFl/FjuCt8XJjsJAxlbUoUq0mzQ4hxH ni2gqqiJcNw/QkcHZMICYFkXaggG4jeMSMk1s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=y95VeXJpx3vOoeikTCD1Ve6P/I02Gee/QGrE9GHvt58=; b=RHD9ubeGNmSXxwWi9+2cJhvEs+tjUHC+A9+GfIotrj24t0kPEC9pQTgj/jrXwmBdvP 8zDpXMBpbs9mWMZABuS1xZ3TXZTWXQwz0Gq201LkEd2XuOQ81Jk52pNJtzTlmeKVXOfG GY1jSvVGmJmdl/pzhdokrp1IzwWnl+HKMn6ZdpsrnVNs/sqcuvj+6GtK2ZwLqLlSH+md zZpi+HcVbixogqWYklfdfFHQ7uDmYJnkdjwQL5pwD6tC92NUv1QZyU8s6/BPeHT8gekS 24Kkr9CGvlxqnQYjh8sbPxkg9H39TB2yH4eNEAckGAUd9Q6Jad4IrknXsoWclEuGtYBy pikg== X-Gm-Message-State: AOAM533b4i7edzQWIfn554/FKv05QkJm60zwikEWaQSHX3yrOnoQ9e9v v2J6J/ivLxx8LUOHCZ6RDGv0mx0ebPDTRDGOGGMEwQ== X-Received: by 2002:a05:6870:6256:: with SMTP id r22mr1865oak.8.1643923244734; Thu, 03 Feb 2022 13:20:44 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 3 Feb 2022 21:20:44 +0000 MIME-Version: 1.0 In-Reply-To: <20220203010804.20883-4-quic_amelende@quicinc.com> References: <20220203010804.20883-2-quic_amelende@quicinc.com> <20220203010804.20883-4-quic_amelende@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 3 Feb 2022 21:20:44 +0000 Message-ID: Subject: Re: [PATCH v3 3/4] input: misc: pm8941-pwrkey: add software key press debouncing support To: Anjelique Melendez , dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, collinsd@codeaurora.org, bjorn.andersson@linaro.org, skakit@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anjelique Melendez (2022-02-02 17:08:07) > From: David Collins > > On certain PMICs, an unexpected assertion of KPDPWR_DEB (the > positive logic hardware debounced power key signal) may be seen > during the falling edge of KPDPWR_N (i.e. a power key press) when > it occurs close to the rising edge of SLEEP_CLK. This then > triggers a spurious KPDPWR interrupt. > > Handle this issue by adding software debouncing support to ignore > key events that occur within the hardware debounce delay after the > most recent key release event. > > Signed-off-by: David Collins > Signed-off-by: Anjelique Melendez > --- Is there a Fixes tag that should be here? Is it a new problem with newer PMICs?