Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa81c069-2471-34bd-b7e1-f06508ae6104@oracle.com>
Date:   Fri, 4 Feb 2022 18:20:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM
Content-Language: en-US
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     Borislav Petkov <bp@alien8.de>, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, mchehab@kernel.org,
        tony.luck@intel.com, james.morse@arm.com, rric@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com
References: <20220202144307.2678405-1-yazen.ghannam@amd.com>
 <20220202144307.2678405-2-yazen.ghannam@amd.com>
 <a42a7696-0150-6d63-953e-adec19e25d02@oracle.com> <YfviHFrzzdapbwDt@zn.tnic>
 <962dc65c-6e52-bf02-5ba5-7e8731442390@oracle.com>
 <Yf1LchOlECslWK2b@yaz-ubuntu>
From:   William Roche <william.roche@oracle.com>
In-Reply-To: <Yf1LchOlECslWK2b@yaz-ubuntu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHJ5Wmw1TXFScHFETGNqOHhwUFhnT0dKeldxTkt4VWUvYUFTQVFSdGRvanVr?=
 =?utf-8?B?L2t2cksxZTVqallFdWcxYUZnOU55OFJGT3lKMDRjVFZyTmg4M2V3aVNBMGN0?=
 =?utf-8?B?SFJYMzF2eHl6QWhqVytMSi9JMXZsRmFXaWtlVitJVXdHSW5TeFJxRG9oM0Fx?=
 =?utf-8?B?MTcyUkxLR1BwZjVIYmRJMDIrazRsSVNiWWJiWEQ0aFRFOWkrLzBvYkt3U1Jo?=
 =?utf-8?B?bHdnSXJCeWoyU3d5Z1JHR2paUmxuUmZNUkdFVGRKMjJ2MjRDeDBrWHczTytI?=
 =?utf-8?B?MWx3SktXR3Z2ekZMdStWWjdoWmJiTjZjNkFHL3hkRWVvNHN1L3lMdzZ6V1c5?=
 =?utf-8?B?YVBhcFg2NzZOOXRONEE3MTVGRXBmUGFMck5MczkwbXhnZlYxY1dlSFV4SHJm?=
 =?utf-8?B?MExIUVBQY2RQZHorRUVabURObU90dUhKR1k1YXFCTzdUaXgrR0gxQ0tKMGVo?=
 =?utf-8?B?b1lVSlNXRWlib2dtMjBVWVViY1JBRHY0RmZGSXo1RVRmcDkxbitGM0FSbS9m?=
 =?utf-8?B?dEppenBFV1lsQXpUeUgxZnlVSitSeTloM2J3NElMQlpwQ2ZndXNvcSt3Z0NL?=
 =?utf-8?B?TzhxdG1hQXVWQU1wSDE4YUhOZ3pUZFIvU0gvWllUTzluc25rejhlRXArRVhp?=
 =?utf-8?B?akx3a2pRY1BKVUZwZmdjV2p2L05EYk02RzVXbGRkYVQxWStGdW51VUFJcXpU?=
 =?utf-8?B?ZkZ2Vkcrc1NTcmJzZU43Q0Z3dEpLN0VHZ0tHR3diUjh1SEZ6aWlJcXlHTytt?=
 =?utf-8?B?TWhMQ0RvQ0tHZ1ZPYjEwb1dKY0pOMlRFeG1hWEFWNjljcVFjWmdhOHNqVkxG?=
 =?utf-8?B?MkhsQnpucDI0anF6OHhISURITkJmZ0JRaGlHTEFkem5NUnNxVnFRbkhvRFVa?=
 =?utf-8?B?blFnVXJDTTZSclk5eWlkSXVENDlORHV2RDEvcCtkd3hMclhEZGVpSTkvYjRG?=
 =?utf-8?B?V29WNFpTdnZrbkJCekg3cmsybFJwMHp3L2x6dVRKTzVVRDhrSDJBK0I0Rytx?=
 =?utf-8?B?WGFmZW9YS2Q1OVUxSzZnbGp2UzNBbzJJb25PczVvMkNTUjFqdmM0cWZBVmdh?=
 =?utf-8?B?eWh5VmtPNXNJRWFGSW9SeWZOS3orR09seVBOMW5YTkp6Q1J1bXNoUERnZGVq?=
 =?utf-8?B?RXMxQ29Oa1Bmd2gvKzVuZlM3T0VZUWJKN0ZrNzdQMVZ5VGJTT3VHUzhGWXZD?=
 =?utf-8?B?ZzNFZjRHTlpXU203YUNWOFdtbGFvKzJDeFJZN0dvMU5kUWlyTnJOUzNhVHkr?=
 =?utf-8?B?bGh0eEtjSTkzcncvL3p5eDkvV3JHWFVHZTF5Nm03TlE0T2pKdnFYRDlNWThB?=
 =?utf-8?B?R1B3bTBmTTJYTHF0b1F2RzlycmRNMXJMelJxQlY5RVkweFVwd0V4QldNSFU2?=
 =?utf-8?B?U0cvbXBEOTlyczBaTWlxOWkrcDVueVJaMzc0SWtLZmQ3WTdCUHh6NkY3YWxG?=
 =?utf-8?B?NUNzWVl6ZUg2MWJqRDEyTHZrSXRENGpwcmZ2bENnYkVoelRJMFk3NWtXVU1L?=
 =?utf-8?B?UTZrVVdlUDBIbW9jaVdPZG5Gb2Vpa2NQaHh0TE5uRVV6NUJoRmowd1Q2KzZ2?=
 =?utf-8?B?YVhFck1Vc0pCZWtGdng4NjNmQ2lselVLTml0ZlhCVlhtM1I5S2JzWk5YYmlt?=
 =?utf-8?B?aDFSSmRSRVlHaGF3NXJVUC9Ja2dGVmg1Y2RrMExERHRKT2JPZjdFVWhsMVJJ?=
 =?utf-8?B?RFBUYzlJWEl3M1BkdE9TZ2VXVkNwMmlIclhhNEFxRFB5dnJkeUFSWjdrVXhG?=
 =?utf-8?B?aTBPWlBYMzRaT3pwT1Vybks4WkVrS0hZVXRybVU2NFlJYzNmU1hyaVdHQlBM?=
 =?utf-8?B?bnFPOVhrRXhqS2gxTnArV0gxMXlnY0VpbFVPRkpxT1BCa1dPczhmTDRFdVJw?=
 =?utf-8?B?T3ZOLzRMU3V0VUZlSkorV2NjTWxhR3VkeVNHK2llZVVzLzJ1Mk00VFRFZUxT?=
 =?utf-8?B?OGJqR0lmR05WWEtzMHFoTGw3aWxLVXJyZy9uWUZ5dDI3N0lrcU5PUURCbXUx?=
 =?utf-8?B?SXFLVHdXTWZuR2NCaEtrZkhCT05KSUhYUE5UUE1vM3d2WFpHMmQ1L2s0UVhm?=
 =?utf-8?B?UWpITy9OaXdjN1BxU2pZNlM0V3BMd1VvWmJscVZrUWhjTGtOOGs2SkZHQU9v?=
 =?utf-8?B?NWd1ZmpHSHc4M2gyWFlSS0pnYWJVclEzNzhEVk5uZS9oM1owLzVHejNqSkQr?=
 =?utf-8?B?aUhFbHZzLzdFMXF2djJIdUh0RXRkT2FTYzhoWWtvTytJazNqN01NOGxKN0Zj?=
 =?utf-8?B?azI0UEl5VHVvdDgzQ3J5T3o3OUFRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45463029-06ea-4f41-d71c-08d9e802b821
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5481.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 17:21:03.0033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EhUY6IdKMCse49sPNRqybJu0FF1cK11kdZtSWSpVZ46oge1VzV7BJmCbmEQklWfWoOju+kKH/Sn6j+SrqzPWItijBUgy/VIskF4zBbpu70M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4342
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10248 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 bulkscore=0 adultscore=0 mlxlogscore=939 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040096
X-Proofpoint-GUID: sTi2gbA44r867PM8BHphhChXvQoDb-l6
X-Proofpoint-ORIG-GUID: sTi2gbA44r867PM8BHphhChXvQoDb-l6
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/02/2022 16:51, Yazen Ghannam wrote:

>
> diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> index 6f8147abfa71..38e5ad95d010 100644
> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -397,7 +397,12 @@ struct amd64_pvt {
>   	/* place to store error injection parameters prior to issue */
>   	struct error_injection injection;
>   
> -	/* cache the dram_type */
> +	/*
> +	 * cache the dram_type
> +	 *
> +	 * NOTE: Don't use this for Family 17h and later.
> +	 *	 Use dram_type in struct amd64_umc instead.
> +	 */
>   	enum mem_type dram_type;
>   
>   	struct amd64_umc *umc;	/* UMC registers */

It works for me Yazen.
Thanks!