Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c14e0ce7d2a84f3b7f51abc22f140d6ea69b724.camel@linux.intel.com>
Subject: Re: [PATCH 1/3] platform/x86: Add Intel Software Defined Silicon
 driver
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     hdegoede@redhat.com, andriy.shevchenko@linux.intel.com,
        srinivas.pandruvada@intel.com, mgross@linux.intel.com,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Mark Gross <markgross@kernel.org>
Date:   Thu, 03 Feb 2022 21:07:24 -0800
In-Reply-To: <Yfjz/CRUxeVGKaaQ@kroah.com>
References: <20220201030424.1068816-1-david.e.box@linux.intel.com>
         <20220201030424.1068816-2-david.e.box@linux.intel.com>
         <Yfjz/CRUxeVGKaaQ@kroah.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-02-01 at 09:49 +0100, Greg KH wrote:
> On Mon, Jan 31, 2022 at 07:04:22PM -0800, David E. Box wrote:
> > +static struct bin_attribute bin_attr_provision_akc;
> > +static struct bin_attribute bin_attr_provision_cap;
> 
> <snip>
> 
> > +static BIN_ATTR_WO(provision_akc, SDSI_SIZE_WRITE_MSG);
> 
> You the structure twice, why?

Will drop. There's no longer a reference to these attributes before they're
defined.

David

>