Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5496319pxb; Mon, 7 Feb 2022 03:26:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdxrabxlh/MaUzMEgtj4D79BC7UpsRFIQLbBKQcyNJ+uh14Q92KOKkJES7o1XttXDAzW8M X-Received: by 2002:a05:6402:448f:: with SMTP id er15mr13742753edb.222.1644233206079; Mon, 07 Feb 2022 03:26:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644233206; cv=none; d=google.com; s=arc-20160816; b=zEqeIaembes3ZZxkbE5cYTcvtomb+8GGveEhTOEnP2+kCNkZ5FMCcmLJiLqG9sbLq/ zISpXj7Efy0azzdRDdWrNmU5XkbQIN/K+hPnGx4dlTE5sBJL5m/KSsKf4aPWZfqzmHAo OjsgUDyMLJzZys4nyvhxyH3Wx/99UNDTUSHAlsE4CnPdHcbaSwk0Ske0a4lexMTLzqsy Wj5AZLojIXehCtva3UIwiWdoyPQoePSwdKOxE/nzPbq4TIrqlCHp8a7akxbo4Veh3smo nIr0iJdlErH98GVjReg0Wy976jR5smOhjuqBENEcBXtq/0z2jPzDsYREMPT079x00pi4 EXkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CH0OWcXnRkrjgrCYXVT/t1v7cfdo23G2D1dLRWzwJxk=; b=xN3sWLTRxLOxkG7sQGVCWOmIiaiP6WyjN3cyiqlQ+dveC32LICsNXKzCQ7n6ZZHSvt m9uxCyEhV2Ulkw7F3nYsn8Jpak+obAEAQrlknTs5BF1TzrwlsaYSpiOlw0W8Gqzo09yJ W4V1jX6y9LhSyUC8nxFXU/eaZqpizsgOwS0QEKy5nU2s/d8hcjWNqZ0K1jihqUHVKwKy hZJwmi75d0BUunDLFoXPdUzzNxNJGNgfSPagetF6RZal/O6ewk9UH8xlrjFfaMbgSx2H b4KJjVxHGTgPt/G5Ij/VRC1hicWBK7E6PqTPT2M+SpznUCv5gqqLEWr8z7waYcl0am2Y PHcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cqMEdtWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13si2034466edo.519.2022.02.07.03.26.21; Mon, 07 Feb 2022 03:26:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cqMEdtWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243094AbiBFOpk (ORCPT + 99 others); Sun, 6 Feb 2022 09:45:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231978AbiBFOph (ORCPT ); Sun, 6 Feb 2022 09:45:37 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ED158C043183 for ; Sun, 6 Feb 2022 06:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644158735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CH0OWcXnRkrjgrCYXVT/t1v7cfdo23G2D1dLRWzwJxk=; b=cqMEdtWl92deT1ocafFua67NZniUYSCHAyP95ihMMhfjxXHiUXwA/rIoBF+m3dxw0vIdNX QSo9tzr2CGnVGABMNjaALYIVQL9jYN6tTywEqv5MZlhFL1LqURQmUvfzHncxWqj3HzJHlr E1eaBSLVEToNREa1rtd79BRXDwG8G2E= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-JeVKA7KKM6OQ1dODVfDZyQ-1; Sun, 06 Feb 2022 09:45:34 -0500 X-MC-Unique: JeVKA7KKM6OQ1dODVfDZyQ-1 Received: by mail-wm1-f69.google.com with SMTP id 130-20020a1c0288000000b0037bc5cbd027so439640wmc.8 for ; Sun, 06 Feb 2022 06:45:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CH0OWcXnRkrjgrCYXVT/t1v7cfdo23G2D1dLRWzwJxk=; b=N0+133OVWtZB3boRsSV0t12gRsA6MpYDIFYVTQbGs9gVmA6ZG2r5Df8Vx3gZksT/rd 9EqIuAefj6aQbNl6KmCwoYI7qr2bnIgG8f6IXv47zT3JQoZQtgaXrrmt429j6MfWQ8gW wo14oZvKyWG++25fhbUOaeNL6WCH91uX7VRSvPjKl0WY6hQTV5ALpVyamABajfNI6SO1 9UzYkChBYxinsUqm9+n63ZvoDCI1kmk4bMe3444OJYxxwlMXibxhAirpobzLyfaWcynF ajHonpGrqq5KI8OsUvutOtgNA2O8LXu/RNmCUDe2bYcBsSEjnEfu0RooccKvL4VhhjSF Z8Hw== X-Gm-Message-State: AOAM530BQHb6r5C4gdJuPkZHCmrRRaMfcIhfwWpwJ6YyjSkkBjUK6K97 pV9/OWAJ876zAzePr5nV/t0PHESXqe1esgwisXPXFG3L9e/HIenkgESvOPONhGe4rVahr4r2edu EKIauTIykbSZDMDYZIt9EU48= X-Received: by 2002:a7b:c109:: with SMTP id w9mr5994541wmi.118.1644158733673; Sun, 06 Feb 2022 06:45:33 -0800 (PST) X-Received: by 2002:a7b:c109:: with SMTP id w9mr5994534wmi.118.1644158733557; Sun, 06 Feb 2022 06:45:33 -0800 (PST) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id o29sm5890498wro.47.2022.02.06.06.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 06:45:33 -0800 (PST) Date: Sun, 6 Feb 2022 14:45:32 +0000 From: Aaron Tomlin To: Christophe Leroy Cc: Luis Chamberlain , Michal Suchanek , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "atomlin@atomlin.com" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "joe@perches.com" Subject: Re: [RFC PATCH v4 00/13] module: core code clean up Message-ID: <20220206144532.wbei7fn77fqrpk5j@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20220130213214.1042497-1-atomlin@redhat.com> <30f0da92-17b0-4130-20d1-9fea8b81cdbc@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <30f0da92-17b0-4130-20d1-9fea8b81cdbc@csgroup.eu> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2022-02-03 07:48 +0000, Christophe Leroy wrote: > All function prototypes in header files are pointlessly prepended with > 'extern' keyword. This was done that way in the old days, but has been > deprecated as this keyword does nothing on function prototypes but adds > visual pollution when looking at the files. Christophe, Firstly, thanks for your initial feedback. I will address the above. Kind regards, -- Aaron Tomlin