Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Feb 2022 14:54:07 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Michal Hocko <mhocko@suse.com>
Cc:     Mike Rapoport <rppt@kernel.org>,
        Wei Yang <richard.weiyang@gmail.com>, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Dennis Zhou <dennis@kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Oscar Salvador <osalvador@suse.de>, Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        Nico Pache <npache@redhat.com>,
        Rafael Aquini <raquini@redhat.com>
Subject: Re: [PATCH 2/6] mm: handle uninitialized numa nodes gracefully
Message-Id: <20220204145407.c32a405fd7e8dc281993e1aa@linux-foundation.org>
In-Reply-To: <YfuUxI3k27msAORC@dhcp22.suse.cz>
References: <20220127085305.20890-1-mhocko@kernel.org>
        <20220127085305.20890-3-mhocko@kernel.org>
        <YfKgE5hTgbaBeaMa@kernel.org>
        <YfKwjAlPW2kJUv5w@dhcp22.suse.cz>
        <20220201024119.2ailcw4rp5thambz@master>
        <YfkDXYhGjAvAKKeU@dhcp22.suse.cz>
        <20220203002116.akpk5um5nkpeflve@master>
        <YfuC6IaasxcnAdGl@kernel.org>
        <YfuUxI3k27msAORC@dhcp22.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 3 Feb 2022 09:39:32 +0100 Michal Hocko <mhocko@suse.com> wrote:

> > I shuffled the words a bit, maybe this sounds better not only to me :)
> > 
> > /*
> >  * We do not want to confuse userspace by sysfs files/directories for node
> >  * without any memory attached to it, so this node is not marked as
> >  * N_MEMORY and not marked online so that topology_init() won't create
> >  * sysfs hierarchy for this node.  The pgdat will get fully initialized by
> >  * hotadd_init_pgdat() when memory is hotpluged into this node
> >  */
> 
> Yes, I like this comment more than mine. Andrew could you replace it in
> your tree or should I repost the patch?

I did this.

--- a/mm/page_alloc.c~mm-handle-uninitialized-numa-nodes-gracefully-fix
+++ a/mm/page_alloc.c
@@ -8155,12 +8155,16 @@ void __init free_area_init(unsigned long
 			}
 			arch_refresh_nodedata(nid, pgdat);
 			free_area_init_memoryless_node(nid);
+
 			/*
-			 * not marking this node online because we do not want to
-			 * confuse userspace by sysfs files/directories for node
-			 * without any memory attached to it (see topology_init)
-			 * The pgdat will get fully initialized when a memory is
-			 * hotpluged into it by hotadd_init_pgdat
+			 * We do not want to confuse userspace by sysfs
+			 * files/directories for node without any memory
+			 * attached to it, so this node is not marked as
+			 * N_MEMORY and not marked online so that no sysfs
+			 * hierarchy will be created via register_one_node for
+			 * it. The pgdat will get fully initialized by
+			 * hotadd_init_pgdat() when memory is hotplugged into
+			 * this node.
 			 */
 			continue;
 		}
_