Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH][next] usb: gadget: f_uac2: Fix spelling mistake
 "maxpctksize" -> "maxpcktsize"
To:     Joe Perches <joe@perches.com>,
        Colin Ian King <colin.i.king@gmail.com>,
        Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220202091933.580713-1-colin.i.king@gmail.com>
 <358563808e6cad1b003e4c5488cf65ff1267f1d8.camel@perches.com>
From:   Pavel Hofman <pavel.hofman@ivitera.com>
Message-ID: <efcb90c2-cfbb-3264-bd6d-bca33b03fa48@ivitera.com>
Date:   Wed, 2 Feb 2022 11:31:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <358563808e6cad1b003e4c5488cf65ff1267f1d8.camel@perches.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


Dne 02. 02. 22 v 10:57 Joe Perches napsal(a):
> On Wed, 2022-02-02 at 09:19 +0000, Colin Ian King wrote:
>> There is a spelling mistake in a deb_dbg message. Fix it.
> []
>> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
> []
>> @@ -755,7 +755,7 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o
>>   
>>   	if (max_size_bw <= max_size_ep)
>>   		dev_dbg(dev,
>> -			"%s %s: Would use maxpctksize %d and bInterval %d\n",
>> +			"%s %s: Would use maxpcktsize %d and bInterval %d\n",
> 
> why not just spell it out? or use wMaxPacketSize from the uapi include?

My reason for the ugly abbreviation (prone to misspelling for which I 
apologize) was to keep the line length limit. I would be happy to see 
wMaxPacketSize instead :-)

Pavel.

> ---
>   drivers/usb/gadget/function/f_uac2.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
> index f2237bcdba7c0..13b59128121a2 100644
> --- a/drivers/usb/gadget/function/f_uac2.c
> +++ b/drivers/usb/gadget/function/f_uac2.c
> @@ -755,12 +755,12 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o
>   
>   	if (max_size_bw <= max_size_ep)
>   		dev_dbg(dev,
> -			"%s %s: Would use maxpctksize %d and bInterval %d\n",
> +			"%s %s: Would use wMaxPacketSize %d and bInterval %d\n",
>   			speed_names[speed], dir, max_size_bw, bint);
>   	else {
>   		dev_warn(dev,
> -			"%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n",
> -			speed_names[speed], dir, max_size_bw, bint, max_size_ep);
> +			 "%s %s: Req. wMaxPacketSize %d at bInterval %d > max ISOC %d, may drop data!\n",
> +			 speed_names[speed], dir, max_size_bw, bint, max_size_ep);
>   		max_size_bw = max_size_ep;
>   	}
>   
> 
>