Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Feb 2022 11:21:28 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 07/44] x86/pkeys: Add PKS CPU feature bit
Message-ID: <20220204192128.GA785175@iweiny-DESK2.sc.intel.com>
References: <20220127175505.851391-1-ira.weiny@intel.com>
 <20220127175505.851391-8-ira.weiny@intel.com>
 <63950211-4244-3f85-0fb3-eb5a38d4ed50@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <63950211-4244-3f85-0fb3-eb5a38d4ed50@intel.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Fri, Jan 28, 2022 at 03:05:36PM -0800, Dave Hansen wrote:
> On 1/27/22 09:54, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > Protection Keys for Supervisor pages (PKS) enables fast, hardware thread
> > specific, manipulation of permission restrictions on supervisor page
> 
> Nit: should be "hardware-thread-specific".
> 
> > mappings.  It uses the same mechanism of Protection Keys as those on
> > User mappings but applies that mechanism to supervisor mappings using a
> > supervisor specific MSR.
> 
> "supervisor-specific"
> 
> 	Memory Protection Keys (pkeys) provides a mechanism for
> 	enforcing page-based protections, but without requiring
> 	modification of the page tables when an application changes
> 	protection domains.
> 
> 	The kernel currently supports the pkeys for userspace (PKU)
> 	architecture.  That architecture has been extended to
> 	additionally support supervisor mappings.  The supervisor
> 	support is referred to as PKS.
> 
> I probably wouldn't mention the MSR unless you want to say:
> 
> 	The main difference between PKU and PKS is that PKS does not
> 	introduce any new instructions to write to its register.  The
> 	register is exposed as a normal MSR and is accessed with the
> 	normal MSR instructions.
> 
> 
> > The CPU indicates support for PKS in bit 31 of the ECX register after a
> > cpuid instruction.
> 
> I'd just remove this sentence.  We don't need to rehash each tiny morsel
> of the architecture in a commit message.

All done.  Thanks for the verbiage.
Ira