Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbXBJSRg (ORCPT ); Sat, 10 Feb 2007 13:17:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751723AbXBJSRg (ORCPT ); Sat, 10 Feb 2007 13:17:36 -0500 Received: from mga09.intel.com ([134.134.136.24]:5418 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720AbXBJSRf convert rfc822-to-8bit (ORCPT ); Sat, 10 Feb 2007 13:17:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: i="4.13,310,1167638400"; d="scan'208"; a="45195926:sNHT25943706" Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT X-MimeOLE: Produced By Microsoft Exchange V6.5 Subject: RE: [PATCH] aio: fix kernel bug when page is temporally busy Date: Sat, 10 Feb 2007 21:17:38 +0300 Message-ID: In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] aio: fix kernel bug when page is temporally busy Thread-Index: AcdNPhCje+AZGt65T76Cw7xbV0K8hgAANoQQ From: "Ananiev, Leonid I" To: "Ken Chen" Cc: , "Andrew Morton" , , "linux-aio" , "Zach Brown" , "Chris Mason" , "Badari Pulavarty" X-OriginalArrivalTime: 10 Feb 2007 18:17:35.0587 (UTC) FILETIME=[BD331B30:01C74D3F] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 43 But if page is busy as invalidate_inode_pages2_range() says because of bh_count>0 then aio_complet() is not called from aio_run_iocb() and next retry() will get the iocb result. Leonid -----Original Message----- From: Ken Chen [mailto:kenchen@google.com] Sent: Saturday, February 10, 2007 9:05 PM To: Ananiev, Leonid I Cc: suparna@in.ibm.com; Andrew Morton; linux-kernel@vger.kernel.org; linux-aio; Zach Brown; Chris Mason; Badari Pulavarty Subject: Re: [PATCH] aio: fix kernel bug when page is temporally busy On 2/9/07, Ananiev, Leonid I wrote: > I have used EIOCBRETRY in the patch to minimize source code modification > only. > [...] > A lot of errno's have different meaning in different functions or > contexts. EAGAIN could be used instated of EIOCBRETRY for irredundant > set. I also think the original patch is wrong. It might shut up kernel panic by eliminate double calls to aio_complete(), but it will silently introduce data corruption. If invalidate_inode_pages2_range() says it can not invalidate pages, while dio to the same file offset range is in flight, something is really wrong there. In generic_file_direct_IO, the function explicitly flushes all dirty pages and wait on them before submits DIO. So any error value returned from invalidate_inode_pages2_range() has to be taken seriously in the direct IO submit path instead of dropping it to the floor. - Ken - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/